output from loop and writing to file (seperate problems)

lol, I'm back.... I'll probably get it fixed on my own, but still.... maybe someone else will have the same problem and can figure it out from this instead of having to make a post....

Code:

---

        case 'b':        //pulls list of bowlers, creates score file for bowlers, adds scores to file
                {
                        if (caseb == 1)
                                goto LOAD;
                        else
                                goto STARTB;

STARTB:                                                        //pulls list of bowlers

                        value = 0;
                        MasterlistIn.open("Masterlist.txt");
                        getline(MasterlistIn, Master[value]);
                        value++;
                        while (MasterlistIn)
                        {
                                getline(MasterlistIn, Master[value]);
                                value++;
                        }
                        control = value;
                        MasterlistIn.close();
                        caseb++;

LOAD:                                                        //creates/opens bowler score file and adds scores

                        cout << "Select created bowler." << endl << endl;
                        control = value;
                        value = 0;
                        for (value = 0; value < control - 1; value++)
                        {
                                cout << "Press " << value + 1 << " to load " << Master[value] << "." << endl;
                        }
                        cin >> loadbowl;
                        system("cls");
                        cout << "Loading bowler data for " << Master[loadbowl - 1] << endl;
                        bowler = Master[loadbowl - 1] + "_scores.txt";
                        inData[loadbowl - 1].open(bowler.c_str());
                        inData[loadbowl - 1].close();
                        outData[loadbowl - 1].open(bowler.c_str(), ios::app);
                        Sleep(1000);
                        system("cls");
                        cout << Master[loadbowl - 1] << " loaded." << endl;
                        system("cls");
                        cout << "Enter scores (3 games!)." << endl << endl
                                << "Score for first game." << endl;
                        cin >> game1;
                        cout << endl
                                << "Score for second game." << endl;
                        cin >> game2;
                        cout << endl
                                << "Score for third game." << endl;
                        cin >> game3;
                        set = game1 + game2 + game3;
                        cout << "Total set is " << set << " ." << endl;
                        outData[loadbowl - 1] << game1 << endl
                                                                  << game2 << endl
                                                                  << game3 << endl
                                                                  << set << endl;
                        Sleep(1000);
                        outData[loadbowl - 1].close();
                } break;

---

ok, first problem, the loop, fixed my initial problem which was after returning to the menu and choosing this option, lol, maybe I should explain what the code does.... Ok, this part, it opens the master list from my previous thread and pulls out all the names.... shows the list on screen, the user selects a name from the list, the program creates a file for the name and then lets the user input the scores for that name.... it adds the scores together and gives that total.... program gives th eoption to exit or return to menu....

now for the problems.... my initial problem I was talking about earlier, you run this option, return to the menu and select this option again.... The list of names doesn't show, but you can type in the number for one of the names, and it's recognized.... I fixed that by the if-goto-else-goto and the caseb++ up at the top.... But each time you run this option without exiting, the last name on the list doesn't show.... I'm testing it with 4 names, the first time, all four show, the second time, only the first 3 show, the 3rd time, only the first two show.... I'm sure if I add control++ after the control = value right inside of LOAD, it'll fix it, but I'm not sure.... might have to setup an if statement and put a control in there like I did with the caseb++ and the if-goto at the top....

next problem.... it won't copy the scores and total set into the file for the very first name on the list.... it works fine for all of the other names, just the first on the list is giving me problems....

ok.... weird.... didn't change anything, it'll write the scores to the file for the first name on the list now.... any idea why it'd do that?

the control++ right after the control = value inside of LOAD I was talking about keeps the last name from disappearing, but it adds another line.... Shows the four names and a fifth without a name, doens't add a sixth or seventh with each repetition and it doesn't take away the last name, either.... any way around this?

you generally don't want to use gotos. try if else statements instead. sometimes i wonder why books teach you goto.

in your first "for" loop (the LOAD section), you have:

Code:

---

for (value = 0; value < control - 1; value++)
{...

---

I would have thought you'd want:

Code:

---

for (value = 0; value < control; value++)
{...

---

as when looping through an array, the code

Code:

---

for (value = 0; value <  arraysize; value++)
{...

---

is correct as < arraysize will make it stop at arraysize-1, which is the index of the last item in the array.

You probably didn't need that explaing but hey!

Hope that helps,

dt

trying something.... noticed I was using control up in the menu section, that's why the list would disappear entirely the second time around.... with value < control - 1, it drops the last name with each repetition unless I put in a control++ before the loop, which then caused it to print out 5 lines instead of the 4 because there's 4 names in the test file.... Each repetition prints 5 lines, so.... I'm changing all of the "control"s in the second option to index and trying value < index in the loop....

value < index prints out 5 lines.... value < index - 1 works perfectly.... this makes no sense.... honestly, it doesn't....

halfway there.... just gotta work on the sections to find high game and high set and calculate averages.... that won't be difficult once I remember how to sort lists....