throwing structures

Hi,

I am throwing a structure from within my class which contains specific error information.
Would anyone be able to tell me if it is stack safe or not. Because I declare an instance
of the structure on the stack, and then assign data to the members of the struct. For example,
this wont compile... just for illustration purposes. Is it safe to process the error in this way?

Code:

---


#include <iostream>

using namespace std;

struct ErrorInfo
{
  CString cStrErrorMsg;
  CString cStrAdditional;
};

func1(void);
func2(void);

int main(void)
{
  try
  {
    func1();
  }
  catch(ErrorInfo error)
  {
    cout << error.cStrErrorMsg << " " <<  error.cStrAdditional << "."
  }

  return 0;
}

func1(void)
{
  try
  {
    func2();
  }
  catch(ErrorInfo error) throw;
}

func2(void)
{
  ErrorInfo error

  error.cStrErrorMsg = "Error Occured";
  error.cStrAdditional = "Nothing";
  throw error;
}

---

Quote:

---

Is it safe to process the error in this way?

---

Not if it doesn't compile it isn't. :D

Quzah.

That was just an example of similar behaviour of how my classes deal with errors. I am able to raise exceptions from 5 levels deep, and the data always seems to be consistant when it gets to the final catch block (This is not normal!, just for testing purposes). So I am presuming this method is safe for handling the errors, and even though the structure was declared on the stack, the throw keyword must make another copy of the structure being thrown some how. Otherwise, the data would be invalid from the stack unwinding.

Yes, that method of throwing exceptions is safe, and is probably one of the better ways of doing exception handling. I would recommend catching the exception structure by reference, though, because an extra copy is made automatically first before reaching the catch block.

This code compiles and works as I expect you'd expect:

Code:

---

#include <iostream>
#include <string>

using namespace std;

struct ErrorInfo
{
  string cStrErrorMsg;
  string cStrAdditional;
};

void func1();
void func2();

int main(void)
{
  try
  {
    func1();
  }
  catch(ErrorInfo& error)
  {
    cout << error.cStrErrorMsg << " " <<  error.cStrAdditional << ".";
  }

  return 0;
}

void func1()
{
  try
  {
    func2();
  }
  catch(ErrorInfo& )
  {
    throw;
  }
}

void func2()
{
  ErrorInfo error;

  error.cStrErrorMsg = "Error Occured";
  error.cStrAdditional = "Nothing";
  throw error;
}

---

Ok, thanks for the reply. Thats what I was looking for.... an answer to my question.

Even if you don't put func2() in a try-catch block in func1(), would main() still catch the exception? I think I heard from someone that a thrown exception will automatically make its way down the stack until a function catches it somewhere along the line. Is it really necessary for the intermediate try-catch if all it does is throw the exception again anyway?

Yes, the exception will be catched by main if there is no catch block in func1().

Ok, thanks.