File Reading and storing to 1 variable

im trying to read a full file using fscanf and storing it to 1 variable
inside the file i have tried i few tests like

test test test
test test test
test test test

i can only get it to read 1 of the tests.is there a simple way to read the entire file and store it to one variable?
thanks

fread().

thanks thats helped a fair bit i was stuck on fscanf :)
its for a win32 unicode app.
im wondering is there a unicode function for fread?

Code:

---

if(fread(&ReadTxt , sizeof(ReadTxt) , 1 , fal)){
                        if(feof(fal)){
                                break;
                        }
                }

---

fal is the file.

i am doing this and then having a messagebox show it and its comming up with alot of messy wide chars.

>and its comming up with alot of messy wide chars.
Did you terminate the string with '\0' before trying to print it? fread is a block transfer function, it doesn't automatically append your buffer with a null character to make it a string.

how would i do that(sorry ive only been doing C a lil while)

also i done it in a normal C app as

Code:

---

#include <stdio.h>
#include <stdlib.h>

int main(void)
{
  FILE *fp;
  char test[2048];
  fp = fopen("test.txt" , "r");
 
 
          while(fp != feof){
                    fread(&test , sizeof(test) , 1 , fp);
                    break;
  } 
    printf("%s" , test);
    getch();
}

---

it reads the file fine but adds a few unwanted chars to the end.
in the unicode winapi program it didnt even get one bit of it right

use fseek to seek to the end of the file
use ftell to grab the position there
fseek back to the beginning
fread your entire file (it is possible that fread will set the file position no farther than the end of the file, so that earlier fseek might not be necessary)
then set the position obtained from ftell in your buffer to 0

beats me how but i accidently added a number to the arraysize on the C version and it worked

Code:

---

#include <stdio.h>
#include <stdlib.h>

int main(void)
{
  FILE *fp;
  char test[12048];
  fp = fopen("test.txt" , "r");
 
 
          while(fp != feof){
                    fread(&test , sizeof(test) , 1 , fp);
                    break;
  } 
    printf("%s" , test);
    getch();
}

---

but i still cant get it to work in my unicode version(win32 api program)

Quote:

---

use fseek to seek to the end of the file
use ftell to grab the position there
fseek back to the beginning
fread your entire file (it is possible that fread will set the file position no farther than the end of the file, so that earlier fseek might not be necessary)
then set the position obtained from ftell in your buffer to 0

---

im not to sure how to use fseek or ftell

ive looked throu google with not to much luck.
could u maybe please make a small example or point me to a link.thanks

t_fpos position;
fseek(file, 0, seek_end); // end of file
position = ftell(file); // grab position
fseek(file, 0, seek_set); // back to start

i might have screwed up the parameters of fseek
also, t_fpos may or may not be a real type. replace it
with int if it does not work, prelude will surely
give the correct answer

thanks for the example.
still not working thou , heres what i tried.

Code:

---

                fseek(fal, 0, SEEK_END);
                pos = ftell(fal);
                fseek(fal, 0, SEEK_SET);
                fread(&ReadTxt , sizeof(ReadTxt) , 1 , fal);

---

pos is int

It doesn't work because you don't do anything with pos. You simply store it. You will want to use the end position to figure out the size you need to allocate. You're not doing this here. You're still simply reading whatever the size of ReadTxt is.

Quzah.

damn this is confusing.sorry for my stupidness but i dont no how to do this :(

i dont quiet understand fread right is it

fread(variable , eof , startof , file);

?

Code:

---

fread( tothisplace, thisisthesizeofanobjecttoread, thisishowmanyobjectstoread, fromthisfile );

---

So find out how big the file is, place that as argument two. Place the number 1 as argument three. Make the first argument a pointer to some place where you've allocated enough memory to hold the total size you're passing (multiply argument two by argument three for total needed size. Add room for the null, assuming you're reading text).

Quzah.

ok i think i got further this time :)

Code:

---

                fseek(fal, 0, SEEK_END);
                pos = ftell(fal);
                fseek(fal, 0, SEEK_SET);
                fread(&ReadTxt , pos , 1 , fal);
                _stprintf(testt , _T("%d") , pos);
                SendMessage(hwndList , WM_SETTEXT , (WPARAM)sizeof(ReadTxt) , (WPARAM)ReadTxt);
                MessageBox(0 , testt , _T("test") , 0);

---

the messagebox is showing the correct size but its setting the text as all wide chars

> SendMessage(hwndList , WM_SETTEXT , (WPARAM)sizeof(ReadTxt) , (WPARAM)ReadTxt);
SendMessage(hwndList , WM_SETTEXT , (WPARAM)pos , (WPARAM)ReadTxt);

still not working :(

also i had 2 WPARAM's i changed it to

Code:

---

SendMessage(hwndList , WM_SETTEXT , (WPARAM)pos , (LPARAM)ReadTxt);

---

and still no luck

try this:
*((char *) (rand()) = 0;

then run it until it works

e: oh well

char stuff[124124];
int pos;
FILE * file = open me a file;

fread(stuff, 124124, 1, file);
fseek(file, 0, seek_end);
pos = ftell(file);
stuff[pos] = 0;

printf(stuff);

i dont think that will help.

this program works fine in C but soon as its with unicode it goes nuts

Code:

---


                int pos;
                TCHAR SaveTxt[2048];
                TCHAR ReadTxt[128];
                TCHAR testt[128];
                FILE *fal;

                fal = fopen("users.txt" , "rw");

                if(fal == NULL){
                        MessageBox(0 , _T("list not found") , _T("Error") , 0);
                }

                fseek(fal, 0, SEEK_END);
                pos = ftell(fal);
                fseek(fal, 0, SEEK_SET);
                fread(&ReadTxt , pos , 1 , fal);
                _stprintf(testt , _T("%d") , pos);
                SendMessage(hwndList , WM_SETTEXT , (WPARAM)pos , (LPARAM)ReadTxt);
                MessageBox(0 , testt , _T("test") , 0);

---

thats all of it.
its like its showing the buffer for ReadTxt because if i change the Arraysize on Readtxt say to 2 then it only shows 2 wierd widechar characters but if i keep it t hat big it shows a whole lot of it

fread(addresstoreadto, sizeofrecord, numberofrecords, file)

that is to say, stop using windows :(

Quote:

---

fread(addresstoreadto, sizeofrecord, numberofrecords, file)

---

?
i have all of that right.

Quote:

---

Originally Posted by Rare177

i dont quiet understand fread right is it

fread(variable , eof , startof , file);

?

---

No. Don't program randomly, but learn to get and read information.

google "man fread" gives (1st answer) :

Code:

---

size_t fread(void *ptr, size_t size, size_t nmemb, FILE *stream);

---

ptr: The address of the destination block of data.
size: the size of an element of data
nmemb : the number of elements of data
stream: the stream object address.
return: the actual number of read elements

Say :

Code:

---

char a[123];
size_t read_nb = fread (a, 1, 123, fp);

---

1 : means one char
123 : means 123 / 1 elements

Could have been written:

Code:

---

char a[123];
size_t read_nb = fread (a, sizeof *a, sizeof a / sizeof *a, fp);

---

Quote:

---

Originally Posted by Rare177

?
i have all of that right.

---

very sorry, i didn't read your snippet until after i posted

i understand how it works now but here ill show u something.

//////////////////////////////
TCHAR ReadTxt[128];
comesup with

獤獦㈴㈲婚婚婚婚婚婚婚婚婚婚婚婚婚婚婚婚婚婚婚婚婚婚婚 婚婚婚婚婚婚婚婚婚婚婚婚婚婚婚婚婚婚婚婚婚婚婚婚婚 婚婚婚婚婚婚婚婚婚婚婚婚婚婚

///////////////////////////////

TCHAR ReadTxt[2048];
comes up with

?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ??????????????????????????
?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ????????????????????
?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ??????????????????????????????????
?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ?????????????????????????????????????????????????? ??????????????????

its like the buffer is becoming the variable data

Quote:

---

Originally Posted by Rare177

i understand how it works now but here ill show u something.

//////////////////////////////
TCHAR ReadTxt[128];
comesup with

獤獦㈴㈲婚婚<...>

///////////////////////////////

TCHAR ReadTxt[2048];
comes up with

??????<...>

its like the buffer is becoming the variable data

---

Please don't copy and paste long strings of random data...

The value of a variable defined in a bloc is undefined.

Try this:

Code:

---

TCHAR ReadTxt[2048] = {0};

---

It makes things clear. (Filled up with 0's).

sorry about the long strings.

i think that helped abit becuase now instead of getting heap of 2048 chars i got 獤獦㈴㈲

but its still not working

im going to get some rest and will work on it when i get up ,
thanks every one for the help

Quote:

---

Originally Posted by ggs

t_fpos position;
fseek(file, 0, seek_end); // end of file
position = ftell(file); // grab position
fseek(file, 0, seek_set); // back to start

---

ftell() does not return t_fpos, it returns a long.

ok still no luck with this working.
i changed it from int to long and its still showing the same result

I'm not sure what is wrong with your code, you'd have to post more of it. If you are interested, here is a set of functions that saves and loads files in UTF8 encoding(the defacto standard for international text).

Sample usage:

Code:

---

/* Save a UTF8 file. */
WriteUTF8File(TEXT("FileName.txt"), TEXT("This is a test éëì"));

/* Load a UTF8 file into an edit control. */
TCHAR* szTest = ReadUTF8File(TEXT("FileName.txt"));
SetWindowText(hwndEdit, szTest);
free(szTest);

---

Code:

Code:

---

/** Header:

#include <windows.h>
wchar_t* MBStr2WStr(LPCSTR strIn, UINT codePage);
char* WStr2MBStr(LPCWSTR strIn, UINT codePage);
char* MBStr2MBStr(LPCSTR strIn, UINT codepageIN, UINT codepageOUT);
BOOL WriteUTF8File(LPCTSTR szFileName, LPCTSTR szText);
TCHAR* ReadUTF8File(LPCTSTR szFileName);

**/


#include <windows.h>
#include <malloc.h>

/*
 * Converts a unciode string to a multi-byte string with the specified code
 * page(CP_ACP for the default). Returned string must be released with free().
 */
char* WStr2MBStr(LPCWSTR strIn, UINT codePage)
{
        int  cchSize;
        char* strOut;

        if (!strIn) return NULL;

        cchSize = WideCharToMultiByte(codePage, 0, strIn, -1, 0, 0, NULL, NULL);
        if (0 == cchSize) return NULL;

        strOut = (char*) malloc(cchSize * sizeof(char));
        if (NULL == strOut) return NULL;

        if (0 == WideCharToMultiByte(codePage, 0, strIn, -1, strOut, cchSize, NULL, NULL))
        {
                free(strOut);
                return NULL;
        }

        return strOut;
}


/*
 * Converts a multi-byte string with the specified code page(CP_ACP for the default)
 * to a unicode string. Returned string must be released with free().
 */
wchar_t* MBStr2WStr(LPCSTR strIn, UINT codePage)
{
        int cchSize;
        wchar_t* strOut;

        if (!strIn) return NULL;

        cchSize = MultiByteToWideChar(codePage, 0, strIn, -1, 0, 0);
        if (0 == cchSize) return NULL;

        strOut = (wchar_t*) malloc(cchSize * sizeof(wchar_t));
        if (NULL == strOut) return NULL;

        if (0 == MultiByteToWideChar(codePage, 0, strIn, -1, strOut, cchSize))
        {
                free(strOut);
                return NULL;
        }

        return strOut;
}


/*
 * Converts a multi-byte string with the specified input code page to a
 * multi-byte string with the specified output code page.
 * Returned string must be released with free().
 */
char* MBStr2MBStr(LPCSTR strIn, UINT codepageIN, UINT codepageOUT)
{
        char*    strOut      = NULL;
        wchar_t* strTextWide = MBStr2WStr(strIn, codepageIN);

        if (strTextWide)
        {
                strOut = WStr2MBStr(strTextWide, codepageOUT);
                free(strTextWide);
        }

        return strOut;
}


/*
 * Write out text to a file in UTF8 format.
 */
BOOL WriteUTF8File(LPCTSTR szFileName, LPCTSTR szText)
{
        HANDLE hFile;
        char*  szTextUTF8  = NULL;
        BOOL  bRet        = FALSE;
        DWORD  dwWritten;

        /* Open file. */
        hFile = CreateFile(szFileName, GENERIC_WRITE, FILE_SHARE_READ, NULL,
                          CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL);
        if (INVALID_HANDLE_VALUE == hFile) return FALSE;

        /* Convert text into UTF8. */
#ifdef UNICODE
        szTextUTF8 = WStr2MBStr(szText, CP_UTF8);
#else
        szTextUTF8 = MBStr2MBStr(szText, CP_ACP, CP_UTF8);
#endif

        /* Write UTF8 text to file. */
        if (NULL != szTextUTF8)
        {
                bRet = WriteFile(hFile, szTextUTF8, lstrlenA(szTextUTF8), &dwWritten, NULL);
        }

        /* Cleanup. */
        free(szTextUTF8);
        CloseHandle(hFile);
        return bRet;
}


/*
 * Read text from a file in UTF8 format. Returned text must be released with free().
 */
TCHAR* ReadUTF8File(LPCTSTR szFileName)
{
        HANDLE hFile;
        char*  szTextUTF8;
        DWORD  dwFileSize;
        DWORD  dwRead      = 0;
        TCHAR* szTextOut    = NULL;

        /* Open file. */
        hFile = CreateFile(szFileName, GENERIC_READ, FILE_SHARE_READ, NULL,
                          OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL);
        if (INVALID_HANDLE_VALUE == hFile) return NULL;

        /* Get file size. */
        dwFileSize = GetFileSize(hFile, NULL);
        if (INVALID_FILE_SIZE == dwFileSize)
        {
                CloseHandle(hFile);
                return NULL;
        }

        /* Allocate memory for buffer to read in UTF8 text. */
        szTextUTF8 = malloc(dwFileSize + 1);
        if (NULL == szTextUTF8)
        {
                CloseHandle(hFile);
                return NULL;
        }

        /* Read text in UTF8 format. */
        if (!ReadFile(hFile, szTextUTF8, dwFileSize, &dwRead, NULL))
        {
                free(szTextUTF8);
                CloseHandle(hFile);
                return NULL;
        }

        /* Terminate buffer. */
        szTextUTF8[dwRead] = '\0';

        /* Convert UTF8 text into TSTR. */
#ifdef UNICODE
        szTextOut = MBStr2WStr(szTextUTF8, CP_UTF8);
#else
        szTextOut = MBStr2MBStr(szTextUTF8, CP_UTF8, CP_ACP);
#endif

        /* Cleanup. */
        free(szTextUTF8);
        CloseHandle(hFile);
        return szTextOut;
}

---

theres a few undefined objects in that like

CP_UTF8
INVALID_FILE_SIZE

any idea why that is?

Because your header files are out of date. Just paste them in:

Code:

---

#define CP_UTF8                  65001      // UTF-8 translation
#define INVALID_FILE_SIZE ((DWORD)0xFFFFFFFF)

---

thanks you very much it works.and every one else who helped.much appreciated :)