Problem with constructor re-definition

Basicly I'm trying to translate Java's collections API ArrayList to a raw version in c++.

Code:

---

//ArrayList.h
#ifndef _ARRAYLIST_H_
#define _ARRAYLIST_H_

#include /*bla bla bla*/

#define ARRAYLIST_INITIALCAPACITY 128

class ArrayList: public Collection{
private:
        void *elements;
        unsigned int size;

public:
        ArrayList(int initialCapacity = ARRAYLIST_INITIALCAPACITY);
        ArrayList(Collection other);
        ~ArrayList();

        ArrayList& operator=(const ArrayList& arr);
        //methods here...
};
#endif //_ARRAYLIST_H_

//ArrayList.cpp
#include "ArrayList.h"

ArrayList::ArrayList(int initialCapacity){
        elements = new void[initialCapacity];
}
ArrayList::ArrayList(Collection other){}
ArrayList::~ArrayList(){
        //delete[] elements;
        //size=0;
}
ArrayList& ArrayList::operator=(const ArrayList& arr){}

//more stuff here

---

I'm getting these error with MSVC++ 6... I'm sick of trying to understand what's going on... Bah!!Please help

Code:

---

ArrayList.cpp(3) : error C2535: '__thiscall ArrayList::ArrayList(int)' : member function already defined or declared
        arraylist.h(19) : see declaration of 'ArrayList::ArrayList'
ArrayList.cpp(6) : error C2535: '__thiscall ArrayList::ArrayList(class Collection)' : member function already defined or declared
        arraylist.h(20) : see declaration of 'ArrayList::ArrayList'
ArrayList.cpp(7) : error C2535: '__thiscall ArrayList::
//same errors for operator= and ~ArrayList()
ArrayList.cpp(13) : fatal error C1004: unexpected end of file found
teste.cpp

---

Thanks in advance. ;)

Unexepected end of file and re-definition usually means an unmatched { somewhere. I beleve you also need to include an initalizer (int initialCapacity = ARRAYLIST_INITIALCAPACITY) in the defintion(the cpp file). Small constructors are frequenly just written inline, this will bloat compile time and sometimes exe size, but is usually a lot simpler.

You also cannot use new void[], there is no such thing as a void, you can have a pointer to void, "return" a void or "pass" a void, but these are all ways of saying either do nothing or, in the case of a pointer, have a raw machine address.

You also may be having a problem in that Container may not have a member named ArrayList.

Before you tackle pointers to void or arrays of pointers to void, I recomend you build your container out of the existing stl vector The most Javaish way is probably a vector of smart pointers to a common base type. You can also use a vector of pointers to objects decended from a type with a virtual clone() method, that will allow deep copying.

Thanks for the help, but your mixing on stuff I still haven't considered... the problem is that the compiler is, stupidly, assuming that I defined the same constructors and operator twice. Plus I have another class, in the same workspace that's written exactly the same way, and compiles well.
And the "int initialCapacity = ARRAYLIST_INITIALCAPACITY" isn't necessary in the cpp file.

This compiles well. The above class, that is wirtten the same way, doesn't!! :confused:

Code:

---

//GlutWindow.cpp
#include "GlutWindow.h"

GlutWindow::GlutWindow(char *_title) : title(_title){
        initState();
}
//GlutWindow.h
class GlutWindow{
private:
//stuff here
public:
        //contructores
        GlutWindow(char *_title = "");
//more stuff here
};

---

And I still don't know to use vectors... :o
//EDIT
I meant void*[]... that's a detail for later.

I solved it... incredible.. A single comma made all that noise!!! bah! thankx

Quote:

---

Originally Posted by xErath

I solved it... incredible.. A single comma made all that noise!!! bah! thankx

---

c/c++ compilers generally continue to try to compile, even though its obvious that the wheels have come off, it's kind of cute. Although, if the compiler could produce an "you forgot a comma here" error, you wouldn't need to include any commas :D .