access violation with delete

I am getting an access violation when I try to delete the temp object. It only get the error on the third iteration of the outermost loop. I don't understand why I am getting the error because the object is declared at the beginning of the loop and destroyed at the end. Any ideas where the problem could be? Another thing, the problem compiles and runs fine with g++ but not with borland c++.

Code:

---


HugeInt HugeInt::operator*( const HugeInt &op2 )
{
    HugeInt temp2;
    int carry = 0;
    int result = 0;
    int zeroCount = 0;

    for( int i = 29; i >= 0; i-- ){

      HugeInt *temp = new HugeInt;

      // Insert appropriate number of zeroes
      for( int a = zeroCount; a > 0; a-- ){
        (*temp).integer[30 - a] = 0;
      }

      for( int x = 29; x >= 0; x-- ){
        result = integer[x] * op2.integer[i];
        if( result > 10 ){
          (*temp).integer[x - zeroCount] = carry + ( result % 10 );
            carry = 1;
        }
        else {
          (*temp).integer[x - zeroCount] = carry + result;
          carry = 0;
        }
      }
      temp2 = temp2 + *temp;
      delete temp;
      zeroCount++;
    }
    return temp2;
}

---

You'll have to step through the execution of this function to see where the memory corruption is. Without something to play with, I try to stay away from guestimating memory bugs. ;)

What could be causing the memory corruption?

Quote:

---

Originally Posted by silk.odyssey

What could be causing the memory corruption?

---

Just in general? Writing past the end of an array will do it, and its an easy error when doing a lot of math to find an array index.

If you use your IDE's debugger, you should be able to step through your function line by line, which will show you where the problem is. That might point to a math error where an array index is off by 1 or some such.

On that subject, you might want to replace some of the numeric literals in your function with constants. I notice that you keep using 30 and 29, but by using a constant, you make it much more explicit when you need 30-1, and its simple offsets like that which screw me up when working with arrays.

The code writes past the beginning of the array but when I tried to correct it it didn't work but thats a problem still so I will rewrite the function.

Start small and work up. Create the function with the minimum possible features, then compile and debug. Gradually add code, compiling and debugging at each step. I guarantee it will save you time in the development process.

Post your code for this function:
HugeInt operator +( const HugeInt &op2 );