After two months of c++...

...and programming as a general, here is what I could come up with :).
This program is just something I created while learning windows, and I would like a feedback not on it´s code ( nothing but the most basics ), but on the way I commented it.
The way I see, my comments seen superficial, unusefull and describing nothing of importance. But at the same time that I tried to give more info, I noticed how hard it is to keep track of the comments if I change anything within the program, and ended up trying to keep them as local as possible.
I looked at some other people comments ( specially the contest ones ), but I know that perceiving own faults is a difficult task, and I would like to get in the habbit of doing things right while I'm still starting.

So, if you can spare some time to look at it, I'd really appreciate. If you wish to say anything about the code itself, go for it.

If you are going to run the code, I'm not done with the program and it still has a few issues. If you run an animation, you must press F4 to regain control of the application. Also, if you mouse click, the cursor disappears/appears.
By the way, I didn´t make any function const because I'm not so sure exactly where to put the const :confused:. Also, I'm aware there is some very ugly functions there, where I duplicated code a lot, but at the moment I am not sure how I will fix it.

I haven't compiled it but after a quick glance I don't see any corresponding delete[] for all those allocations with new[] which is not good.

I thought your commenting was generally very good. The only comment I noticed that served no purpose was:

Code:

---

    // Creates handle to a window, by succesfully creating a Window!

---

We know what CreateWindow does, how about telling us which window you are creating?

Other than that, don't be afraid of using vertical space. Code formatting like this should be avoided:

Code:

---

        if (  starLoc == NULL ){if ( SilenceVar.GetboxTest() == TRUE ) {  SilenceVar.SetboxTest(FALSE);MessageBox(NULL,TEXT("Not enough memory to run this application. The program will now terminate."),TEXT("Error."),MB_OK | MB_ICONWARNING );PostQuitMessage(0);}}

---

I can't comment on the actual code as I didn't look that closely.

Wow, impressive.

Very cool. Reminds me of the flashing letters in the Matrix.

As for your code, I think its pretty well-formatted although I do have one gripe. There are a few lines that are too long (one of them is >300 characters long. I suggest you try to keep all lines within 80 characters, as it reduces scrolling horizontally. It will also prove useful whenever you wish to print or publish your code on the internet. :)

Quote:

---

haven't compiled it but after a quick glance I don't see any corresponding delete[] for all those allocations with new[] which is not good.

---

I tried to delete them just before a quit message, but I got some errors. I wasn´t sure if I needed to delete them anyway, as you can see below, since the program was exiting. I'll fix that.

Code:

---

if ( quit == IDYES )
                        {
                        KillTimer(hwnd,1);
                        //delete [] animePos;
                        //delete [] starDist; Do I need to delete?
                        //delete [] starLoc; 
                        PostQuitMessage (0);
                        }

---

Annoytmouse, that comment about the window was there because I used to remind me of things while studying. I didn´t comment anything important on WinMain because I thought it wasn´t necessary, and after a while I simply forgot it was there :rolleyes:.

Quote:

---

Other than that, don't be afraid of using vertical space.

---

Quote:

---

There are a few lines that are too long

---

And thanks for the tip :). I was trying to "hide" the more superfulous code, but I guess that did look ugly.
Thanks everyone for giving me some feedback.