Reseting root

Hi,
I'm taking words from an unknown amount of documents and adding them to a tree. I have a problem in my insert function, though, and it keeps reseting root everytime a new word needs to be added to the tree. Maybe it's because I've been staring at it too long, but I don't see why once the root gets the first word it doesn't iterate down the tree. I put in print statements to see where it gets to, but it never enters the else statement.
Can anyone point it out to me?

Here's the function:

Code:

---

wordnode_t *insert_node(wordnode_t *root, wordnode_t *nodeptr, wordnode_t *current)
{

if(root==NULL)
    {
      printf("if i stop here, root not made\n");
      root=nodeptr;

        printf("making root in theory. Root is %s, %d\n", root->string, root->counter);
          root->right=NULL;
        root->left=NULL;
    }
  else
    {
      printf("else statement\n");
      current=root;
while(current!=NULL)
        {

      if (strcmp(nodeptr->string, current->string) == 0)
        {
          printf("were in equal to\n");
          nodeptr->counter ++;
              }

        else {
          if(strcmp(nodeptr->string, current->string)>0)
            { printf("were in greater than\n");
              nodeptr->counter++;
        current=current->right;
        }

        if(strcmp(nodeptr->string, current->string)<0)
          {
            printf("were in less than\n");
        nodeptr->counter++;
      current=current->left;
      }
        }
    }
      }
}

---

Any clues appreciated, thanks!

How are you calling the fuction?

I'm calling it within a switch statement- where as long as words are coming in, this is implemented.

Code:

---

switch (num)
      {
      case WORD: printf("WORD worked\n"); //instead of case 1, just preference.
          nodeptr=createnode(); //malloc space for the node
          strcpy(nodeptr->string, newword); //copy stuff into node
        insert_node(root, nodeptr, current); //calling the function
        break;
      default:
            printf("default case\n");
        break;
      }
    }

---

Um...you don't put the new node in the tree when you find a place. Try this:

Code:

---

wordnode_t *insert_node(wordnode_t *root, wordnode_t *nodeptr)
{
  if(root==NULL)
  {
    printf("if i stop here, root not made\n");
    root=nodeptr;
    printf("making root in theory. Root is %s\n", root->string);
    root->right=NULL;
    root->left=NULL;
  }
  else
  {
    wordnode_t *current=root;
    wordnode_t **save = &root;
    while(current!=NULL)
    {
      if (strcmp(nodeptr->string, current->string) == 0)
      {
        printf("were in equal to\n");
      }
      else {
        if(strcmp(nodeptr->string, current->string)>0)
        {
          printf("were in greater than\n");
          save = & current->right;
          current=current->right;
        }
        else if(strcmp(nodeptr->string, current->string)<0)
        {
          printf("were in less than\n");
          save = & current->left;
          current=current->left;
        }
      }
    }
    *save = nodeptr;
    nodeptr->left = NULL;
    nodeptr->right = NULL;
  }
  return root;
}

---

Thanks, but it's still reseting root to be the new word each time, unfortunately. It never gets to the else statement even using this.

>but it's still reseting root to be the new word each time
Because you're not calling the function properly. For the function to make changes to the root in main you must either save the return value (as in the code I gave you) or accept a pointer to a pointer as an argument. Here is some test code for you to play around with. Notice how the insert_node function is called:

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

typedef struct n {
  char string[100];
  struct n *left, *right;
} wordnode_t;

wordnode_t *insert_node(wordnode_t *root, wordnode_t *nodeptr)
{
  if(root==NULL)
  {
    printf("if i stop here, root not made\n");
    root=nodeptr;
    printf("making root in theory. Root is %s\n", root->string);
    root->right=NULL;
    root->left=NULL;
  }
  else
  {
    wordnode_t *current=root;
    wordnode_t **save = &root;
    while(current!=NULL)
    {
      if (strcmp(nodeptr->string, current->string) == 0)
      {
        printf("were in equal to\n");
      }
      else {
        if(strcmp(nodeptr->string, current->string)>0)
        {
          printf("were in greater than\n");
          save = & current->right;
          current=current->right;
        }
        else if(strcmp(nodeptr->string, current->string)<0)
        {
          printf("were in less than\n");
          save = & current->left;
          current=current->left;
        }
      }
    }
    *save = nodeptr;
    nodeptr->left = NULL;
    nodeptr->right = NULL;
  }
  return root;
}

void print_node ( char *value, int level )
{
  int i;

  for ( i = 0; i < level; i++ )
    printf ( "\t" );
  printf ( "%s\n", value );
}

void print_tree_structure ( struct n *node, int level )
{
  if ( node == NULL )
    print_node ( "~", level );
  else {
    print_tree_structure ( node->right, level + 1 );
    print_node ( node->string, level );
    print_tree_structure ( node->left, level + 1 );
  }
}

int main ( void )
{
  wordnode_t *root = NULL;
  wordnode_t *word;
  char buff[BUFSIZ];

  while ( fgets ( buff, sizeof buff, stdin ) != NULL ) {
    word = malloc ( sizeof *word );
    strcpy ( word->string, buff );
    root = insert_node ( root, word );
    print_tree_structure ( root, 0 );
    printf ( "\n--------------------\n" );
  }
}

---

What was the current parameter for btw? I saw no real use for it so I removed it in my example.

Quote:

---

root = insert_node ( root, word );

---

Thanks! That's why it kept reseting. As to current, I want to do it as following. I have a new node, if there is no root, that new node is now root. If there is a root, I set current equal to it and compare the newnode to current. Depending if newnode is greater than current, I set the current to equal the right branch of where it currently is. If that makes sense. Current is just so I can iterate down the tree, and as long as it doesn't point to null, it iterates.
I'm going to play around with this code in my comparison functions now. Thanks for your help!

>Current is just so I can iterate down the tree, and as long as it doesn't point to null, it iterates.
There's no point in making it a function parameter though. You make it a local variable in insert_node and save your self the hassle of dealing with another variable in main (like in the example I gave you :)).