lvale problem in function definition/

Code:

---

#include<iostream>
#include<conio.h>

void perfect(int);  // function prototype

using std::cout;
using std::cin;
using std::endl;

int main()
{
    int num;    // declare varibale
   
    cout<< "Enter an integer:\t";  // prompt the user for input
    cin>> num;  // read num
   
    perfect(num);

getch();
}

// definition perfect()

void perfect(int userChoice)
{
    int sum,rem;
   
    for(int value=1;value<=userChoice;value++)
   
    rem=userChoice/value;
    sum+=value;
    int result=1+sum;
   
    if((userChoice/value)==0 && result=userChoice)
        cout<< "perfect";
    else
        cout<< "not perfect";
}

---

4 erors in this program. It is supposed to tell wether a number is perfect number or not.

Quote:

---

int sum,rem;

for(int value=1;value<=userChoice;value++)

rem=userChoice/value;
sum+=value;
int result=1+sum;

if((userChoice/value)==0 && result=userChoice)
cout<< "perfect";
else
cout<< "not perfect";

---

The user inputs 'userChoice'. userChoice is divided by the 'value'. After that it sums up all the value and if result is equal to the num it couts' perfect, yet some logical errors in the program.

Code:

---

if((userChoice/value)==0 && result=userChoice)

---

I think u meant...

Code:

---

if((userChoice/value)==0 && result==userChoice)

---

okeys it reduces to 3 errors if i do so but the compiler gives this error now
:...:' in function void perfect(int).

&

:39: name
lookup of `value' changed for new ISO `for' scoping

Quote:

---

sum+=value;

---

compiler highlights the above.

only other real problem i can see is sum is uninitialised at first use and you ought to return 0 at end of main out of courtesy especially as not all compilers may support the implicit return 0. Oh and sorry this should have been correct line...

Code:

---

if(userChoice/value==0 && result==userChoice)

---

Ofcourse '==' is 100% right. I am using a DEV-C++ compiler and it gives 3 errors for the following code;

Code:

---

#include<iostream>
#include<conio.h>

void perfect(int);  // function prototype

using std::cout;
using std::cin;
using std::endl;

int main()
{
    int num;    // declare varibale
   
    cout<< "Enter an integer:\t";  // prompt the user for input
    cin>> num;  // read num
   
    perfect(num);

getch();
}

// definition perfect()

void perfect(int userChoice)
{
    int sum,rem;
   
    for(int value=1;value<=userChoice;value++)
   
    rem=userChoice/value;
    sum+=value;
    int result=1+sum;
   
    if((userChoice/value)==0 && result==userChoice){
        cout<< "perfect";}
    else
        cout<< "not perfect";
}

---

Do you need brackets for you for loop?

or is it only supposed to loop next line?

brackets?

whats the logic behind brackets??

your for loop will only loop through the following statement without brackets

Code:

---

for ()
statement;

so you need brackets
for ()
{
 statement1;
 statement2;
}

this will loop the two statements instead of just the first

---

okeys thanku. I'll keep that in mind.