Class array for easy loading of 3400 mechs

Im making a database of mechs for my game series MOTW.

Heres what i have:

Code:

---

class Mech
{
 private:
        string name;
        string weapon;
        string armor;
        string first_seen;
        string info;
        int hp;
        int def;
        int dam;
        int lvl;
 public:
        void setinfo(char * f);
        void outinfo();
};

void Mech::setinfo(char * f)
{
 ifstream fin(f);
 getline(fin, name, '*');
 getline(fin, weapon, '*');
 getline(fin, armor, '*');
 getline(fin, first_seen, '*');
 getline(fin, info, '*');
 fin >> hp >> def >> dam >> lvl;
}

void Mech::outinfo()
{
 cout << "Name: " << name << endl;
 cout << "Armor: " << armor << "\nDef: " << def << endl;
 cout << "Weapon: " << weapon << "\nMax Dam: " << dam << endl;
 cout << "Avg LVL: " << lvl << "\nFirst seen in: " << first_seen << endl;
 cout << "Desc:\n";
 cout << info << endl;
}


int main(int argc, char *argv[])
{
  Mech mechs[3];
  for(int i = 0; i < 3; i++)
  {
  char * file;
  sprintf(file,"%d.mch", i);
  mechs[i].setinfo(file);
  }
  for (int i = 0; i < 3; i++)
  {
  mechs[i].outinfo();
  getche();
  }
}

---

This crashes when i try it. The entire database will have more than 5000 objects, and i dont wanna do Mech mech1; mech1.setinfo(1-3400.mch); etc

Can i do that in a way that i am trying to do it? or do i have to do manual loading of each one?

That's because you are using an uninitialized pointer here:

Code:

---

char * file;
sprintf(file,"%d.mch", i);
mechs[i].setinfo(file);

---

You need to either just make an array like char file[256] or allocate memory for that pointer and make sure to free it somewhere.

so something like:

Code:

---

for (int i = 0; i < 3; i++)
{
 char  file[256];
 sprintf(file, "%d.mch", i);
 mechs[i].setinfo(file);
 delete file;
}

---

I don't do much pointer handling outside of *

Code:

---

char  file[256];
delete file; //bad!

---

Never "delete" arrays. If you declare it as char file[256], it will automatically deallocate. IF it's char* file = new char[256], then you go delete[] file;

Have fun :)

I got it. Thanks guys.