whats wrong with this?

Hey everyone, spot the newbie :D

I know this is probably really simple to you lot but I need a bit of help with some coursework

basically I've got a simple switch which initalises the first part of the code:

Code:

---

case 1:
      printf ("1. Deposit funds \n");
      balance = deposited (deposit);
      break;

---

after this i have a simple error check to make sure the data is within range:

Code:

---

float deposited (float balance)
{
float deposit;
float bal = (balance);
printf ("Please enter how much you wish to deposit \n");
scanf ("%f", &deposit);

      if ((deposit + balance < 999999) && (deposit + balance > 0))
      {
      printf ("Thank you %f has being entered into your account \n", deposit);
      }

      if ((deposit + balance > 999999) && (deposit + balance < 0))
      {
      printf ("I'm sorry but the number you have entered is either too large or too small/n");
      }
      balance = deposit + balance;

return balance;
}

---

Now when this code comes back into the main part of the program the balance, i was wondering why this is and whats going to be the best way to fix it?

Apologies for the shoddily written code but I'm new to this.

Thanks for your help

>Hey everyone, spot the newbie
Too easy. Newbies always announce themselves as such for some strange reason. Probably a lack of confidence. We honestly don't care what your experience is as long as you don't act like a loser.

Quote:

---

when this code comes back into the main part of the program the balance I imagine your description of the problem was supposed to go here, i was wondering why this is and whats going to be the best way to fix it?

---

>balance = deposited (deposit);
Deposit implies the amount to be added, not the current balance as the deposited function implies. This alone seems suspect.

>scanf ("%f", &deposit);
You should always check interactive input for success.

>balance = deposit + balance;
You change balance even when the value is out of range. Not good for keeping your promises.

>float bal = (balance);
Parentheses really aren't needed, but what is the point of the bal variable?

heh, yea you got me,

I've changed the code slightly since i posted this so:

The call:

Code:

---

case 1:
      printf ("1. Deposit funds \n");
      balance = deposited (balance, new_balance);
      break;

---

The actual function:

Code:

---


float deposited (float balance, float new_balance)
{
float deposit;
printf ("Please enter how much you wish to deposit \n");
scanf ("%f", &deposit);

      if ((deposit + balance < 999999) && (deposit + balance > 0))
      {

      new_balance = deposit + balance;
      printf ("Thank you %f has being entered into your account \n", deposit);
      printf ("Your current balance wibble = %f \n", &new_balance);
      }

      if ((deposit + balance > 999999) && (deposit + balance < 0))
      {
      printf ("I'm sorry but the number you have entered is either too large or too small/n");
      }

return (new_balance);
}

---

The problem is that it won't pass the result back into the main function meaning i can't use the value any further than the function, i need to pass the new_balance back.

Your code is still a little goofy. Without the use of pointers to modify your passed argument, it would be better simply to pass the balance, make the modifications, then return the modified balance and save the return of deposited to balance. Something more like this:

Code:

---

float deposited (float balance)
{
  float deposit;

  printf ("Please enter how much you wish to deposit \n");
  scanf ("%f", &deposit);
  if ((deposit + balance < 999999) && (deposit + balance > 0))
  {
    balance = balance + deposit;
    printf ("Thank you %.2f has been entered into your account\n", deposit);
    printf ("Your current balance wibble = %.2f\n", balance);
  }
  else
    printf ("I'm sorry but the number you have entered out of range/n");
 
  return (balance);
}

---

And you would call it like so:

Code:

---

balance = deposited (balance);

---

Now you can update balance if the deposit is within range, or refrain from updating balance otherwise with the same call to deposited. Which I imagine is what you wanted in the first place.

>> if ((deposit + balance > 999999) && (deposit + balance < 0))
Can't have a number less than 0 and greater than 999999.

Or just use a simple "else" as Prelude posted.

gg

Thanks for that but for some reason it just doesn't want to call the new balance up when i use a printf in the main function

Code:

---

case 3:
      printf ("3.  Show balance \n");
      printf ("Your current balance = %f \n", &balance);
      break;

---

still returns a value of 0, the value just doesn't seem to get passed into the main function

this is really starting to do my nut in now :confused:

>printf ("Your current balance = %f \n", &balance);
You don't use the address operator when printing values. A type mismatch results in undefined behavior, but your compiler seems to prefer printing 0. Change the print to:

Code:

---

printf ("Your current balance = %f \n", balance);

---

and see what happens.

omg, thanks thats what has being driving me mental for about 4 hours, i can't belive it was that obvious. Thanks fella!

Wierdess ever error, new part of the code

the call:

Code:

---

printf ("3.  Show balance \n");
      printf ("Your current balance = %.2f \n", balance);
      break;

---

the function:

Code:

---

float withdrawn (float balance)
{
float withdraw = 0 ;
int transtype;

printf ("Please enter how you wish to withdraw \n");
printf ("1.  Cash \n");
printf ("2.  Cheque\n");
scanf ("%d", &transtype);

if (transtype = 2)
  {
  printf ("Please enter how a value up to a maximum of 500 \n");
  scanf ("%f", &withdraw);
        if (withdraw > 500)

          printf ("You are limited to a maximum of 500 \n");

        else

        {
          printf ("%.2f has being withdrawn from your account \n", withdraw);
          balance = balance - withdraw;
        }
  }
return (balance);
}

---

I know this is really cheeky but does anyone know why i will always get an answer of 45 when i try to withdraw anything, there seems to be logical reason for it :confused:

If you would like it I've uploaded the code i have so far http://petedeeuk.8bit.co.uk/code.html

>if (transtype = 2)
You compare two values with ==, you assign a value with =. This is a sneaky error, so you have to watch out for it.

>does anyone know why i will always get an answer of 45 when i try to withdraw anything
I don't have this problem, your code seems to work correctly. Can you give us a detailed session that causes the problem as well as what compiler you use?

Turn up the warning level on your compiler.

Code:

---

#include <stdio.h>

float deposited (float);
float withdawn (float);
/* [Info 752] local declarator 'withdawn(float)' not referenced */

int main()
{
  int menu_choice = 0;
  float deposit = 0;
  float withdraw = 0;
  int transactions;
  float balance, new_balance;

  while ( menu_choice != 4 )
  {
      printf ("Your current balance = %.2f \n", balance);
/* [Warning 530] Symbol 'balance' not initialized */
      printf ("1.  Deposit funds \n");
      printf ("2.  Withdraw funds \n");
      printf ("3.  Show balance \n");
      printf ("4.  Quit Program \n");
      printf ("Please select what you wish to do (1-4): \n");
      scanf ("%d", &menu_choice);

      switch ( menu_choice )
      {
      case 1:
        printf ("1. Deposit funds \n");
        balance = deposited (balance);
        transactions ++;
/* [Warning 530] Symbol 'transactions' not initialized */
        break;

      case 2:
        printf ("2. Withdraw funds \n");
        balance = withdrawn (balance);
/* [Info 718] Symbol 'withdrawn' undeclared, assumed to return int */
/* [Info 746] call to function 'withdrawn()' not made in the presence of a prototype */
        break;

      case 3:
        printf ("3.  Show balance \n");
        printf ("Your current balance = %.2f \n", balance);
        break;

      case 4:
        printf ("Exiting... \n");
        break;

      default:
        printf("Please Enter a Choice from 1-4\n" );
        break;
      }

  }

  return 0;
/* [Warning 550] Symbol 'transactions' not accessed */
/* [Warning 529] Symbol 'deposit' not subsequently referenced */
/* [Warning 529] Symbol 'new_balance' not subsequently referenced */
/* [Warning 529] Symbol 'withdraw' not subsequently referenced */
}

float deposited (float balance)
{
  float deposit;

  printf ("Please enter how much you wish to deposit \n");
  scanf ("%f", &deposit);
  if ( (deposit + balance < 999999) || (deposit + balance > 0) )
  {
      balance = balance + deposit;
      printf ("Thank you %.2f has been entered into your account\n", deposit);
  }
  else
      printf ("I'm sorry but the number you have entered out of range/n");

  return(balance);
}

float withdrawn (float balance)
/* [Error 18] Symbol 'withdrawn()' redeclared (basic, Arg. no. 1: promotion) conflicts with line 37 */
/* [Warning 516] 'Symbol withdrawn(float)' has arg. type conflict (arg. no. 1 -- float vs. double) with line 37 */
{
  float withdraw = 0 ;
  int transtype;

  printf ("Please enter how you wish to withdraw \n");
  printf ("1.  Cash \n");
  printf ("2.  Cheque\n");
  scanf ("%d", &transtype);

  if ( transtype = 2 )
/* [Info 720] Boolean test of assignment */
/* [Warning 506] Constant value Boolean */
/* [Info 774] Boolean within 'if' always evaluates to True */
  {
      printf ("Please enter how a value up to a maximum of 500 \n");
      scanf ("%f", &withdraw);
      if ( withdraw > 500 )

        printf ("You are limited to a maximum of 500 \n");

      else

      {
        printf ("%.2f has being withdrawn from your account \n", withdraw);
        balance = balance - withdraw;
      }
  }
  return(balance);
}

---

Damn thats alot of errors :eek:

I've uploaded the code again, (check the same link) its being compiled with Dev C++

Code:

---

float withdrawn (float balance)
{
float cashwithdraw, chequewithdraw;
int transtype;

printf ("Please enter how you wish to withdraw \n");
printf ("1.  Cash \n");
printf ("2.  Cheque\n");
scanf ("%d", &transtype);

switch (transtype)
    {
            case 1:
            {
            printf ("How much would you like to withdraw?  \n");
            scanf ("%f", &cashwithdraw);
            balance = balance - cashwithdraw;
            printf ("%.2f has being withdrawn from your account \n", cashwithdraw);
            break;
            }

            case 2:
            {
            printf ("How much would you like to withdraw? (maximum of 500) \n");
            scanf ("%f", &chequewithdraw);

            if (chequewithdraw > 500)
            printf ("You are limited to a maximum of 500 \n");
            else if (chequewithdraw < 0)
            printf ("Please enter a positive number \n");
            else
            {
            printf ("%.2f has being withdrawn from your account \n", chequewithdraw);
            balance = balance - chequewithdraw;
            }
            break;

            default:
            printf("Please Enter a Choice from either 1 or 2\n" );
            break;

            }
    }



return (balance);
}

---

New last section, replaced if's with a switch, however still known errors:

When you withdraw money with cash or if you draw anything (cash or cheque) out twice the new balance is always 45, its an odd little error

>Damn thats alot of errors
Yet you haven't bothered to fix any of them.

>float balance, new_balance;
balance needs to have a value, 0 would be a good starting point.

>int transactions;
Ditto

>float withdawn (float);
This must be changed to

Code:

---

float withdrawn (float);

---

The reason i didn't fix any of them was that i only just got the post and haven't got round to doing it yet, gimme chance fella and

Code:

---

float withdrawn (float);

---

^^ isn't that what i put?

>fella
:p

[edit]

Code:

---

float withdawn (float);
float withdrawn (float balance)

---

[/edit]

>its being compiled with Dev C++

You may want to add -Wall -ansi -pedantic to your compiler options.

this is all very well and good but does anyone know why its stuck on 45 or 44? Unless its just me, in which case tell me if everything is working fine

>i only just got the post and haven't got round to doing it yet
Well, when you get around to doing it you can feel free to ask for more help. We don't like endless threads trying to get someone to fix an obvious error.

>isn't that what i put?
No, what you actually put was what I quoted.

>this is all very well and good but does anyone know why its stuck on 45 or 44?
Did you fix all of the errors and warnings? Because once I do that your code works just peachy in Dev-C++.

um, i've fixed all those problems (i think) but its still not doing what i want, whenever i try to withdraw cash or cheques the answer always comes out to 45.00, why!?!?


the code has being uploaded (again)
http://petedeeuk.8bit.co.uk/wtf.jpg

oh and why do windows close when the code is finished and how do i stop it?

FAQ

>why!?!?
I can't help you with a problem I can't reproduce.

>the code has being uploaded (again)
Here is the code I have been using that works properly on both Dev-C++ and VC++. Does it match yours?

Code:

---

#include <stdio.h>

float deposited (float);
float withdrawn (float);

int main()
{
  int menu_choice = 0;
  int transactions = 0;
  float balance = 0;
 
  while (menu_choice != 4)
  {
    printf ("Your current balance = %.2f \n", balance);
    printf ("1.  Deposit funds \n");
    printf ("2.  Withdraw funds \n");
    printf ("3.  Show balance \n");
    printf ("4.  Quit Program \n");
    printf ("Please select what you wish to do (1-4): \n");
    scanf ("%d", &menu_choice);
    switch (menu_choice)
    {
    case 1:
      printf ("1. Deposit funds \n");
      balance = deposited (balance);
      transactions ++;
      break;
    case 2:
      printf ("2. Withdraw funds \n");
      balance = withdrawn (balance);
      break;
    case 3:
      printf ("3.  Show balance \n");
      printf ("Your current balance = %.2f \n", balance);
      break;
    case 4:
      printf ("Exiting... \n");
      break;
    default:
      printf("Please Enter a Choice from 1-4\n" );
      break;
    }
  }
 
  return 0;
}

float deposited (float balance)
{
  float deposit;
 
  printf ("Please enter how much you wish to deposit \n");
  scanf ("%f", &deposit);
  if ((deposit + balance < 999999) || (deposit + balance > 0))
  {
    balance = balance + deposit;
    printf ("Thank you %.2f has been entered into your account\n", deposit);
  }
  else
    printf ("I'm sorry but the number you have entered out of range/n");
 
  return (balance);
}

float withdrawn (float balance)
{
  float cashwithdraw, chequewithdraw;
  int transtype;
 
  printf ("Please enter how you wish to withdraw \n");
  printf ("1.  Cash \n");
  printf ("2.  Cheque\n");
  scanf ("%d", &transtype);
  switch (transtype)
  {
  case 1:
    printf ("How much would you like to withdraw?  \n");
    scanf ("%f", &cashwithdraw);
    balance = balance - cashwithdraw;
    printf ("%.2f has being withdrawn from your account \n", cashwithdraw);
    break;
  case 2:
    printf ("How much would you like to withdraw? (maximum of 500) \n");
    scanf ("%f", &chequewithdraw);
    if (chequewithdraw > 500)
      printf ("You are limited to a maximum of 500 \n");
    else if (chequewithdraw < 0)
      printf ("Please enter a positive number \n");
    else
    {
      printf ("%.2f has being withdrawn from your account \n", chequewithdraw);
      balance = balance - chequewithdraw;
    }
    break;
  default:
    printf("Please Enter a Choice from either 1 or 2\n" );
    break;
  }
 
  return (balance);
}

---

Okay, here is the code that i am using completed thus far, this is as up-to-date as i have:

Code:

---

#include <stdio.h>

float deposited (float);
float withdawn (float);

int main()
{

int menu_choice = 0;
float deposit = 0;
float withdraw = 0;
int transactions = 0;
float balance = 0;
float nodeposits = 0;
float total_deposited = 0;
float wibble;

while (menu_choice != 4)

{
printf ("Your current balance = %.2f \n", balance);
printf ("1.  Deposit funds \n");
printf ("2.  Withdraw funds \n");
printf ("3.  Show balance \n");
printf ("4.  Quit Program \n");
printf ("Please select what you wish to do (1-4): \n");
scanf ("%d", &menu_choice);

switch (menu_choice)
      {
      case 1:
      printf ("1. Deposit funds \n");
      balance = deposited (balance);
      transactions ++;
      break;

      case 2:
      printf ("2. Withdraw funds \n");
      balance = withdrawn (balance, &total_deposited);
      nodeposits ++;
      break;

      case 3:
      printf ("3.  Show balance \n");
      printf ("Your current balance = %.2f \n", balance);
      break;

      case 4:
      printf ("Exiting... \n");
      printf ("closing balance.............%.2f \n", balance);
      printf ("completed transactions......%.2f \n", transactions);
      printf (" /n");
      printf ("completed deposits..........%.2f \n", nodeposits);
      break;

      default:
      printf("Please Enter a Choice from 1-4\n" );
      break;
      }

}


return 0;

}


float deposited (float balance)
{
  float deposit = 0;
  printf ("Please enter how much you wish to deposit \n");
  scanf ("%f", &deposit);
  if ((deposit + balance < 999999) || (deposit + balance > 0))
  {
    balance = balance + deposit;
    printf ("Thank you %.2f has been entered into your account\n", deposit);
  }
  else
    printf ("I'm sorry but the number you have entered out of range/n");
 
  return (balance);
}





float withdrawn (float balance)
{
float cashwithdraw = 0, chequewithdraw = 0;
int transtype;

printf ("Please enter how you wish to withdraw \n");
printf ("1.  Cash \n");
printf ("2.  Cheque\n");
scanf ("%d", &transtype);

switch (transtype)
    {
            case 1:
            {
            printf ("How much would you like to withdraw?  \n");
            scanf ("%f", &cashwithdraw);
            balance = balance - cashwithdraw;
            printf ("%.2f has being withdrawn from your account \n", cashwithdraw);
            break;
            }

            case 2:
            {
            printf ("How much would you like to withdraw? (maximum of 500) \n");
            scanf ("%f", &chequewithdraw);


            if ((chequewithdraw > 500) || (chequewithdraw < 0))
            printf ("You are limited to a maximum of 500 \n");

            {
            printf ("%.2f has being withdrawn from your account \n", chequewithdraw);
            balance = balance - chequewithdraw;
            }
            break;

            default:
            printf("Please Enter a Choice from either 1 or 2\n" );
            break;

            }
    }



return (balance);
}

---

The bug is:

Start the program
Select option 1. deposit funds
Enter an amount
Select option 2. withdraw funds
select option 1. cash
imput a number

The screen will display: "your current balance is 45.00" regardless of how much you put in or take out

please tell me this is just my computer going funny

>please tell me this is just my computer going funny
No, it's you ignoring our help. I get three warnings with Dev-C++ and the code you gave in your most recent post, they all had to do with the fact that your prototype doesn't match the definition; a problem we informed you of in every reply since the beginning of this thread I might add. You also call it with one too many arguements.

There's sound you'll hear often when you ignore people's help, let me give you a sample.

*plonk*

Honest to god, I'm really not ignoring your help, I'm really trying to see what is wrong with my code,

You are saying there are errors with the prototype and the definition:

prototype:

Code:

---

float deposited (float);
float withdrawn (float);

---

definition:

Code:

---

float withdrawn (float balance)

---

I'm not being ignorant but i just don't see any problems with them unless I'm understanding somthing wrongly. I am honestly not ignoring your help, I just don't understand what you mean.

Quote:

---

I get three warnings with Dev-C++

---

I don't get any, i've unticked everything in the C/C++ compiler options tab in the compiler options.

Check your spelling in the post containing the code:
>>float withdawn (float);

Then you call withdrawn like this:
>>balance = withdrawn (balance, &total_deposited);
That has two parameters, but the function only takes one.

Yea, but thats an old piece of code that has being fixed in the new posts, the quotes in my latest post are what is in the code now and it still doesn't want to work

So paste the latest code, directly from your editor, along with any compiler error/warning messages and a description of what's wrong.

just for you:

Code:

---

#include <stdio.h>

float deposited (float);
float withdawn (float);

int main()
{

int menu_choice = 0;
float deposit = 0;
float withdraw = 0;
int transactions = 0;
float balance = 0;
float nodeposits = 0;
float total_deposited = 0;
float wibble;

while (menu_choice != 4)

{
printf ("Your current balance = %.2f \n", balance);
printf ("1.  Deposit funds \n");
printf ("2.  Withdraw funds \n");
printf ("3.  Show balance \n");
printf ("4.  Quit Program \n");
printf ("Please select what you wish to do (1-4): \n");
scanf ("%d", &menu_choice);

switch (menu_choice)
      {
      case 1:
      printf ("1. Deposit funds \n");
      balance = deposited (balance);
      transactions ++;
      break;

      case 2:
      printf ("2. Withdraw funds \n");
      balance = withdrawn (balance, &total_deposited);
      nodeposits ++;
      break;

      case 3:
      printf ("3.  Show balance \n");
      printf ("Your current balance = %.2f \n", balance);
      break;

      case 4:
      printf ("Exiting... \n");
      printf ("closing balance.............%.2f \n", balance);
      printf ("completed transactions......%.2f \n", transactions);
      printf (" /n");
      printf ("completed deposits..........%.2f \n", nodeposits);
      break;

      default:
      printf("Please Enter a Choice from 1-4\n" );
      break;
      }

}


return 0;

}


float deposited (float balance)
{
  float deposit = 0;
  printf ("Please enter how much you wish to deposit \n");
  scanf ("%f", &deposit);
  if ((deposit + balance < 999999) || (deposit + balance > 0))
  {
    balance = balance + deposit;
    printf ("Thank you %.2f has been entered into your account\n", deposit);
  }
  else
    printf ("I'm sorry but the number you have entered out of range/n");
 
  return (balance);
}





float withdrawn (float balance)
{
float cashwithdraw = 0, chequewithdraw = 0;
int transtype;

printf ("Please enter how you wish to withdraw \n");
printf ("1.  Cash \n");
printf ("2.  Cheque\n");
scanf ("%d", &transtype);

switch (transtype)
    {
            case 1:
            {
            printf ("How much would you like to withdraw?  \n");
            scanf ("%f", &cashwithdraw);
            balance = balance - cashwithdraw;
            printf ("%.2f has being withdrawn from your account \n", cashwithdraw);
            break;
            }

            case 2:
            {
            printf ("How much would you like to withdraw? (maximum of 500) \n");
            scanf ("%f", &chequewithdraw);


            if ((chequewithdraw > 500) || (chequewithdraw < 0))
            printf ("You are limited to a maximum of 500 \n");

            {
            printf ("%.2f has being withdrawn from your account \n", chequewithdraw);
            balance = balance - chequewithdraw;
            }
            break;

            default:
            printf("Please Enter a Choice from either 1 or 2\n" );
            break;

            }
    }



return (balance);
}

---

That STILL has the spelling mistake in it. It's on the third line of code, you can't miss it :p

It also has the other errors I mentioned.

You didn't even post the compiler messages or give an explanation of what's wrong, like I asked you to. If you want help, you have to play the game..

:eek: oh dear god, i honestly cannot belive i missed that!! If someone had just said line 3 of the code i would of found it, thank you, i really feel daft now :p

Anyway, i would have assumed you would seen the

Quote:

---

The bug is:

Start the program
Select option 1. deposit funds
Enter an amount
Select option 2. withdraw funds
select option 1. cash
imput a number

The screen will display: "your current balance is 45.00" regardless of how much you put in or take out

---

thing i said above, but with all the code on this page its easy to miss.

I can't belive how thick i am, you guys must think I'm a right dumbass and i completely agree with you.

I guess with this sorted then everything is fixed, there is one last thing that i need to do (count the amount deposited) but i should be able to do that on my own.


i hope.

Quote:

---

Originally posted by petedee

Code:

---

#include <stdio.h>

float deposited (float balance)
{
  float deposit = 0;
  printf ("Please enter how much you wish to deposit \n");
  scanf ("%f", &deposit);
  if ((deposit + balance < 999999) || (deposit + balance > 0))
  {
    balance = balance + deposit;
    printf ("Thank you %.2f has been entered into your account\n", deposit);
  }
  else
    printf ("I'm sorry but the number you have entered out of range/n");
 
  return (balance);
}

---

---

Lessee here.

If deposit + balance = 200, then
if ((200 < 999999) || (200 > 0))
Both comparisons are true, statement is true

If deposit + balance = -200, then
if ((-200 < 999999) || (200 > 0))
First comparison is true, therefore the statement is true

If deposit + balance = 2000000, then
if ((2000000 < 999999) || (2000000 > 0))
Second comparison is true, therefore the statement is true

When is it false?

Quote:

---

Originally posted by petedee

Code:

---

float withdrawn (float balance)
{
float cashwithdraw = 0, chequewithdraw = 0;
int transtype;

printf ("Please enter how you wish to withdraw \n");
printf ("1.  Cash \n");
printf ("2.  Cheque\n");
scanf ("%d", &transtype);

switch (transtype)
    {
            case 1:
            {
            printf ("How much would you like to withdraw?  \n");
            scanf ("%f", &cashwithdraw);
            balance = balance - cashwithdraw;
            printf ("%.2f has being withdrawn from your account \n", cashwithdraw);
is this print statement the one that claims 45.00?
            break;
            }

            case 2:
            {
            printf ("How much would you like to withdraw? (maximum of 500) \n");
            scanf ("%f", &chequewithdraw);


            if ((chequewithdraw > 500) || (chequewithdraw < 0))
            printf ("You are limited to a maximum of 500 \n");

            {
            printf ("%.2f has being withdrawn from your account \n", chequewithdraw);
            balance = balance - chequewithdraw;
            }
            break;

            default:
            printf("Please Enter a Choice from either 1 or 2\n" );
            break;
            }
    }
return (balance);
}

---

---

Has anyone mentioned the danger of using scanf()? Search the board for reasons why scanf() is not a good function to use and for alternatives. I'll bet you're not reading the stream correctly.
Also see this link

I've heard scanf is a bad one to use but I've only being learning c code for about 4 weeks or so, this is one of my first pieces of code.

Anyhow it doesn't really matter now, with the spelling mistake fixed (still can't belive i missed it) everything is hunky dorey, I've even got that hang of pointers now.

You guys will be the first to get the version I'm gonna hand in belive me :)

I finally think that I've finished, here is the completed code that i will hand in on thursday, if anyone can find any obvious bugs (i.e maths being wrong, spelling mistakes) then please tell me so i can fix them.

I just wanna thank you guys, i doubt that i could have completed this without you lot, i hope that my spelling will pick up the more i code :D

Anyway on with the code:

Code:

---

#include <stdio.h>
#include<time.h>

float deposited (float, float*);
float withdrawn (float, float*);

int main()
{

int menu_choice = 0;
int transactions = 0;
float balance = 0;

int nodeposits = 0;
int nowithdraws = 0;
float totaldeposited = 0;
float totalwithdrawn = 0;
time_t timer;
while (menu_choice != 4)

{
printf ("Your current balance = %.2f \n", balance);
printf ("1.  Deposit funds \n");
printf ("2.  Withdraw funds \n");
printf ("3.  Show balance \n");
printf ("4.  Quit Program \n");
printf ("Please select what you wish to do (1-4): \n");
scanf ("%d", &menu_choice);


timer = time (NULL);

switch (menu_choice)
      {
      case 1:
      printf ("1. Deposit funds \n");
      balance = deposited (balance, &totaldeposited);
      nodeposits ++;
      transactions ++;

      printf("Deposit completed %s \n", asctime(localtime (&timer)));
      break;

      case 2:
      printf ("2. Withdraw funds \n");
      balance = withdrawn (balance, &totalwithdrawn);
      transactions ++;
      nowithdraws ++;
      printf("Withdraw completed %s \n", asctime(localtime (&timer)));
      break;

      case 3:
      printf ("3.  Show balance \n");
      printf ("Your current balance at %s is %.2f \n", asctime(localtime (&timer)), balance);
      break;

      case 4:
      printf ("Exiting... \n");
      printf ("closing balance.............%.2f \n", balance);
      printf ("completed transactions......%2d \n", transactions);
      printf (" \n");
      printf ("completed deposits..........%2d \n", nodeposits);
      printf ("total of money deposited....%.2f \n", totaldeposited);
      printf (" \n");
      printf ("completed withdraws.........%2d \n", nowithdraws);
      printf ("total of money withdrawn...%.2f \n", totalwithdrawn);

      break;

      default:
      printf("Please Enter a Choice from 1-4\n" );
      break;
      }

}


return 0;

}


float deposited (float balance, float *ptr_totaldeposited)
{
  float deposit = 0;
  printf ("Please enter how much you wish to deposit \n");
  scanf ("%f", &deposit);
  if ((deposit + balance < 999999) || (deposit + balance > 0))
  {
    balance = balance + deposit;
    (*ptr_totaldeposited) = (*ptr_totaldeposited) + deposit;
    printf ("Thank you %.2f has been entered into your account\n", deposit);
  }
  else
    printf ("I'm sorry but the number you have entered out of range \n");
 
  return (balance);
}





float withdrawn (float balance, float *ptr_totalwithdrawn)
{
float cashwithdraw = 0, chequewithdraw = 0;
int transtype;

printf ("Please enter how you wish to withdraw \n");
printf ("1.  Cash \n");
printf ("2.  Cheque\n");
scanf ("%d", &transtype);

switch (transtype)
    {
            case 1:
            {
            printf ("How much would you like to withdraw?  \n");
            scanf ("%f", &cashwithdraw);
            balance = balance - cashwithdraw;
            (*ptr_totalwithdrawn) = (*ptr_totalwithdrawn) + cashwithdraw;
            printf ("%.2f has being withdrawn from your account \n", cashwithdraw);
            break;
            }

            case 2:
            {
            printf ("How much would you like to withdraw? (maximum of 500) \n");
            scanf ("%f", &chequewithdraw);


            if ((chequewithdraw > 500) || (chequewithdraw < 0))
            printf ("You are limited to a maximum of 500 \n");

            {
            printf ("%.2f has being withdrawn from your account \n", chequewithdraw);
            balance = balance - chequewithdraw;
            (*ptr_totalwithdrawn) = (*ptr_totalwithdrawn) + cashwithdraw;
            }
            break;

            default:
            printf("Please Enter a Choice from either 1 or 2\n" );
            break;

            }
    }



return (balance);
}

---

>If someone had just said line 3 of the code i would of found it

Well I tried to do so using bold red text and other not-so-subtle hints, but...

Anyways, I think I like this bank. :p

Code:

---

Your current balance = 0.00
1.  Deposit funds
2.  Withdraw funds
3.  Show balance
4.  Quit Program
Please select what you wish to do (1-4):
1
1. Deposit funds
Please enter how much you wish to deposit
10
Thank you 10.00 has been entered into your account
Deposit completed Tue Jan 06 22:00:48 2004

Your current balance = 10.00
1.  Deposit funds
2.  Withdraw funds
3.  Show balance
4.  Quit Program
Please select what you wish to do (1-4):
2
2. Withdraw funds
Please enter how you wish to withdraw
1.  Cash
2.  Cheque
1
How much would you like to withdraw?
10000
10000.00 has being withdrawn from your account
Withdraw completed Tue Jan 06 22:00:54 2004

Your current balance = -9990.00
1.  Deposit funds
2.  Withdraw funds
3.  Show balance
4.  Quit Program
Please select what you wish to do (1-4):
4
Exiting...
closing balance.............-9990.00
completed transactions...... 2

completed deposits.......... 1
total of money deposited....10.00

completed withdraws......... 1
total of money withdrawn...10000.00

---

You might want to check whether the funds are available before handing out "money".


Oh, and you might want to take some time and indent nicely. It makes things more readable, but it also helps pick out unintentional things, some of which may be bugs.

Code:

---

float withdrawn (float balance, float *ptr_totalwithdrawn)
{
  float cashwithdraw = 0, chequewithdraw = 0;
  int transtype;

  printf ("Please enter how you wish to withdraw \n");
  printf ("1.  Cash \n");
  printf ("2.  Cheque\n");
  scanf ("%d", &transtype);

  switch ( transtype )
  {
  case 1:
      {
        printf ("How much would you like to withdraw?  \n");
        scanf ("%f", &cashwithdraw);
        balance = balance - cashwithdraw;
        (*ptr_totalwithdrawn) = (*ptr_totalwithdrawn) + cashwithdraw;
        printf ("%.2f has being withdrawn from your account \n", cashwithdraw);
        break;
      }

  case 2:
      {
        printf ("How much would you like to withdraw? (maximum of 500) \n");
        scanf ("%f", &chequewithdraw);


        if ( (chequewithdraw > 500) || (chequewithdraw < 0) )
            printf ("You are limited to a maximum of 500 \n");

        {
            printf ("%.2f has being withdrawn from your account \n", chequewithdraw);
            balance = balance - chequewithdraw;
            (*ptr_totalwithdrawn) = (*ptr_totalwithdrawn) + cashwithdraw;
        }
        break;

        default:
            printf("Please Enter a Choice from either 1 or 2\n" );
            break;

      }
  }

  return (balance);
}

---