How do I loop through a string of chars?

I have a private data member say (char *string1).

I wrote the following code.
for (char* temp=string1; *temp!='/0'; ++temp)

When I try to run this code I get an access violation error!
due to this *temp!='/0' part

so how am I suppose to go through a cstring??

Thanks

!='\0', or just ;*temp; is acceptable

Code:

---

temp!='\0'

---

Quote:

---

Originally posted by silverfoxtp
I have a private data member say (char *string1).

I wrote the following code.
for (char* temp=string1; *temp!='/0'; ++temp)

When I try to run this code I get an access violation error!
due to this *temp!='/0' part

so how am I suppose to go through a cstring??

Thanks

---

That code is correct. I would guess that string1 points to invalid memory. Post some more code.

>> fizisyen: temp != '\0'

Nope. That just compares the pointer to 0 (NULL), which it shouldn't be if the code is working properly.

>That code is correct. I would guess that string1 points to invalid memory. Post some more code.
The code is not correct, an escape character is '\c', not '/c'

>That just compares the pointer to 0 (NULL)
I'll let you off the hook this time, but '\0' and NULL should not be confused.

try this:

Code:

---

...
#include <cstring>
...
for(int i=0; i<strlen(stringName); i++)
{...}
...

---

unless you have something against using strlen() in this case...

>unless you have something against using strlen() in this case...
I do. You realize that this results in a quadratic time loop where not calling strlen as the condition would make it linear? For each iteration of the loop, strlen has to walk along the entire string to find the length. Why allow such inefficiency when you can easily fix the problem like so:

Code:

---

int len = static_cast<int> ( strlen ( stringName ) );
for ( int i = 0; i < len; i++ ) {
  ...
}

---

:rolleyes: yeah yeah yeah... i was just trying to get it written fast... and since he can't figure out how to loop through a string, i'm guessing he's not too worried about speed for now...

>i'm guessing he's not too worried about speed for now...
Better to set good habits early. Calling strlen unnecessarily in a loop is most definitely a bad habit to get into whether you're concerned with speed or not. There's just no argument for using it.

Quote:

---

Originally posted by Prelude
There's just no argument for using it.

---

did i ever say there was? jeebus...