your "horrorscope"......

(to the board editors: sorry for my previous thread !!)

We're asked to write an astrology program,

1. the user types his/her birthday..
2. the program responds with the user's zodiac sign...

So far, Im the only one on class who got it...
and I know I have to edit this source code -to make it simple..

Do you have any suggestions... comments ...

Please share your codes or *hints* so I may be able to research on the new stuff.....

Code:

---


#include <stdio.h>
#include<string.h>
main()
{
 char s[80];
 int d;

 clrscr();

 printf("enter the month of your birthday: ");
 gets(s);

 if(!(strcmp(s, "january")))
 {
  printf("\n enter the date of your birthday: ");
  scanf("%i", &d);
  if(d<=19)
  printf("\n CAPRICORN");
  else
  printf("\n AQUARIUS");
 }

 if(!(strcmp(s, "february")))
{
 printf("\n enter the date of your birthday: ");
 scanf("%i", &d);
 if(d<=18)
 printf("\n AQUARIUS");
 else
 printf("\n PISCES");
}

 if(!(strcmp(s, "march")))
{
 printf("\n enter the date of your birthday: ");
 scanf("%i", &d);
 if(d<=20)
 printf("\n PISCES");
 else
 printf("\n ARIES");
}

 if(!(strcmp(s, "april")))
{
 printf("\n enter the date of your birthday: ");
 scanf("%i", &d);
 if(d<=19)
 printf("\n ARIES");
 else
 printf("\n TAURUS");
}

 if(!(strcmp(s, "may")))
{
 printf("\n enter the date of your birthday: ");
 scanf("%i", &d);
 if(d<=20)
 printf("\n TAURUS");
 else
 printf("\n GEMINI");

}

 if(!(strcmp(s, "june")))
{
 printf("\n enter the date of your birthday: ");
 scanf("%i", &d);
 if(d<=20)
 printf("\n GEMINI");
 else
 printf("\n CANCER");
}

 if(!(strcmp(s, "july")))
{
 printf("\n enter the date of your birthday: ");
 scanf("%i", &d);
 if(d<=22)
 printf("\n CANCER");
 else
 printf("\n LEO");
}

 if(!(strcmp(s, "august")))
{
 printf("\n enter the date of your birthday: ");
 scanf("%i", &d);
 if(d<=22)
 printf("\n LEO");
 else
 printf("\n VIRGO");
}

 if(!(strcmp(s, "september")))
{
 printf("\n enter the date of your birthday: ");
 scanf("%i", &d);
 if(d<=22)
 printf("\n VIRGO");
 else
 printf("\n LIBRA");
}

 if(!(strcmp(s, "october")))
{
 printf("\n enter the date of your birthday: ");
 scanf("%i", &d);
 if(d<=22)
 printf("\n LIBRA");
 else
 printf("\n SCORPIO");
}

 if(!(strcmp(s, "november")))
{
 printf("\n enter the date of your birthday: ");
 scanf("%i", &d);
 if(d<=21)
 printf("\n SCORPIO");
 else
 printf("\n SAGITTARIUS");
}

 if(!(strcmp(s, "december")))
{
 printf("\n enter the date of your birthday: ");
 scanf("%i", &d);
 if(d<=21)
 printf("\n SAGITTARIUS");
 else
 printf("\n CAPRICORN");
}
  getch();
}

---

Thanks in advance !!!!

here's a hint: do something to all those if blocks to make them more readable, and simpler. Just a little switch in how you check your input could make a big difference in simplifying your code.

back then (while fixing this code) I got the idea of using switches..

but Im having a TOTAL mess with using strings as "variables" and case "constants"...

how should i write:

Code:

---

switch('month') {
    case 'january':
      { statement sequence}
      break;
    case 'february':
      { statement sequence }
      break;

  etc... etc,...
      }

---

anyway... how could i use characters and strings as switch/case conditions...? Im used to numbers only...

I really couldn't get it....

if you could give me a simple example,.. it might help me through this !!

Thanks !!

Have you though about using a enumeration?

you can't use strings that way. I would probably do an enum type thing as suggested. Besides, string compares take a lot longer.

OK, ready? Tighten your seatbelts, cuz here we go!!!

1) Your main() should be int main()
and put a return 0; at the bottom of the code.

2) gets(s); should be changed to fgets(s,80,stdin);. gets() will allow you to blow your data array and cause problems

3) Set up arrays for your values:
char *months[12]; // Hold the month names
char *signs[12]; // holds the sign names
int datechg[12]; // day of month the sign changes

4) Move the "enter the date of ..." input immediately after the "enter the month...", that way you only need it once.

5) Instead of a bunch of if's, use a loop to test the month entered with months. Be sure to use a case insensitive test to distinguish between april, April, and APRIL. This loop will give you an index (say m) into the other two arrays.

6) Test datechg[m] against your d and if d is >, add one to m (if m is now 12, replace it with 0)

7) m now contains the index into the signs array for the person's horrorscope.

Oi !

You deduced my problem to the point of REAL simplicity !!

Yeah !! Thanks !!

I got edited it all to using: fgets(s, 80,stdin),... the int main(),..
and return 0; (as you clarified)...

But i couldnt follow your point in determing the zodiac sign,--given the month and date,...

I don't mean to push you through this....

but could you please give me a straight formula.. if there is ?

anyway,.. Thanks A Lot Dude !!!!!!

Quote:

---

Originally posted by imbecile in C
I got edited it all to using: fgets(s, 80,stdin),... the int main(),..
and return 0; (as you clarified)...

---

I assume you also put the input for the day of the month directly under the month input.

Quote:

---

But i couldnt follow your point in determing the zodiac sign,--given the month and date,...

---

Step 1, figure out what month was entered. I'm going to use a different problem and you can figure out how to use it in your program:

Code:

---

char *continent = {"Australia, Asia, Africa, Europe, NAmerica, SAmerica"};
char contin[20];

printf("Enter a continent: ");
fgets(contin, 20, stdin);

i=0;
while (strcmp(contin, continent[i]) != 0)
{
    i++;
    if (i >= 6) break;
}
if (i >= 6)
{
    print "Invalid continent entered: %s\n", contin);
}
else
{
    /* the rest of the code, with i as your index */
}

---

You need to figure out what action to take if they type in something invalid. Also, depending on your compiler, the strcmp() could be a case insensitive comparison like stricmp() on some Windows compilers. Otherwise you might want to write your own.

That should get you started.

Yes, I forgot a continent, but it's too cold to even consider...

>>You need to figure out what action to take if they type in something invalid.<<
You even need to add further code to check a valid entry (hint: newline)

Code:

---

char *continent = {"Australia, Asia, Africa, Europe, NAmerica, SAmerica"};

---

Oopps, that ain't right ;) I think you've missed something there, and no, I don't mean a continent!

The while loop is pretty poor too imho, a for loop would be a neater way to do it (and therefore better to teach the newbies with...)

Quote:

---

Originally posted by Hammer
>>You need to figure out what action to take if they type in something invalid.<<
You even need to add further code to check a valid entry (hint: newline)

Code:

---

char *continent = {"Australia, Asia, Africa, Europe, NAmerica, SAmerica"};

---

Oopps, that ain't right ;) I think you've missed something there, and no, I don't mean a continent!

The while loop is pretty poor too imho, a for loop would be a neater way to do it (and therefore better to teach the newbies with...)

---

Okay, okay, be that way ;)

Code:

---

char *continent = {"Australia", "Asia", "Africa", "Europe", "NAmerica", "SAmerica"};

---

I disagree about the for loop. It is of course a personal choice. I dislike for loops for looking thru a list and breaking prematurely if found. It should go thru to the comparison except in an extreme case. IMHO I feel a while loop or do-while is better suited for this situation.

Quote:

---

Originally posted by WaltP

Code:

---

char *continent = {"Australia", "Asia", "Africa", "Europe", "NAmerica", "SAmerica"};

---

---

That doesn't compile :rolleyes: :D You still forgot something!

And for the for loop, here's my suggestion:

Code:

---

for (i = 0; i < 6 && strcmp(contin, continent[i]) != 0; i++)
    ;

---

Code:

---

char *continent ={"Australia", "Asia", "Africa", "Europe", "NAmerica", "SAmerica"};

---

Ok.. How do you declare the continent right ??

God ! your concepts are to advanced for me to follow...
the truth is im grappling on a hook for this one,..

I do really SURRENDER !!!

I wish to understand,..

Thanks !!

How could I simplify this more...


[note: fgets(s, 80, stdin) doesn't work for me... (sorry) it doesnt compile !!]

it doesn't matter if the user types the month and date:

June 6789 (no error traps for a while)...

Code:

---

#include <stdio.h>
int main()
{
 char s[80];
 int d;
 clrscr();

 printf("enter the MONTH of your birthday: ");  gets(s);
 printf("enter the DATE  of your birthday: ");  scanf("%i", &d);

 if(!strcmp(s, "january")) {
  if(d<=19)
  printf("\n CAPRICORN");
  else
  printf("\n AQUARIUS");
 }

 if(!strcmp(s, "february")) {
  if(d<=18)
  printf("\n AQUARIUS");
  else
  printf("\n PISCES");
 }

 if(!strcmp(s, "march")) {
  if(d<=20)
  printf("\n PISCES");
  else
  printf("\n ARIES");
 }

 if(!strcmp(s, "april")) {
  if(d<=19)
  printf("\n ARIES");
  else
  printf("\n TAURUS");
 }

 if(!strcmp(s, "may")) {
  if(d<=20)
  printf("\n TAURUS");
  else
  printf("\n GEMINI");
 }

 if(!strcmp(s, "june")) {
  if(d<=20)
  printf("\n GEMINI");
  else
  printf("\n CANCER");
 }

 if(!strcmp(s, "july")) {
  if(d<=22)
  printf("\n CANCER");
  else
  printf("\n LEO ");
 }

 if(!strcmp(s, "august")) {
  if(d<=22)
  printf("\n LEO ");
  else
  printf("\n VIRGO");
 }

 if(!strcmp(s, "september")) {
  if(d<=22)
  printf("\n VIRGO");
  else
  printf("\n LIBRA ");
 }

 if(!strcmp(s, "october")) {
  if(d<=22)
  printf("\n LIBRA ");
  else
  printf("\n SCORPIO ");
 }

 if(!strcmp(s, "november")) {
  if(d<=21)
  printf("\n SCORPIO");
  else
  printf("\n SAGITTARIUS");
 }

 if(!strcmp(s, "december")) {
  if(d<=21)
  printf("\n SAGITTARIUS");
  else
  printf("\n CAPRICORN");
 }
  getch(); return 0;
}

---

anyway, I've submitted this as an assignment... Im the only one on class who got it right,..

but I just wanna know any techniques to simplify this code !
pls give some examples,..

Thanks Dudes !!

Quote:

---

Originally posted by imbecile in C

Code:

---

char *continent[] ={"Australia", "Asia", "Africa", "Europe", "NAmerica", "SAmerica"};

---

Ok.. How do you declare the continent right ??

---

The [] was missing. Without it, the original attempt:
char *continent = {"one two three"};
.. creates a single string consisting of many words, it does not create a 2d array.

With the [] and comma delimited list, you are creating an array of char pointers, and assigning them default values, pointing to the string literals.

Here's a simple program to show you:

Code:

---

#include <stdio.h>

/* There are better ways to express the array size,
but I won't cover them here, I'll keep things simple */
#define NUM_CONTINENTS 6

int main(void)
{
  char *continents[NUM_CONTINENTS] = {"Australia", "Asia", "Africa", "Europe", "NAmerica", "SAmerica"};
  int i;
 
  for (i = 0; i < NUM_CONTINENTS; i++)
    puts (continents[i]);
 
  return(0);
}

/* Output

Australia
Asia
Africa
Europe
NAmerica
SAmerica

*/

---

And now a more useful sample for you to study:

Code:

---

#include <stdio.h>
#include <string.h>

/* There are better ways to express the array size,
but I won't cover them here, I'll keep things simple */
#define NUM_CONTINENTS 6

int main(void)
{
  char *continents[NUM_CONTINENTS] = {"Australia", "Asia", "Africa", "Europe", "NAmerica", "SAmerica"};
  int i;
  char buf[BUFSIZ];  /* BUFSIZ is a number, at least 256 in value */
 
  printf ("Enter a continent: ");
  fflush(stdout);
 
  if (fgets(buf, sizeof(buf), stdin))
  {
    strtok (buf, "\n\r"); /* Remove the newline character from the input */
   
    for (i = 0; i < NUM_CONTINENTS; i++)
    {
      if (strcmp (continents[i], buf) == 0)
      {
        printf ("Found a match for %s\n", continents[i]);
        break;
      }
    }
    if (i == NUM_CONTINENTS)
    {
      puts ("No match found");
    }
   
  } 
  return(0);
}

---

Oi !!

Thats real help dude !!
I had copied your codes on my Very Creative !! Thanks !!!
=======

Now.. may i ask something again...??

I have a source code below,... and notice that I have simplified it thoroughly (thanks for your help)

Notice the switch part:

I gotta simplify it somehow,.. same printf's repeat 2 times...

What should I do to revise the code.. ??

Code:

---

#include <stdio.h>
#define N 12
int main(void)
{
  char m[80], *months[N] = {"january", "february", "march", "april", "may",
                            "june", "july", "august", "september", "october",
                            "november", "december"};
  int i, d;
  clrscr();
  printf("enter MONTH of birth: ");  gets(m);
  printf("enter DATE  of birth: ");  scanf("%i", &d);
  for(i=0; i<N && strcmp(m, months[i]) != 0; i++);
  switch(i) {
    case 0:  if (d<=19) printf("CAPRICORN"); else printf("AQUARIUS"); break;
    case 1:  if (d<=18) printf("AQUARIUS"); else printf("PISCES"); break;
    case 2:  if (d<=20) printf("PISCES"); else printf("ARIES"); break;
    case 3:  if (d<=19) printf("ARIES"); else printf("TAURUS"); break;
    case 4:  if (d<=20) printf("TAURUS"); else printf("GEMINI"); break;
    case 5:  if (d<=20) printf("GEMINI"); else printf("CANCER"); break;
    case 6:  if (d<=22) printf("CANCER"); else printf("LEO"); break;
    case 7:  if (d<=22) printf("LEO"); else printf("VIRGO"); break;
    case 8:  if (d<=22) printf("VIRGO"); else printf("LIBRA"); break;
    case 9:  if (d<=22) printf("LIBRA"); else printf("SCORPIO"); break;
  case 10:  if (d<=21) printf("SCORPIO"); else printf("SAGITTARIUS"); break;
  case 11:  if (d<=21) printf("SAGITTARIUS"); else printf("CAPRICORN"); break;
  }
  getch();

}

---

Sorry, but I dont get it....

should I use the switch again...?

but i do understand that i have to declare:

Code:

---

char *zodiac[N] = { "CAPRICORN", "AQUARIUS", "PISCES", "ARIES", "TAURUS", "GEMINI", "CANCER", "LEO", "VIRGO", "LIBRA", "SCORPIO", "SAGITTARIUS"};

int *date[4] ={18, 19, 20, 22};

---

I couldn't discern it... pls show me the way...

sorry, got a correction.. int 21 and limit

Code:

---

char *zodiac[N] = { "CAPRICORN", "AQUARIUS", "PISCES", "ARIES", "TAURUS", "GEMINI", "CANCER", "LEO", "VIRGO", "LIBRA", "SCORPIO", "SAGITTARIUS"};

int *limit[4] ={18, 19, 20, 21, 22};

---

i couldn't get the idea of using these info's for the switch...
please share some hints and ideas...

Here's an example of using arrays and structures to do the job, using an easy-to-use indexing scheme.

Enjoy.

Code:

---


#include <stdio.h>
#include <stdlib.h>



struct date {
 int month;
 int day;
};




void init_date(date * d, int month, int day)
{
 d->month = month, d->day = day;
}




enum signs { frog = 0, rat = 1, horse = 2 };




struct zodiak {
 signs sign;
 date begin;
 date end;
};




void init_zodiak(zodiak * z, signs sign, int begin_month, int begin_day, int end_month, int end_day)
{
 z->sign = sign;
 init_date(&z->begin, begin_month, begin_day);
 init_date(&z->end, end_month, end_day);
}




int within(zodiak z, int month, int day)
{
 if(  (month == z.begin.month && day >= z.begin.day)
    ||(month == z.end.month && day <= z.end.day) )
  return 1;

 return 0;
}




zodiak * lookup(int month, int day, zodiak array[], int array_length)
{
 int i;

 for(i = 0; i < array_length; ++i)
  if(within(array[i], month, day))
  return &array[i];

 return 0;
}




#define MAX 3




int main(int argc, char *argv[])
{
 zodiak zdk[MAX];

 init_zodiak(&zdk[frog], frog, 1, 15, 2, 14);
 init_zodiak(&zdk[rat], rat, 2, 15, 3, 14);
 init_zodiak(&zdk[horse], horse, 3, 15, 4, 14);

 char * names[MAX];
 char * horoscopes[MAX];

 names[frog] = "Frog";
 names[rat] = "Rat";
 names[horse] = "Horse";

 horoscopes[frog] = "Frogs tend to be slimeballs.";
 horoscopes[rat] = "Rats can't be trusted.";
 horoscopes[horse] = "Horses are great in bed.";

 int month, day;

 printf("Enter Month: ");

 scanf("%d", &month);

 printf("Enter Day: ");

 scanf("%d", &day);

 zodiak * found = lookup(month, day, zdk, MAX);

  if(found)
 {
  int index = found->sign;

  printf("%s\n", names[index]);

  printf("%s\n", horoscopes[index]);
 }
  else printf("Unsupported or invalid date.");

 system("pause");

 return 0;
}

---

Hey Dudes !!

Oi ! /*Salem*/ !!

I don't know what you call it... but I woke up this evening, and got the idea for the problem... i got it on paper then typed it on my P.C. - and Yeah it worked !!

But I got startled when I checked this board and found you
got the same idea too... Cool !!

"From a long bunch of flies to a pile of maggots" - that's what happened to this "horrorscope" --> real horror !!

Code:

---

#include <stdio.h>
#define N 12
int main(void)
{
  char m[80], *months[N] = {"january", "february", "march", "april", "may",
                            "june", "july","august", "september", "october",
                            "november", "december"},
              *zodiac[N] = {"CAPRICORN", "AQUARIUS", "PISCES", "ARIES",
                            "TAURUS", "GEMINI", "CANCER", "LEO", "VIRGO",
                            "LIBRA", "SCORPIO", "SAGITTARIUS"},
              *limit[N] = { 19, 18, 20, 19, 20, 20, 22, 22, 22, 22, 21, 21 };
  int i, d;
  clrscr();
  printf("enter MONTH of birth: ");  gets(m);
  printf("enter DATE  of birth: ");  scanf("%i", &d);
  for(i=0; i<N && strcmp(m, months[i]) != 0; i++);
  if(d<=limit[i])
  printf(zodiac[i]);
  else
  printf(zodiac[i+1]);
  getch();
}

---

Oi !! /*Sebastiani*/ !!

You got some fine idea dude ! I gotta copy it and research more on it !! Thanks !!

=========
Thanks Dudes !! I learned a lot from this work !! More than 10 hours of lecture on class....

If you got some comments and anything to jerk out, please yell it out !!!

--------------------------------------------------------------

I just want to say LOVE YOU SAN!!
billy gates why do you make this possible ? Stop making money and fix your software!!

Here's the revised code again:

Code:

---

#include <stdio.h>
#define N 12
int main(void)
{
  char m[80], *months[N] = {"january", "february", "march", "april", "may",
                            "june", "july","august", "september", "october",
                            "november", "december"},
              *zodiac[N] = {"CAPRICORN", "AQUARIUS", "PISCES", "ARIES",
                            "TAURUS", "GEMINI", "CANCER", "LEO", "VIRGO",
                            "LIBRA", "SCORPIO", "SAGITTARIUS"};
  int i, d,  *limit[N] = { 19, 18, 20, 19, 20, 20, 22, 22, 22, 22, 21, 21 };
  clrscr();
  printf("enter MONTH of birth: ");  gets(m);
  printf("enter DATE  of birth: ");  scanf("%i", &d);
  for(i=0; i<N && strcmp(m, months[i]) != 0; i++);
  if(d<=limit[i])
  printf("%s\n", zodiac[i]);
  else
  printf("%s\n", zodiac[(i+1)%N]);
  getch();
}

---

I wish to understand....

if(d<=limit[i])
printf("%s\n", zodiac[i]);
else
printf("%s\n", zodiac[(i+1)%N]

i tried it on december 25.. and u are correct !! some garbage..
and then it occurred to me.. ohhh yeah....!!

but why %N ? what's that for ?? I know it corrects the code... but what's its purpose ?

The modulus (%) obtains the remainder of a division. For instance:

10 % 3 = 1

Thus, that code insures that an in-bounds index is generated.

/*sebastiani*/

The modulus (%) obtains the remainder of a division....

Thus, that code insures that an in-bounds index is generated.
-------------

oh yes,.. of course, of course....

modulus operator (mod) of course.. makes the index iterate within the array,..

I couldn't really have thought of that thing....

How did your brain's neurotransmitters connect to that concept ?
Your brains are all wired differently !! *envy*

Great !! I really learned a lot !!

Merci !!!

Quote:

---

Originally posted by Salem
You're still not listening
limit is an array of int not an array of char *

---

So... based on Salem's comment you (
imbecile in C) made it :
>>int *limit[N] = ....
which is still wrong, this is an array of int pointers, not an array of ints. You need:
>>int limit[N] = ...

Quote:

---

Originally posted by imbecile in C

Code:

---

...
  for(i=0; i<N && strcmp(m, months[ i ]) != 0; i++);
  if(d<=limit[ i ])
      printf("%s\n", zodiac[ i ]); /*indent for readability,
                          make the code tags useful */
  else
      printf("%s\n", zodiac[(i+1)%N]); /*indent for readability */
  getch();
}

---

---

OK, let's look at this logically:
After for(i=0; i<N && strcmp(m, months[ i ]) != 0; i++); what does the value i represent? The month. And the zodiac IF day < limit[ i ]. Seem reasonable?

So, instead of if(d<=limit[ i ]) how about
if(d>=limit[ i ]) i++; /* go to the next month */

BUT, i might be > N at this point, so the year wrapped:
if(i >= N) i -= N; /* go to the first month */

Now you can simply:
printf("%s\n", zodiac[ i ]);

Im copying your comments dudes.... Im learning more on those "indentations for readability" ...(imbecile me)...

now i have to *really* listen..

int *limit[N] ---> wrong

int limit[N] -----> right....!!

i should understand the purpose of an array of "int pointers", and an array of "ints only"...

Im analyzing the points given by Walt P... and yeah ! they're awesome ideas..

Code:

---

#include <stdio.h>
#define N 12
int main(void)
{
  char m[80], *months[N] = {"january", "february", "march", "april", "may",
                            "june", "july","august", "september", "october",
                            "november", "december"},
              *zodiac[N] = {"CAPRICORN", "AQUARIUS", "PISCES", "ARIES",
                            "TAURUS", "GEMINI", "CANCER", "LEO", "VIRGO",
                            "LIBRA", "SCORPIO", "SAGITTARIUS"};
  int i, d,  limit[N] = { 19, 18, 20, 19, 20, 20, 22, 22, 22, 22, 21, 21 };
  clrscr();
  printf("enter MONTH of birth: ");  gets(m);
  printf("enter DATE  of birth: ");  scanf("%i", &d);
  for(i=0; i<N && strcmp(m, months[i]) != 0; i++);
 if(d<=limit[i])
    printf("%s\n", zodiac[i]);
 
else
    printf("%s\n", zodiac[(i+1)%N]);
  getch();
}

---

--------

or as recommended by Walt P

Code:

---

#include <stdio.h>
#define N 12
int main(void)
{
  char m[80], *months[N] = {"january", "february", "march", "april", "may",
                            "june", "july","august", "september", "october",
                            "november", "december"},
              *zodiac[N] = {"CAPRICORN", "AQUARIUS", "PISCES", "ARIES",
                            "TAURUS", "GEMINI", "CANCER", "LEO", "VIRGO",
                            "LIBRA", "SCORPIO", "SAGITTARIUS"};
  int i, d,  limit[N] = { 19, 18, 20, 19, 20, 20, 22, 22, 22, 22, 21, 21 };
  clrscr();
  printf("enter MONTH of birth: ");  gets(m);
  printf("enter DATE  of birth: ");  scanf("%i", &d);
  for(i=0; i<N && strcmp(m, months[i]) != 0; i++);
  if(d>=limit[i]) i++;
  if(i>=N) i-=N;
    printf("%s\n", zodiac[(i)]);
  getch();
}

---

Great !! WHew !!

===========

that which one learns with difficulty would not be easily forgotten...

especially by an imbecile one..

merci !!