problems converting string to char[]

Hello!

i searched the forum for string to char posts and tried a good one for converting a string to char[]:

Code:

---


string mystring = "that this and those";
char  mychar[mystring.length()] = "";

for (int i=0; i < mystring.length(); i++)
  mychar[i] = mystring[i];

cout << mychar;

---

It gives the right output but appends some weired output and i dont know how to fix it. I also tried to use:

Code:

---

for (int i = 0; i < mystring.length();++i )

---

But doesnt work either. There is still this weired appended output.



Thanks in advance!

~Jan

Set the size of the char array to 1 larger than the CString. You need a NULL on the end to terminate the string. The rubbish you are seeing is whatever happens to be in memory after the end of the characters you are copying.

You could always:

Code:

---

string mystring = "that this and those";
char  mychar[mystring.length() + 1];  // allow space for null

strcpy(mychar, mystring.c_str());  // copy the string's data into your c-string

---

Yea, I was being stupid. Just to show, I left two spaces between char and mychar, probably for the * for the new clause. STUPID ME! lol

Jan79 wasn't dynamically allocating memory. Jan was using the string class.