MFC: Loop within OnXYZ methods

Hi all!,

I want to do some operations after a button has been clicked.
The operation needs some calls to return a true so it can be returned from this method.
Code sample:

Code:

---

void CTerraformer::OnButtonFormTerra()
{
        while (!m_bDone)
        {
                m_bDone = makeSomeOperationsHere();
               
                MSG msg;
                while (PeekMessage(&msg, NULL, 0, 0, true))
                {
                        TranslateMessage(&msg);
                        DispatchMessage(&msg);
                }
        }
}

---

I saw a construct like the code sample above and to me it looks like
a mixture of MFC and pure WIN32 API programming.

My question: Is this a clean way to code MFC ???

Regards,
Robert

Actually that's pure API inside a class member function, using the MFC class naming convention (but that might be coincidence).

And no, it doesn't look like clean coding to me. A message loop somewhere in a stray place can't be clean.

i thought the same, ... any suggestions how make it
to be a clean code ?

-
Robert

It's a larger issue. I would guess removing the message loop and calling the method differently (from a different place/thread) should solve it. But that's an issue of program design, not just a single method.