Palindrome

Created a palindrome but it is supposed to ignore the whitespaces in the string. can anyone tell me what's wrong here?

Code:

---

#include <stdio.h>
#include <string.h>
#include <stdlib.h>

main(){
        char mes1[80],mes2[80];
        printf("Enter a string here --> ");
/*        scanf("%s",mes1);        */
        getline(mes1);
        strcpy(mes2,mes1);
        reversi(mes1,mes2);
        printf("%s  %s\n",mes1,mes2);       
        if (strcmp(mes1,mes2) == 0)
                printf(" You entered a palindrome word \n");
        else
                printf(" No, the word is NOT a palindrome \n");
}       


getline(m1in)
char m1in[80];
{
        int i=0;
        char c;
        while(i<81 && (c=getchar()) !='\n'){
                m1in[i]=c;
                ++i;
        }
        m1in[i]='\0';
        return;
}       

reversi(m1,m2)
char m1[80],m2[80];
{       
        int i=0,jl;
        jl=strlen(m1);
        while (i<jl){
                m2[i]=m1[jl-i-1];
                i++;
        }
        return;
}

---

The second time I'm saying this to you:

I am posting this because you did not use code tags on this thread. In the furture please use Code Tags. They make your code MUCH easier to read and people will be much more likely to help you if you do. And they'll be happier about helping you ;)

For example:

Without code tags:

for(int i=0;i<5;i++)
{
cout << "No code tags are bad";
}

With Code Tags:

Code:

---

for(int i=0;i<5;i++)
{
    cout << "This code is easy to read";
}

---

This is of course a basic example...more complicated code is even easier to read with code tags than without.

I've added code tags for you this time. They can be added by putting [code] at the beginning of your code and [/code] at the end. More information on code tags may be found on the code tag post at the top of every forum. I also suggest you take a look at the board guildlines if you have not done so already.

This is a common first post mistake, just remember to use [code] tags in the future and you'll get much more help.

If this is your first time posting here the welcome, and if there's anything I can do or any questions I can answer about these forums, or anything else, please feel free and welcome to PM me.


Good Luck with your program,

Kermi3
Lead Moderator

>Created a palindrome but it is supposed to ignore the whitespaces in the string.

How is it supposed to be ignoring whitespace? You are reading space characters in with everything else.

Code:

---

while(i<81 && (c=getchar()) !='\n')
  if(!isspace(c)) /* be selective */
      m1in[i++]=c;

---

Sorry, I am new.

Won't happen again.

No problem...Trust me, if I was actually upset you'd know it :D. Just a pet peeve of the board. Figure out your problem?

If you type spaces in for the string, and you want to ignore them in the test, you must remove them before processing.

If you want to display the original text typed in, you will need a third array "mes3" to hold the string that does not include spaces (commas, periods, and other punctuation?) and have your code operate on mes3 instead. After the test, you can still output mes1.

Walt

Quote:

---

Originally posted by WaltP
If you type spaces in for the string, and you want to ignore them in the test, you must remove them before processing.

---

No you don't. Do the following:

Code:

---

ptr1 = start of list;
ptr2 = end of list;

while( ptr1 )
{
    while( isspace( ptr1 ) )
        ptr1++;
    while( isspace( ptr2 ) );
        ptr2--;

    if( ptr1 != ptr 2 )
        not_a_match( );

    increment ptr1
    decrement ptr2
}

---

See? You don't even need an array at all. Just two pointers. You'll need slightly more error checking than that, but that's the basic idea.

Quzah.

True Q, but I was allowing for the strcmp() as designed as opposed to writing another compare function. This requires less 'error checking', too.

W