how can i get out of this do while loop?

The idea here is that if the user types "hi", then the loop ends, however it doesn't.

Code:

---

void conversation1 ()
        {
  int integer;
  char command[256];
  integer=1;
  do
  cout<<"hi!";
  cout <<"\n\nEnter Command: ";
  cin.getline(command, 256, '\n');
  {
  if (!strcmpi("hi", command))
  {
        integer=0;
  }
  }
  while (integer!=0);
  }

---

No it confirms that Im entering "hi"

here is what i did:

Code:

---


#include <iostream>
#include <string>
using namespace std;

void conversation1 ();

int main()
{
        conversation1();

return 0;
}

void conversation1 ()
        {
  int integer;
  char command[256];
  integer=1;
  do{
  cout <<"hi!";
  cout <<"\n\nEnter Command: ";
  cin.getline(command, 256, '\n');
  if (!strcmpi("hi", command))
  {
        integer=0;
  }
  }while (integer!=0);
return; 
}

---

and it works fine, if i enter hi it exits, anything else it loops...

I got it thanks

Do I need the return; in there? The big problem turned out to be that this function was being called from inside another doloop so it was actually working right, but the other doloop needed to have an exit. So I made one! : ) Still though, looking at your code helped me figure out the problem.

Quote:

---

Originally posted by Noobie
Do I need the return; in there?

---

no, but a lot of people will argue that it is good practice.

I think u should do this instead its a better way to achieve what u want..

Code:

---

#include <iostream>
#include <string>
using namespace std;

void conversation1()
{
      char command[256] = "bob";
      while(strcmpi("hi", command))
      {
          cout<<"hi!";
          cout <<"\n\nEnter Command:"<< endl;
          cin>> command;
      }
}
 
 
int main()
{
      conversation1();
      return 0;
}

---

i think that you are missing a bracket({) after the do in the do while statement.