Problem in table referencing

Can anyone help me in the table referencing? See the below example:
-------------------------------------------------------------------

Code:

---

#include <iostream.h>
#include <string.h>

//#define TABLE_SIZE 10

struct tableType
{
  char actual;
  char cipher;
};


class secret
{
  tableType table[10];
  char text[256];
  char temp[256];
  int length;

public:
  secret();
  //~secret(){}
  void enter_message();
  //char get_message();
  void encrypt();
  void display();
};

secret::secret()
{

  table[0].actual='A'; table[0].cipher='z';
  table[1].actual='B'; table[1].cipher='a';
  table[2].actual='C'; table[2].cipher='q';
  table[3].actual='D'; table[3].cipher='1';
  table[4].actual='E'; table[4].cipher='2';
  table[5].actual='F'; table[5].cipher='w';
  table[6].actual='G'; table[6].cipher='s';
  table[7].actual='H'; table[7].cipher='x';
  table[8].actual='I'; table[8].cipher='c';
  table[9].actual='J'; table[9].cipher='d';
}

void secret::enter_message()
{
  cout << "Enter Your Message: ";
  cin.getline(text,256);
}


void secret::encrypt()
{
  length=strlen(text);

  for (int x=0; x {
      for (int y=x; y<10; y++)
      {
        if (text[x]==table[y].actual)
            temp[x]=table[y].cipher;
      }
  }
}

void secret::display()
{
  cout << endl;
  cout << "Original Text: " << text << endl << endl;

  cout << "Encrypted Text: " << temp << endl << endl;

  cout << "ACTUAL" << " " << "CIPHER" << endl;
  cout << "======" << " " << "======" << endl;

  for (int i=0; i<10; i++)
  {
      cout << table[i].actual << " " << table[i].cipher << endl;
  }
}

void main()
{
  secret sc;
  sc.enter_message();
  sc.display();

  cout << endl << endl;
}

---

-------------------------------------------------------------------

What I want is just create a table with 2 columns. One for actual value and the other is for cipher value. Then I'll enter a message and let the program to convert the character (of the message) to cipher one.

I think I'll doing in the stupid and incorrect way. I need you guys advise. Please help.

Use your defines!

You have defined TABLE_SIZE but you don´t use it. Do yourself the favor!
Also define like:

Code:

---

#define MAXLINESIZE 256

---

and replace your magic 256-number with that.

Your encrypt function seems to be wrong, you might wanna do like:

Code:

---

void secret::encrypt()
{
  length=strlen(text);

  for (int x=0; x<lenght;x++){                        // Run through string
      for (int y=0; y<TABE_SIZE; y++)        // Run through look-up table
      {
              // If character matches look-up table character then put encrypted char in temp
        if (text[x]==table[y].actual) { temp[x]=table[y].cipher; }
                        // Else put normal char in temp
                        else                                                                        { temp[x]=text[x];}
      }
  }
}

---

Thanks... I'll try on it...

Quote:

---

Originally posted by Hardboy
Use your defines!

You have defined TABLE_SIZE but you don´t use it. Do yourself the favor!
Also define like:

Code:

---

#define MAXLINESIZE 256

---

---

Is it better form to declare constants using defines, or declare constants using const?

Code:

---

const int ACTUAL = 10;
const int CYPHER = 10;
char table[ACTUAL][CYPHER];
int i, j;

//to decode a secret message using this table
for(i= 0//etc)
{
  for(j = 0; //etc)
  {
    //the cypher for a given j will always be element 1
    if(input[i] == table[j][1])
    {
      //the actual for a given j will always be element 0
      cout << table[0][j];
    }
  }
}

//to encode a secret message using this table reverse the above sequence

---

Thanks for your help. I manage to do the program but using other way. I'm using the array of object as a table. But there is another problem.

The problem is the compiler prompt me the message that the array size is too large. Can anyone help me again? Please click the below link.

I have post this problem as another thread