void to void to out of void jump

In my BotK game, i have a soundtrack. On the main menu, you can access 3 things

1: Play game
2: Bgm test
3: Exit

I can get everything to work fine. When in the Bgm test, if you want to go to the main menu, you hit the button, then it closes.

Look at my code and tell me how i can fix it. I've trieds everything, and all i can think is a Goto.

But that wont work either. It wont compile.

while loops are your friend. Avoid using a goto at all costs.

If you must resort to a goto I hardly believe that you've tried hard enough.

Trust me, abrege, i have tried. I even copied the entire game code and put it into the function. it still didn't work.
If i use goto, i use code like this:

Code:

---

void test()
{
cout << "Testing\n";
goto top;
};

top:
cout << "top";

---

and i get this error:

line 4: top not defined, but declared

I took a quick look at your code, and... BOY, does it need improvement. First of all, your indentation sucks. In fact, it doesn't exist at all. Indentation is good because it's easier to see at which depth (scope) the code is at. Take a look at these snippets:

Code:

---

int main()
{
switch(MyChoice)
{
case 'a':
printf("You pressed A");
break;
default:
printf("I don't know what you pressed, but it wasn't A");
break;
}
}


int main()
{
  switch(MyChoice)
  {
      case 'a':
        printf("You pressed A");
        break;

      default:
        printf("I don't know what you pressed, but it wasn't A");
        break;
  }
}

---

Which one is easiest to read? The latter of course. As mentioned, it's easier to see at what depth the code is at and it's easier to detect missing brackets and such.

The second thing I noticed in your code was your endlessly recursive function calls. You have your loop in this manner:

Code:

---

void Func1()
{
  PlaySound(...);
  Func2();
}

void Func2()
{
  //Notice, this is not valid code:
  Choice = ¤¤ Wanna play again? ¤¤

  if(Choice == 'y')
  {
      Func1();
  }
}

---

This leads to endless recursion. If you don't play the sound too many times you will probably not notice it, but this structure is plain wrong. If run enough times, the stack will overflow and your program will crash.
A while loop is a better choice:

Code:

---

while(Choise = 'y')
{
  PlaySound();
}

---

Or somethinglike that.

Also, in your post before this one, you're using goto to jump out of a function. This is also wrong, and will most liely lead to the same error as above.

The third thing I could comment on is your usage of global variables. I'm not saying that they are wrong. I use globals too sometimes, like when storing game stats. However, I'd recommend that you make a structure like this:

Code:

---

typedef struct
{
  int Health;
  int Xpos;
  int Ypos;
}ENEMY;

---

Then defining your objects like this:

Code:

---

ENEMY Zombie;
ENEMY Lich;
ENEMY Mum;

---

To reduce the millions of global variables you have :eek:


I hope you take this as a helping gesture rather than a complaint of your program :D

actually magos, magos.... MAGos... MaGoS... that just sounds cool.. :D
I was using typedef structs, regular structs and all that for my Mech text game. I had 200 enemies defined with it, 5 allied mechs types, 30 mech allies, 40 non mech allies, aircraft, artillery, comm channels, 2 weapons, rocket launcher and chaingun, and they would be change outside or inside the battles, and that was the only weapon you had to fight with, until you change it. Duh...

Anyway, every thing stayed at ZERO, NULL, EINS - EINS, int STRUCTSTAT = 0.

Well anyway, i had to undo 400 structures, and im back to int. The only problem is, the battle isn't working yet, and i dont understand why, i even INDENTED it. I see no errors, nor does the compiler.

it will input, but then restart the loop. Its annoying, and im going off topic.

the goto jump:
A book i have said that it can jump into and out of voids, switch case, if, else if, while, you name it. A earlier program that used it i made worked fine. My first loop. then i got into while loops. For loops are still annoying me, as i get a lot of errors with them.

I'll try structs again on my recoding of Mech Abttle 2050, and i cant think of a good title for it........ ill work on that...

Ooh! I know! Magos the Mech! LOL.

Eh, are you high on something? :p
I didn't get a word of that reply...

What do you mean by "everything stayed at zero"? Structures are only a way of managing huge amounts of data. Apart from that they are the same as normal variables.

You know the notation to use them, right?:

Code:

---

typedef enum
{
  Enemy_Tank,
  Enemy_Missile,
  Enemy_Infantry
}ENEMYTYPE;

typedef struct
{
  ENEMYTYPE Type;
  int Xpos;
  int Ypos;
}ENEMY;

int main()
{
  ENEMY Enemy1;

  //Set the data
  Enemy1.Xpos = 12;
  Enemy1.Ypos = 27;
  Enemy1.Type = Enemy_Tank;

  //Get some data
  cout << "The X position is " << Enemy1.Xpos <<< endl;
 
  return 0;
}

---

Simple!

PS: Magos is a shortening of my 'real' name (what, do we have names too :D). I also believe it's a greek word for something. Dunno what though.

EDIT: Checked it out. Obviously it's plural for Wizards/Conjurers/Magicians :cool:

Well, this isn't your problem, but it is kind of odd.

Code:

---

case '2' : PlaySound("Battle.wav", NULL, SND_FILENAME | SND_ASYNC);
        musmenu(); //this one will get called
        break;
        musmenu(); //this one won't...EVER

---

I don't think it matters if you remove the second musmenu() or not, but it's not helping.

To answer your question, you can fix it with a while loop.

Code:

---

while(1)
{
        mainmen();
        cin >> menu;
        if (menu == '1')
                //play the game
        if (menu == '2')
        {
                //music menu
        }
        if (menu == '3')
        {
                //quit the game
        }
}

---

It will help a lot if you move all of your game playing code to another function. Having it all in main() is pretty messy.

Magos: I thought the name was latin for Magician. Hehe. As for a Abr. of you whole name? I dont think i ever seen a name begining with Mago, 'cept magot, which i REEEEAAAALLLLYYYYY doubt thats your real name. But if it is, well, its the 21st century. :D

Am i high? Whyy do yoi asssk? Oooff coousre iiim noot hiiiiggh. eh heh heh, he a hehehe hahahahHEHEHEHEHHAHAHEHAHEHAHE!
LOL

Im recoding the game in this way

Code:

---

/player mech
typedef struct
{
char name[size];
int y;
int x;
int gun;
int hp;
int maxhp;
int armor;
int ammo1;
int ammo2;
int ammo3;
int maxammo1;
int maxammo2;
int maxammo3;
} player;

player user =
{
 {'Dark Cobra', 0, 0, 1, 450, 450, 30, 500, 10, 30, 500, 10, 30,}
}

//friend mechs
typedef struct
{
 char name[size];
 int gun;
 int hp;
 int maxhp;
 int armor;
 int y;
 int x;
} fmech;

fmech cobra[1] =
{
 {'Cobra', 1, 400, 400, 30, 0, 1}
}

---

and getting a buttload of errors. I will give the typedef enum a try... BTW, do mi need to include any special headers or Libs for that?

Im asking because i think might have a typedef undefined error...

Pianorain: A while loop will fix it? A WHILE LOOP????? Shoot, here i was, thinking i HAD a while loop on there... oh, and don't take my 'screamin' wrong..... not trying to be rude......

Fordy: Thanks

No, Using Enumerations won't require you to include any special
headers or library's.

i meant typedef

Quote:

---

Originally posted by Blizzarddog
and getting a buttload of errors. I will give the typedef enum a try... BTW, do mi need to include any special headers or Libs for that?

---

;)

No, you don't need them for Typedef's as well.

okay