Stack errors using templates

Hello, I am attempting to create a stack.h file using templates and a linklist in order to hold the desrired values I "push" into the stack, but unfortunately it does not like the way I am attempting the problem... any help here would be greatly appreciated:


CONTENTS OF DRIVER FILE:

Code:

---


#include <iostream>
#include "stack2.h"
using namespace std;

int main() {
        stack<int> myStack;
        myStack.push(7);
        myStack.push(3);
        myStack.push(3);
        myStack.push(1);
       
        while (myStack.count()) {
                cout<<myStack.pop() << endl;
        }
       
        return 0;
}

---

CONTENTS OF STACK.H FILE

Code:

---

#include <iostream.h>


template <typename T>
struct item {
        T value;
        item* ptr;
};

template <class T> class stack {
public:
        private:
                int counter;
                item* start;
       
        public:
                stack();
               
                int count();
               
                void push(T newtop);
               
                T pop();
                       
};

template <typename T>

        stack<T>::stack(){
                counter = 0;
                start = NULL;
        }

template <typename T>

        int stack<T>::count(){
                return counter;
        }


template <typename T>

void stack<T>::push(T newtop){
                        item* temp = new item;
                       
                        temp->value = newtop;  //you may have to fill in other values.
                        temp->ptr = start;
                       
                        start = temp;
                       
                        counter++;
                }


template <typename T>

T stack<T>::pop(){

                        if (counter > 0){
                                counter--;
                                T popValue = start->value;
                                start = start->ptr;

                                return popValue;       
                        }
                       
                        else{
                                return T(); //or whatever you want your error value to be
                        }
                       
                }

---

I´m not sure about this but I don´t think you can mix

Code:

---

template <class T>

---

and later use

Code:

---

template <typename T>

---

I think it depend on the compiler you are using.

What kind of error do you get, compile-error or is the logic wrong. If you could be more specific whatis wrong it would certenly be easier to help.

P.S. Have you made a search here??? I sure that a complete (code)version of a stack can be found here.

Ahh here it is http://cboard.cprogramming.com/showt...=Stack+Prelude

If you're using a template type you've got to specify the type

item* ptr;

item is a template. You need the type; something like -

item<T>* ptr;

Do this for other items. Add some memory de-allocation and remove the redundant <iostream.h> and you should be away.

SHe uses an array-based one, however. I need a linklist one

Joe, what do you mean?

Wow, it worked. Changing all my items to item<T>s it worked. How did this work!? Ahh!

Code:

---


template <typename T>
struct item {
        T value;
        item<T>* ptr;
};

template <class T> class stack {
public:
        private:
                int counter;
                item<T>* start;
       
        public:
                stack();
                int count();
               
                void push(T newtop);
               
                T pop();
                       
};

template <typename T>

        stack<T>::stack(){
                counter = 0;
                start = NULL;
        }

template <typename T>

        int stack<T>::count(){
                return counter;
        }


template <typename T>

void stack<T>::push(T newtop){
                        item<T>* temp = new item<T>;
                       
                        temp->value = newtop;  //you may have to fill in other values.
                        temp->ptr = start;
                       
                        start = temp;
                       
                        counter++;
                }


template <typename T>

T stack<T>::pop(){

                        if (counter > 0){
                                counter--;
                                T popValue = start->value;
                                start = start->ptr;

                                return popValue;       
                        }
                       
                        else{
                                return T(); //or whatever you want your error value to be
                        }
                       
                }

---

The finished stack code. How can this be written better without all the template <typename t> stuff everywhere, etc? I must optimize this