Self-made functions: Opinion

Ok, today we learned something new in CS2 (BOUT TIME), she refered to them as self-made functions, seems like a correct term. I am going to type in the program we made, i just want opinions as to what could/should have been done different, if anything. Its a really basic example but we know how she tends to give bad learnings so... Thanks.

Code:

---

#include <iostream.h>

int get_data();

int main()
{
  int value;

  value = get_data();

  cout<<value<<endl;

  return 0;
}

int get_data()
{
  int data;

  cout<<"Enter a number: ";

  cin>>data;

  return data;
}

---

*shakes head in confusion*

it doesnt look any different than a normal function to me. what is it doing different?

I assume by "self made" this means you made it instead of including it from a library such as C runtime. it's not such an important term.

I guess you're going through the really-basic-stuff-for-non-programmers now.

its really lame, were just adding another block and calling it in : /

This is why i just clicked "buy" on amazon for 926 pages of "C how to program 2nd edition" by whats his faces

I absolutely love self-made functions. I think they are very useful. I especially like throwing a bunch of them into a library and just calling that whenever I need them. I have "myinput.h" which has the following functions: GetInt, GetDouble, GetChar, GetApstring. I use that library all the time. I've also written libraries for english and metric conversions and the area and volume of several shapes. Using functions in my own libraries saves me a lot of time. It's also a good way to encapsulate data. Self-made functions are just good all around. :)

Well, other than the use of .h header being depracated, its looks alright. You don't have any error handling to guard cin against going into a fail state (see what happens if you type "seven" in when it asks for a number) but thats kind of advanced if you are just getting to writing functions.

I really had higher expectations when I opened this thread. :D

See here: http://www.parashift.com/c++-faq-lit....html#faq-15.2 It's very easy to guard against invalid input.

Quote:

---

Originally posted by joshdick
I absolutely love self-made functions. I think they are very useful. I especially like throwing a bunch of them into a library and just calling that whenever I need them. I have "myinput.h" which has the following functions: GetInt, GetDouble, GetChar, GetApstring. I use that library all the time. I've also written libraries for english and metric conversions and the area and volume of several shapes. Using functions in my own libraries saves me a lot of time. It's also a good way to encapsulate data. Self-made functions are just good all around. :)

---

Thats what i want to do, but need to learn about making header files, because i don't know that yet.

As far as error protecting, in my personal applications i would have a protection, but for in-class apps i don't becuz she tends to complain if i add my own things *shrug*.