contents of vector <T>

Greetings,

If you input these values 99 33 44 88 22 11 55 66 77 -1 what should you get?
From what I read about push_back is that it should push back the very last number right? Thats not what I get though, can someone please explain why? Am i missing something in my code??

Code:

---


#include <iostream>        //cin, cout, <<, >.
#include <vector>        //for vector
using namespace std;

#define nl '/n'

vector<int> number,
                v(10, 20),
                w(10);

int num;

int main()
{
        for (;;)        //loops forever
        {
                cin >> num;        //input number
                if (num < 0) break;        //if number is less than 0 break
                number.push_back(num);        //push_back a number
                cout << num << nl;        //output the number with the push_back
        }
        return 0;
}

---

:(

A few things right away..

Code:

---

#define nl '\n'

---

This is probably a bad idea, it really isn't that much to type '\n', and with such a short string for the substituition you risk breaking things.

Code:

---


for (;;) //loops forever
{
//Stuff
if (num < 0) break;//if number is less than 0 break
// Stuff
}

---

This is another bad idea... Why not use a while construct to accomplish this? Exiting from the middle of a loop is not only inelegant, but can confuse readers of your code, and is technically not consistant with the OO paradigm.

Code:

---

vector<int> number,
 v(10, 20),
 w(10);

int num;

---

These almost certainly do not need to be global variables. You should not allow yourself to get into the habit of making variables global in this type of situation. It will pay off greatly later on.

Also, it should output the number you inputted, after pushing it onto the vector, no?

What is it that you are trying to do, exactly?

Quote:

---

What is it that you are trying to do, exactly?

---

After changing the suggestions you made, my problem finally matches that of the book. Thanks again Imperito!

I was trying to get this to output those numbers but because the book declared then globablly that as you said caused problems. Thanks for the help!
;)

Your book used globals in a context like that?

Which book?

C++, an intro to computing by joel adams, sandford leestma and larry nyhoff.

Thanks again!
;)