anyone could look at this code for me??

test.c

Code:

---

#include <stdio.h>

int main(int argc, char *argv[])
{
    char *file[256];
    int line = 0;

    if(argc == 2) {
        FILE *fp;
        fp = fopen(argv[1],"r");
        while(fgets(file[line],81,fp) != NULL){
            printf("file[%d] is [%s]\n",line,file[line]);
            line++;
        }
        fclose(fp);
        return 0;
    } else {
        printf("ERROR\n");
        return 1;
    }
}

---

If I run it after compile,
>./a.out result.txt
file[0] is [2]
file[1] is [korea]
file[2] is [united States]
file[3] is [3,2]
above this is supposed to be result, but it said
segmentation fault after print out file[0] is [2]

result.txt is like this..
2
korea
united States
3,2

plz ..help..me..


[code][/code]tagged by Salem

Yo, I love to help u out, but I am also facing the same problem. Our code is very similar and I am sure that we are doing the same question. I will let u know when I discover the problem. Hang in there dude! Peace!

The problem is you want to store all lines from file in memory. Don't do that. Take one buffer and reuse this buffer for each line you read:

Code:

---

int line = 0;
char buf[BUFSIZ];
...
while(fgets(buf, BUFSIZ, fp) != NULL)
{
  printf("line[%d] is [%s]\n", line, buf);
  line++;
}
...

---

And don't forget to check the return value of fopen!

Hope this helps.

And your result will be:

Code:

---

line[0] is [2
]
line[1] is [korea
]
line[2] is [united States
]
line[3] is [3,2
]

---

because fgets also reads the newline character...