a weird problem with my code on writing & reading from file

this program of mine is supposed to read input from the user via the keyboard. each sentence he types in, or each time he press enter, the sentence is stored into a node in the list.

Code:

---

struct list{
        char text[255];
        int num;
        struct list *next;
        struct list *prior;
} list_entry;

//code on reading inputing

printf("Enter file content (CTRL-Z to end) : \n");
        while(gets(s)){
                info = (struct list *)malloc(sizeof(list_entry));
                if(!info){
                        printf("\nnot enough memory");
                        return;
                }
                strcpy(info->text,s);
                printf("info : %s",info);
                listStore(info, &start, &last);
        }
        printf("\n");
            store();

//code on writing to a file
      if((cfPtr=fopen(file,"w"))==NULL)
        printf("File could not be opened\n");
      else{
        while(info){
                printf("info2:%s",info->text);
                fwrite(info,sizeof(struct list),1,cfPtr);
                fflush(cfPtr);
                info = info->next;
        }
        fclose(cfPtr);
        info = start;
        clearList(&info);
        printf("File saved\n");
        }

//methods
void listStore(struct list *i, struct list **start, struct list **last)
{
        struct list *p;

        p = *last;

        if(*last ==NULL){                //first element in list
                i->next = NULL;
                i->prior = NULL;
                i->num = 0;
                *last = i;
                *start = i;
                return;
        }
        else{
                p->next = i;
                i->next = NULL;
                i->prior = p;
                i->num = (p->num)+1;
                *last = i;
        }

}

//to view

clearList(&info);
printf("\nLoading File...\n");
        system("cls");
        int count=0;
        while(!feof(fp)){
                info = (struct list *)malloc(sizeof(list_entry));
                if(!info){
                        printf("\nnot enough memory");
                                return 0;
                }
                if(1!=fread(info, sizeof(struct list), 1, fp)break;
                        printf("info3 :%s",info);
                        listStore(info,&start,&last);
                        num++;
                        count++;
        }
        fclose(fp);

---

everything works fine, except one THING.....every time the user types more than 11 lines, that is 11 sentences, pressing ENTER 11 times, the lines after the 10 line doesn't show at ALL! What's weird is that the lines after 10 lines do get stored. when i open it, i find it there. But the >10 lines are separated by a huge GAP (pure spaces only) which i think could had caused this problem.

CAn anyone help me pls???
[code][/code]tagged by Salem

I doubt the CodeTagerator, Hammer, or anyone else is out at this hour.

Could you _please_ use code tags?

*ignoring thread due to lack of code tags* haha you didn't see that one coming¿

1. make sure the start and last pointers really are NULL when you have an empty list

Use a debug function like this to make sure your linked list has all the correct pointers.

Code:

---

void dump_list ( struct list *start struct list *last ) {
  printf( "start=%p, last=%p\n", start, last );
  while ( start ) {
    printf( "prior=%p, this=%p, next=%p\n", start->prior, start, start->next );
    start = start->next;
  }
}

---

You can add printing of num and the first few chars of text if you want

> while(gets(s)){
Use fgets, it's much safer
Search the board for how to remove the newline at the end of an fgets() buffer if thats really important to you

> if(1!=fread(info, sizeof(struct list), 1, fp)break;
This doesn't even compile - missing )

> info = (struct list *)malloc(sizeof(list_entry));
The cast is not necessary in ANSI-C
The cast does however mask a warning if you fail to include stdlib.h, which may in turn lead to incorrect code.

> if((cfPtr=fopen(file,"w"))==NULL)
You're writing binary data (a struct using fwrite), so this should be
if((cfPtr=fopen(file,"wb"))==NULL)

Ditto "rb" on the open for reading

> fflush(cfPtr);
The file will be flushed when you close it anyway, so doing this each time seems overkill to me.

thanks a million salem

Hmm found this old thread, and this code is more or less what I need for what I want to make(with some adaptation here and there)
But I can't seem to find out what types the variables should be, could someone help me out please?

Please dont bump old threads. Read the guidlines before posting.

http://cboard.cprogramming.com/annou...ouncementid=51

If you have a question, please start a new thread and link to this one.