empty control statement (?)

I have a program. Here is the code that is giving me a warning:

Code:

---

void Sensor::SetSensorState(char *cState) {
        char On[] = "On";
        char Off[] = "Off";
       
        if(!strcmp(cState, On));
                strncpy(State, cState, 50);*
        if(!strcmp(cState, Off));
                strncpy(State, cState, 50);*
       
}

---

On the lines with the '*' I am getting a warning that says :

warning C4390: ';' : empty controlled statement found; is this the intent?

as I said this is a warning, not an error, so my program compiles and runs (up to this point).
what should I change about the code above?

[edit]
nevermind....duh...that was a lame mistake...

Remove the ';' after the if.

are you making fun of me?

No he isn't, if statements dont have ;'s at the end like other control structures.

while( condition ) //no ;
{

}

for( initialise; end condition; increment ) //no ;
{

}

if( condition ) //no ;
{

}

It is perfect legally to put ";" after if, thenyou got a warning.

what are you trying to do though?

what do I know?

Quote:

---

Originally posted by Unregistered
It is perfect legally to put ";" after if, thenyou got a warning.

what are you trying to do though?

what do I know?

---

Of course its perfectly legal, but just because something is legal doesn't mean that is always what we want. For instance these two statements are the same and do nothing.

Code:

---

// Statement 1
if( bValue == true );

// Statement 2
if( bValue == true )
  ;

---

Both do nothing because there are no brackets, it will only execute the first command after the if statement, which is a nothing, just the semi-colon. That's why if you do this on a for loop it just runs the entire loop without going inside of it.