write input from user in binary file

I'm trying to take input from user and write it into binary file. This is my code, it runs smoothly but when I try to read the file in another (shows that its NULL) so I'm not sure why the data is not being saved into the file.

Code:

---

#include <stdio.h>
#include <stdlib.h>


int length=2, width=2;


struct LandData
{
    int height;
};


struct LandData* WritingData()
{
    FILE *fptr;
    struct LandData *arr = (struct LandData*)malloc(length* width* sizeof(struct LandData));


    if ((fptr = fopen("data.bin","wb")) == NULL){
      printf("Error! opening file");
        exit(1);
    }


    for (int i = 0; i < length ; i++){
        for (int j = 0; j < width; j++){
            printf("choose height: ");
            scanf("%d", &(arr + i*width + j)->height);
            fwrite(arr, sizeof(struct LandData), 1, fptr);
        }
    }


    fclose(fptr);
    return(arr);
}


int main()
{
    struct LandData *arr =WritingData();
    free(arr);
    return 0;
}

---

You are writing the first element of the array over and over.

By the way there doesn't really seem to be a need for the array of your structure, because you are only writing a single instance, so just use a single instance.

Something more like:

Code:

---



void WritingData(FILE* outputFile, int numRecords)
{
    LandData temp;
    for(int i = 0; i < numRecords; i++)
    {
        printf("choose height: ");
        scanf("%d", &temp.height);
        printf("Choose type: ");
        scanf("%d", &temp.type);
        fwrite(&temp, sizeof(struct LandData), 1, outputFile);
    }
}

---

Also there is no need to keep opening new topics for existing problems.

Quote:

---

Originally Posted by jimblumberg

By the way there doesn't really seem to be a need for the array of your structure, because you are only writing a single instance, so just use a single instance.

---

yes I know but I have to use it cause its a requirement on my project that's why I'm confused

Quote:

---

yes I know but I have to use it cause its a requirement on my project that's why I'm confused

---

Please show the text of your project requirements.

What exactly don't you understand?

It seems to me that you're confusing yourself by using dynamic memory, so I'd recommend you start with the simpler static allocated array. Define the array in main() and pass the array and the size of the array to your functions as required.

I'd start with something more like:

Code:

---


#include <stdio.h>
#include <stdlib.h>

#define ARRAY_SIZE 3

typedef struct LandData
{
    int type;
    int height;
} LandData;

void getData(LandData data[], int arraySize);


int main()
{
    LandData data[ARRAY_SIZE];
    getData(data, ARRAY_SIZE);
}

void getData(LandData data[], int arraySize)
{
    for(int i = 0; i < arraySize; i++)
    {
        printf("choose height: ");
        scanf("%d", &data[i].height);
        printf("Choose type: ");
        scanf("%d", &data[i].type);
    }
}

---

I'll leave the write/read/display functions for you to implement.