using memcpy to fill a struct

I try to fill the parent structure with a memcpy. I work on embedded system (with Contiki OS). So I try to avoid using a malloc because I read that it is not recommended.

I test the code on my computer and I get the error Segmentation fault (core dumped).

On Contiki there are no errors but the values after the fill call are not the expected ones.

I have no idea why this error occurs and I don't know another way to do this.

Here is an example of the code that looks like what I'm trying to do:

Code:

---

typedef struct child{
    uint8_t age;
    uint16_t size;
}child_t;


typedef struct parent{
    child_t *child1;
    child_t *child2;
    bool has_child;
}parent_t;


void fill(parent_t *dest){
    parent_t parent;
    child_t child;
   
    uint8_t age=24;
    uint16_t size=180;
   
    child.age=age;
    child.size=size;
   
    printf("h2\n");
    memcpy(parent.child1, &child, sizeof(child_t));//Segmentation fault (core dumped)
    printf("h3\n");


    memcpy(dest, &parent, sizeof(parent_t);
}


int main(int argc, char *argv[]){


    parent_t parent;
    fill(&parent);
    return 0;
}

---

Well part of the reason for the current problem is that memcpy() expects "destination" to be passed by "reference" not by "value". However where are you allocating memory for those pointers in your parent_t?

On top of that, it appears that you've copied your code incorrectly here, because I can see a missing ) on line 29.

Quote:

---

Originally Posted by leGrandNono

I try to fill the parent structure with a memcpy. I work on embedded system (with Contiki OS). So I try to avoid using a malloc because I read that it is not recommended.

---

If parent_t contains a pointer to a child_t rather than an instance of a child_t, then you have to create the memory space for the child_t somehow. That can be by using malloc, or if you don't want to use malloc() you could have a global array of child_t's you allocate from using your own function.

But you can't just leave the pointer dangling. It must either be NULL or point to valid memory.

Ask yourself what do the child_t pointers in parent_t point to when you try to copy data to it?

Thanks for your answers ;)


I replaced the pointers in parent_t with values and the code works.


If I understand correctly, it didn't work because no memory was allocated for the child_t pointers ?

That is correct