Prototype for '' does not match any in class error

Hi,

New to c++ and have an error that I cannot resolve. Thinking I've just made a very basic mistake and cannot see it.

The error is "prototype for 'void Menu::newItem(std::string, std::string, int)' does not match any in class 'Menu'"

I am certain they match, all similar stack overflow questions were trying to pass too many variables or had different return types which is why this seems so strange.

menu.h

Code:

---

#ifndef MENU_H
#define MENU_H


#include <string>
using std::string;
#include <iostream>
#include "item.h"
//#define MAXLEN 20


class Menu {
private:
        string _fName;
        string _mName;
        Item _db[20];
        int _nElems;
public:
        Menu(string mName) : _fName(""), _mName(mName), _nElems(0) {  };
     
        void newItem(string category, string description, int price);
       
        void display();
       
};
#endif

---

menu.cpp

Code:

---

#include "menu.h"
#include <string>
using std::string;
#include <iostream>
using std::cout;
using std::endl;




void Menu::newItem(string category, string description, int price){
        _db[_nElems] = Item(category, description, price);
        _nElems++;
}


void Menu::display(){
        string div =
        "+--+-------+---------------------------------+-----+\n";
        cout << div <<
        "|No|Cat.  |Description                      |Price|\n" << div;
        for(int i = 0; i < _nElems; i++) {
                _db[i].display(i);
        }
        cout << div;
}

---

Any help would be greatly appreciated!

You're right: they match.

It may make no difference, but I suggest that you remove the using declaration from the header file: fully qualify std::string there instead. In the source file, move the using declaration to after the last header inclusion. The reason is that using declarations at file scope in a header can change the meaning of code in the files that include the header, and using declarations before a header can change the meaning of code in the included header.

Other things to tell us: which line does the error reference? What's in item.h?

Unfortunately your suggestions made no difference.

Quote:

---

Originally Posted by laserlight

Other things to tell us: which line does the error reference? What's in item.h?

---

in menu.cpp:

Code:

---

void Menu::newItem(std::string category, std::string description, int price){

---

and in menu.h ([ERROR] candidate is: void Menu::newItem()):

Code:

---

        void newItem(std::string category, std::string description, int price);

---

Which compiler/IDE are you using?

Quote:

---

Originally Posted by Salem

Which compiler/IDE are you using?

---

Dev C++

Are you talking about the archaic "Bloodshed" Dev-C++ or the somewhat up to date "Orwell" Dev-C++.

Because the bloodshed one is about 20 years out of date.

Dev-C++ download | SourceForge.net

I'm embarrassed to say the bloodshed one. It has been pushed quite heavily on my course. Will see if the code compiles on another IDE now.

EDIT: I'm actually using the version linked above.

You're using the Orwell one and it doesn't work?

I commented out Item (not that it should matter for the purpose of the exercise), and it compiles just fine here

Code:

---

$ cat menu.h
#ifndef MENU_H
#define MENU_H
 
 
#include <string>
using std::string;
#include <iostream>
//#include "item.h"
//#define MAXLEN 20
 
 
class Menu {
private:
        string _fName;
        string _mName;
        //Item _db[20];
        int _nElems;
public:
        Menu(string mName) : _fName(""), _mName(mName), _nElems(0) {  };
       
        void newItem(string category, string description, int price);
       
        void display();
       
};
#endif
$ cat menu.cpp
#include "menu.h"
#include <string>
using std::string;
#include <iostream>
using std::cout;
using std::endl;
 
 
 
 
void Menu::newItem(string category, string description, int price){
        //_db[_nElems] = Item(category, description, price);
        _nElems++;
}
 
 
void Menu::display(){
        string div =
        "+--+-------+---------------------------------+-----+\n";
        cout << div <<
        "|No|Cat.  |Description                      |Price|\n" << div;
        for(int i = 0; i < _nElems; i++) {
                //_db[i].display(i);
        }
        cout << div;
}
$ g++ -c menu.cpp

---

Quote:

---

Originally Posted by Salem

You're using the Orwell one and it doesn't work?

I commented out Item (not that it should matter for the purpose of the exercise), and it compiles just fine here

---

Yes, definitely using Orwell version 5.11.

I also managed to get the code to compile today by moving the menu constructor out of the header file. Not sure how this error occurred and I'm not sure why it has gone away.

If I had to guess I'd say the error occurred as I updated the newItem function and the compiler still expected to see the old parameters? Still, I don't think this explains why it disappeared today once I moved the constructor.

Regardless thanks for the help!