getting garbage values in the ouput i guess code is correct !!!

Write a C function with 1-D array and its size as arguments, which is called by main() function and remove the duplicate elements from an array also display the resultant array? ( this is the question )

Code:

---

#include <stdio.h>

#define MAX_SIZE 100
int duplicate_elements(int arr[], int n);
int main()
{
    int arr[MAX_SIZE];
    int n;         
    int i, j, k;   
    printf("Enter size of the array : ");
    scanf("%d", &n);
    printf("Enter elements for the array : ");
    for(i=0; i<n; i++)
    {
        scanf("%d", &arr[i]);
    }
  duplicate_elements(arr,n);
    printf("\nArray elements after deleting duplicates is  : ");
    for(i=0; i<n; i++)
    {
    printf("%d\t", arr[i]);
    }

    return 0;
}
int duplicate_elements(int arr[], int n)
{
        int i,k,j;
  for(i=0; i<n; i++)
    {
        for(j=i+1; j<n; j++)
        {
            if(arr[i] == arr[j])
            {
                for(k=j; k<n; k++)
                {
                    arr[k] = arr[k + 1];
                }
                n--;

             
                j--;
            }
        }
   
        }

        }

---

You need to return the new length of the array, after you've removed the duplicates.

Quote:

---

Originally Posted by Salem

You need to return the new length of the array, after you've removed the duplicates.

---

i did not get you can you elaborate please ?? otherwise please do mention the line which needs to be included !!!

Quote:

---

Originally Posted by Punju

i did not get you can you elaborate please

---

You start off with n elements as the size of the array. If there are any duplicates, after removing them, the size of the array would surely be less than n, but you did not update the value of n, hence you get those "garbage values".

Quote:

---

Originally Posted by Punju

please do mention the line which needs to be included

---

It looks like you declared duplicate_elements as having a return type, but you did not actually return a value. You might as well return the new effective size of the array so that you can update n in main.

By the way, duplicate_elements doesn't sound like a good name for the function: it sounds like you're duplicating elements rather than removing duplicates. A name like remove_duplicate_elements or even more simply remove_duplicates would be better.