cygwin -> unix , my code not working properly ;(

Hi,

I recently make this code to concate 2 string...i am using cygwin at home...and this code working as i expected :

Code:

---

char *str_concat( char *string1, char *string2 )
{
               
        char *string3;
        char *concated_string;
               
        int len1, len2;
           
              /* edited */       

        string3 = '\0';

        return concated_string;

}

---

so when i put for example str_concat( mike, mike ) it will return "mikemike" (without the quote)

however when try to run it at school, in unix machine it doesn't work ( I've change the file format using dos2unix ). if i put str_concat( mike, mike ) it will return "mikemikelv55/k" (without quote) instead of "mikemike" -> and somethin weird, it not always giving addition "lv55/k" sometimes it gives like "xxlv55/k/x" in the back...always in the back...

this is mess up the whole program of mine ;( it is due on monday..and only becoz of one small part not working, the whole program not gonna work )

pls help

Ferdinand
:confused:

> string3 = '\0';

Should be
*string3 = '\0';

Oh, and you don't (or perhaps shouldn't) cast the result of malloc.

Thanks Salem!!!

It did workingggg, omg i dont believe it...

thank you very much :)

o yeah about the malloc... do u mean that I dont need to allocated the memory?


sincerely,

ferdinand

> do u mean that I dont need to allocated the memory
Yes you DO need to allocate the memory

But it's better to write this in ANSI-C
string3 = malloc( len1 + len2 + 1 );

If you've included stdlib.h, then the normal C rules for converting void* into the appropriate type will take over for you

If you haven't included stdlib.h, you will get a warning (a warning which the cast will suppress)

oh okie...
i dont know about that =)

I think thread closed now.