Okay this one i cannot figure out, it seems fine to me

This is basically a cheat code to use for testing my rpg game as I build it. It's about 1/4 the way done and i just decided to do this and it will not work. Basically it is comparing what you enter to see if it is megan, if so it should assign the values to your stats and go to the main menu. Well it doesn't do that, if I type in megan, it will not give me those stats. Does anyone know what i did? Thanks.

Code:

---

char secret[80] = "megan\0";
      cout<<"+--------------------+\n";
      cout<<"|What is your name?  |\n";
      cout<<"+--------------------+\n\n";
      cout<<"\tPlease enter your name:  ";
      gets(stat.name);
     
      if(strcmp(stat.name, secret))
      {
          strcpy(stat.classname, "Humanoid");
          stat.classn = 9;
          stat.maxhp = 100;
          stat.hp = stat.maxhp;
          stat.maxmp = 100;
          stat.mp = stat.maxmp;
          stat.attack = 100;
          stat.defense = 100;
          menu();
      }

---

:confused: Seems fine to me too... Posibbly an earlier error? Although I do doubt it.

try changing

Code:

---

if(strcmp(stat.name, secret))

---

to

Code:

---

if(strcmp(stat.name, secret) == 0)

---

< 0 string1 less than string2
0 string1 identical to string2
> 0 string1 greater than string2

>char secret[80] = "megan\0";
You don't need to place the nul at the end, the compiler will do it for you.

>gets(stat.name);
Very unsafe, I highly recommend not using gets.

>if(strcmp(stat.name, secret))
strcmp returns 0 if the two strings are equal, this notation tests if the return value is != 0. You can use one of two notations to do this:
if ( strcmp ( stat.name, secret ) == 0)
if ( !strcmp ( stat.name, secret ) )

-Prelude

Quote:

---

>char secret[80] = "megan\0";
You don't need to place the nul at the end, the compiler will do it for you.

---

:) nice one..... BTW 80 for megan isn't needed.

Quote:

---

You can use one of two notations to do this:
if ( strcmp ( stat.name, secret ) == 0)
if ( !strcmp ( stat.name, secret ) )

---

Prelude, which one do you prefer?

All right thanks it worked. As far as the gets(), what is a "safer" way to do that and still let the user enter spaces with cin>>" bla bla bla " would be invalid
but with gets it would be. is there something else that will let me keep the whitespaces?

>Prelude, which one do you prefer?
I prefer the first since Lint doesn't give me a warning on it.

>As far as the gets(), what is a "safer" way to do that and still let the user enter spaces
Use getline:

Code:

---

cin.getline ( stat.name, sizeof stat.name );

---

-Prelude

LINT! :D
I forgot to download that while saving the man pages site url, thanks for jaring my memory. :)

Code:

---

char secret[81] = {"megan"};
      cout<<"+--------------------+\n";
      cout<<"|What is your name?  |\n";
      cout<<"+--------------------+\n\n";
      cout<<"\tPlease enter your name:  ";
      cin.getline(stat.name,80);
     
      if(strcmp(stat.name, secret) == 0)
      {
          strcpy(stat.classname, "Humanoid");
          stat.classn = 9;
          stat.maxhp = 100;
          stat.hp = stat.maxhp;
          stat.maxmp = 100;
          stat.mp = stat.maxmp;
          stat.attack = 100;
          stat.defense = 100;
          menu();
      }

---

Some people should answer the whole lot not just 1 or 2 things.
that should fix it cin.getline (stat.name,80,'\n') 80 is how many charactes allowed to be entered and '\n' is when enter is pressed it gets all of the characters

kinght543,
> char secret[81] = {"megan"};
Why do you need 81 for a 6 character string?

>Some people should answer the whole lot not just 1 or 2 things.
It seems to me that we have.

>char secret[81] = {"megan"};
This is wasteful of space and you really don't need the curly braces.

Code:

---

char *secret = "megan";

---

This will work a bit better and protect the secret name from being changed.

-Prelude