Inserting a node at the tail of singly linked list

Hello,

Below is my half-witted attempt at inserting a node at the tail of a singly linked list. Assumptions are that the list is not sorted. This should probably be simple and easy to do but my lack of seriousness and focus is probably the problem. It probably makes me look a bit silly but you are better of looking silly while being smart than looking smart while being silly.

Code:

---


/*

* list structure

*
* SinglyLinkedListNode {
*    int data;
*    SinglyLinkedListNode* next;
* };
*
*/

SinglyLinkedListNode* insertNodeAtTail(SinglyLinkedListNode* head, int data) {

    SinglyLinkedListNode *new_node = (SinglyLinkedListNode*)malloc(sizeof(SinglyLinkedListNode));

    new_node->data = data;

    SinglyLinkedListNode *temp = head->next;

    while(temp->next != NULL)
    {
          temp = temp->next;
    }

    temp->next = new_node;

  return head;
}



---

Is this heading in the right direction? Is the algorithm correct? Why is it segmentation faulting?
This is preparation for some upcoding coding challenge which might lead me to an interview for a permanent or probably semi-permanent job. This particular challenge was picked off on hackerrank.

You need to make sure your new_node->next is NULL.

> SinglyLinkedListNode *new_node = (SinglyLinkedListNode*)malloc(sizeof(SinglyLinkedL istNode));
If this really is C++, then you should be using new, not malloc.

Quote:

---

Originally Posted by Salem

You need to make sure your new_node->next is NULL.

> SinglyLinkedListNode *new_node = (SinglyLinkedListNode*)malloc(sizeof(SinglyLinkedL istNode));
If this really is C++, then you should be using new, not malloc.

---

Thanks. fixed those but there still is the segfault. It looks like my lack of knowledge about the rest of the existing code might be what is getting in my way.

Quote:

---

Originally Posted by ghoul

Thanks. fixed those but there still is the segfault. It looks like my lack of knowledge about the rest of the existing code might be what is getting in my way.

---

Is this right?

Code:

---

SinglyLinkedListNode *temp = head->next;

---

What's the purpose of this - homework?
C++ comes with std::list and std::forward_list, why not using these?
Are you aware that lists have a poor performance and should rarely be used?

> Thanks. fixed those but there still is the segfault.
At some point, you have to recognise that the current list is empty (head == NULL), and just return the freshly created node as being the sole entry in the list.

Quote:

---

Originally Posted by thmm

What's the purpose of this - homework?

---

No, but, yes, it is more or less like homework to prepare for an interview.

Quote:

---

Originally Posted by thmm

C++ comes with std::list and std::forward_list, why not using these?

Are you aware that lists have a poor performance and should rarely be used?

---

So we have a new std::forward_list on top of the good old std::list. std::list was the best they had during my hey days. And, yes, a lot of research has gone into data structures and algorithms, there is little chance that you will be forced to come up with your own data structures and algorithms while dealing with a mainstream topic like sorting, searching etc

Quote:

---

Originally Posted by flp1969

Is this right?

Code:

---

SinglyLinkedListNode *temp = head->next;

---

---

No idea, snuck it out as it was sort of introducing a bug in the algorithm.

Quote:

---

Originally Posted by Salem

> Thanks. fixed those but there still is the segfault.
At some point, you have to recognise that the current list is empty (head == NULL), and just return the freshly created node as being the sole entry in the list.

---

Final code is below.

Thanks a lot for the company and help!

Code:

---

SinglyLinkedListNode* insertNodeAtTail(SinglyLinkedListNode* head, int data) {

    SinglyLinkedListNode *new_node = new SinglyLinkedListNode(data);

    new_node->data = data;

if (head == NULL)
    {
return new_node;
    }


    SinglyLinkedListNode *temp = head;

while(temp->next != NULL){
        temp = temp->next;
        }

    temp->next = new_node;

return head;
}



---