Counting Each Letter And Word In A File

Hi guys, i need to count a file's each letter and word, find how many times a letter/word appears in file. For example "sit lorem ipsum sit amed" word has 3 m s and 2 sit s.

Code:

---

'void say(FILE *file){
int i=0,n=0,j=0,karakterSayisi;
fseek(file,0,SEEK_END);
long fsize = ftell(file);
fseek(file,0,SEEK_SET);
char *karakterler;
char *karakter;
karakterler = (char *) malloc(fsize+1);
for(i;i<fsize;i++){
fscanf(file,"%c",&karakterler[i]);
}
while(!feof(file)){
karakter = fgetc(file);
karakterSayisi=0;


for(n;n<fsize-1;n++)
{
if(karakterler[n]==karakter)
{
karakterSayisi++;
}
}
printf("%c %d",*karakter,karakterSayisi);
}
}'

---

i tried this but output was "L0"... so can you help me about this

Indentation matters!

Code:

---

void say(FILE * file)
{
  int i = 0, n = 0, j = 0, karakterSayisi;
  fseek(file, 0, SEEK_END);
  long fsize = ftell(file);
  fseek(file, 0, SEEK_SET);
  char *karakterler;
  char *karakter;
  karakterler = (char *) malloc(fsize + 1);
  for (i; i < fsize; i++) {
    fscanf(file, "%c", &karakterler[i]);
  }
  while (!feof(file)) {
    karakter = fgetc(file);
    karakterSayisi = 0;
    for (n; n < fsize - 1; n++) {
      if (karakterler[n] == karakter) {
        karakterSayisi++;
      }
    }
    printf("%c %d", *karakter, karakterSayisi);
  }
}

---

> while (!feof(file))
I'm not sure what you're expecting this to do, after the previous loop has already read the whole file into memory.

You want to create a histogram of all characters in a file. Characters are 8 bit, so the easiest way to do this is to declare a 256-member array of ints and initialise them all to zero. Then go through the file, as you are doing, and for each use the character as an index into the array, and increment it. There's no need to store the file in memory.

To present the results, go thrugh the array you have crated. Ignore any entries that don't correspond to a printable character. Then print the index (as a character) and the value (as an integer).

Quote:

---

Originally Posted by Malcolm McLean

You want to create a histogram of all characters in a file. Characters are 8 bit, so the easiest way to do this is to declare a 256-member array of ints and initialise them all to zero. Then go through the file, as you are doing, and for each use the character as an index into the array, and increment it. There's no need to store the file in memory.

---

Aren't you forgetting about multibyte charsets?

Quote:

---

Originally Posted by flp1969

Aren't you forgetting about multibyte charsets?

---

He's reading the characters as bytes, so not supporting them.
If you've a big alphabet, there's no simple efficient way of counting each character in standard C. If you use C++, there are several predefined container types you can use which will do the job.