Could someone please point me in the right direction ~ basic structs and funtions

The exercise specifically asks for char parameters in the create_colour function for some reason.

I'm getting a compiler error along the lines of invalid conversion from 'char' to 'char' which i'm also unclear on.

Any help appreciated, thanks!

Code:

---

#include <stdio.h>


struct colour{
  char red;
  char green;
  char blue;


  };


struct colour create_colour(char r, char b, char g);
void printcolour(struct colour a);


int main(void)
{


struct colour red = create_colour(255, 0, 0);


//struct colour green =create_colour(0, 255, 0);
//struct colour blue =create_colour(0, 0, 255);
//struct colour yellow =create_colour(255, 255, 0);
//struct colour pink =create_colour(255, 0, 127);


printcolour(red);


return 0;
}


struct colour create_colour(char r, char b, char g)
{


  struct colour x;
  sprintf(x.red, r);
  sprintf(x.green, g);
  sprintf(x.blue, b);


  return x;


}


void printcolour(struct colour a)
{
  printf("RGB: %c, %c, %c\n", a.red, a.green, a.blue);
}

---

What is the exact error message? Copy and paste it here; don't type it out.

> sprintf(x.red, r);
Yeah, these aren't going to work.

Code:

---

struct colour create_colour(char r, char b, char g)
{
  struct colour x;
  x.red = r;
  x.green = g;
  x.blue = b;
  return x;
}

---

Thanks for the responses, so i've updated it and now it runs, however its not printing the values I thought I had saved into the red colour struct in the main function, instead it's just printing blanksAttachment 16084
updated code:

Code:

---

#include <stdio.h>


struct colour{
  char red;
  char green;
  char blue;


  };


struct colour create_colour(char r, char b, char g);
void printcolour(struct colour a);


int main(void)
{


struct colour red = create_colour(255, 0, 0);


//struct colour green =create_colour(0, 255, 0);
//struct colour blue =create_colour(0, 0, 255);
//struct colour yellow =create_colour(255, 255, 0);
//struct colour pink =create_colour(255, 0, 127);


printcolour(red);


return 0;
}


struct colour create_colour(char r, char b, char g)
{


  struct colour x;
  x.red = r;
  x.green = g;
  x.blue = b;


  return x;


}


void printcolour(struct colour a)
{
  printf("RGB: %c, %c, %c\n", a.red, a.green, a.blue);
}

---

Try printing them with %d instead of %c.

Now the output displays "RGB: -1, 0, 0" instead of the desired 255, 0, 0 :(

Whether char is signed or unsigned is implementation defined, and it looks like it is signed in this case, hence 255 is converted to -1. I would change to use unsigned char instead of char since that makes it explicit that you want unsigned char.

Wow we won! I read on google somewhere that the char would be unsigned by default but I guess not.. Thanks!