Printable View
I have a Binary Text File that contains details about a structure that I would like to make a program to read. I'm fairly new to C programming and can't see why the program I have made does not work. When ran the program just crashes. The compiler say there is 0 errors or warnings. I ahve attached both the binary file I'm trying to read and my program. Thank You any help you can give.
The compiler won't show the errors. What does the terminal say when you run the program? Have you considered trying to get a core dump?
No you have a binary file, not a text file.Quote:
I have a Binary Text File that contains details about a structure that I would like to make a program to read.
It appears that you probably haven't allocated the memory correctly. You need to allocate memory for the number of bytes, not the number of structures. You would be better off reading a struct person instead of a single character when trying to determine the number of structures.
The terminal crashes when the program is ran.Quote:
Originally Posted by catacombs
As stated in the post I am fairly new to C programming and don'tt have a clue how to do that.Quote:
Originally Posted by jimblumberg
Then just statically allocate the memory for your array and leave the dynamic allocation until you're more familiar with the language.Quote:
As stated in the post I am fairly new to C programming and don'tt have a clue how to do that.
> while(!feof(infile))
This will make your count of the number of bytes off by 1.
while ( getc(infile) != EOF ) size++;
> realloc(input,size);
Two things about realloc
- it assumes the input pointer is either NULL, or pointing to allocated memory; neither is true in this code.
- it also returns a pointer to the new memory, which you ignore anyway.
Start with this.
input = malloc(size);
> while(fread(&input, sizeof(struct person), 1, infile))
input is already a pointer, there is no need for the & here.
And to add one more to @Salem's list:Quote:
> realloc(input,size);
Two things about realloc
- it assumes the input pointer is either NULL, or pointing to allocated memory; neither is true in this code.
- it also returns a pointer to the new memory, which you ignore anyway.
Start with this.
input = malloc(size);
- never do this:
If you do and realloc cannot allocate memory, you'll end up with a "memory leakage".Code:input = realloc(input, size);
[]s
Fred
Yes, but you can still get a core dump of the program.Quote:
Originally Posted by Danai