C Programming Beginner in need of assistance!

Essentially, i am trying to create a program that when i type certain applications to open, the program will open that program.

Please see the below code. (Apologies if its messy its literally my first one).

Code:

---

#include <stdio.h>
#include <windows.h>
int main() {
char input[100];
char name[20];
{
printf("Hello User, please enter your name:\n", name);
scanf("%s", name);
printf("Thank you, %s\n", name);
}
{
    printf("What program would you like to open, %s?\n", name);
scanf("%s", input);
}
  if (strcmp(input,"Open Google Chrome") == 0);
{
    printf("Opening Google Chrome for you!\n");
    ShellExecute(NULL, "open","chrome.exe",NULL,NULL,SW_SHOWNORMAL);
}
//system("Start "C:\\Program Files (x86)\\Google\\Chrome\\Application\\chrome.exe"); This doesnt seem to work? Use shell Execute instead.
{
    printf("done");
}
return 0;
}

---

The issue is, if i type literally anything, it will still open Google Chrome. I want to have to type "Google Chrome" in order for it to open.

Does that make sense?

If so any help would be greatly appreciated, thanks!

Quote:

---

if i type literally anything, it will still open Google Chrome.

---

Code:

---

if(strcmp(input,"Open Google Chrome") == 0);

---

First thing i can see... remove the semicolon from the end of this line.
Your brackets are wacky also...

This is more towards what it should look like.

Code:

---

#include <stdio.h>
#include <windows.h>

int main() {
  char input[100];
  char name[20];

  printf("Hello User, please enter your name:\n", name);
  scanf("%s", name);
  printf("Thank you, %s\n", name);

  printf("What program would you like to open, %s?\n", name);
  scanf("%s", input);

  if (strcmp(input, "Open Google Chrome") == 0) {
    printf("Opening Google Chrome for you!\n");
    ShellExecute(NULL, "open", "chrome.exe", NULL, NULL, SW_SHOWNORMAL);
  };

  printf("done");
  return 0;
}

---

Also since you're using scanf() with the "%s" format specifier your variable will only contain one "word". If you want multiple words you will need something like fgets(). Also you should be using the correct optional width specifier to avoid possible buffer overflows.

this...

Code:

---

printf("Hello User, please enter your name:\n", name);

---

should be...

Code:

---

printf("Hello User, please enter your name:\n");

---

Thank you,

I dont even know why i had that there!

Hello,

Thanks for the reply,

Whilst i agree it looks a lot better, if i paste that code and run it, it doesnt open chrome, it just returns 0.

Thank you!

Quote:

---

Originally Posted by jimblumberg

Also since you're using scanf() with the "%s" format specifier your variable will only contain one "word". If you want multiple words you will need something like fgets(). Also you should be using the correct optional width specifier to avoid possible buffer overflows.

---

Hello,

Im not sure i understand the difference just yet, but ill look in to this.

Thank you!

I'm also starting to learn to code. I'm stuck on a particular piece of code.
print " pleathe enter a thtring : "
user_input= gets.chomp
user_input.include? "s"
print " This string has an s . "
end
I was informed by the code editor that I was using that it was wrong. What am I doing wrong, I went over it 5 times?

Quote:

---

if i paste that code and run it, it doesnt open chrome

---

Here is a working example...

Code:

---

#include <stdio.h>
#include <windows.h>

int main() {
  char input[100];
  char name[20];
 
  printf("Hello User, please enter your name:\n");
  scanf("%s", name);
 
  printf("Thank you, %s\n", name);
  printf("What program would you like to open, %s?\n", name);
  scanf("%s", input);
 
  if ( strcmp(input, "chrome") == 0 ) {
    printf("Opening Google Chrome for you!\n");
    ShellExecute(NULL, "open", "chrome.exe", NULL, NULL, SW_SHOWNORMAL);
  };
 
  printf("done");
  return 0;
}

---

Quote:

---

Originally Posted by j0801

I'm also starting to learn to code. I'm stuck on a particular piece of code.
print " pleathe enter a thtring : "
user_input= gets.chomp
user_input.include? "s"
print " This string has an s . "
end
I was informed by the code editor that I was using that it was wrong. What am I doing wrong, I went over it 5 times?

---

What language is that? Ruby? I think you took a wrong turn somewhere while you were looking for a programming forum.

Please see below code:

Code:

---

#include <stdio.h>
#include <windows.h>
int main() {
char input[100];
char name[20];
char option[10];
{
printf("Hello User, please enter your name:\n", name);
    scanf("%s", name);
    printf("Thank you, %s\n", name);
    printf("What program would you like to open, %s?\n", name);
    scanf("%s", input);
}
  if (strcmp(input,"Google") == 0){
    printf("Opening Google Chrome for you!\n");
    ShellExecute(NULL, "open","chrome.exe",NULL,NULL,SW_SHOWNORMAL);
    printf("Done!\n");}


  if (strcmp(input,"Outlook") == 0){
    printf("Opening Microsoft Outlook for you!\n");
    ShellExecute(NULL, "open","Outlook.exe",NULL,NULL,SW_SHOWNORMAL);
    printf("Done\n");}


  if (strcmp(input,"Putty") == 0){
    printf("Opening Putty for you!\n");
    ShellExecute(NULL, "open","Putty.exe",NULL,NULL,SW_SHOWNORMAL);
    printf("Done\n");}


//system("Start "C:\\Program Files (x86)\\Google\\Chrome\\Application\\chrome.exe"); This doesnt seem to work? Use shell Execute instead.
else {
          printf("no program entered, please enter another program\n");


}
printf("Is there another program you would like to open? Yes/No\n");
scanf("%s", option);
if (strcmp(option,"Yes")== 0){
    printf("Enter another program.\n");
    scanf("%s",input);}


    if (strcmp(input,"Google") == 0){
    printf("Opening Google Chrome for you!\n");
    ShellExecute(NULL, "open","chrome.exe",NULL,NULL,SW_SHOWNORMAL);
    printf("Done!\n");}


  if (strcmp(input,"Outlook") == 0){
    printf("Opening Microsoft Outlook for you!\n");
    ShellExecute(NULL, "open","Outlook.exe",NULL,NULL,SW_SHOWNORMAL);
    printf("Done\n");}


  if (strcmp(input,"Putty") == 0){
    printf("Opening Putty for you!\n");
    ShellExecute(NULL, "open","Putty.exe",NULL,NULL,SW_SHOWNORMAL);
    printf("Done\n");}


 else {
        printf("Okay, thank you.\n");
    }


return 0;
}

---

I am trying to add a loop so the user can enter a program over and over and over again without having to keep repeating the 'if' statements.

Any ideas on how i can integrate this loop in? I think it will be a while loop with a 'continue' at the bottom, right?

Any help would be amazing!

Something like

Code:

---

do {
    printf("What program would you like to open, %s?\n", name);
    scanf("%s", input);

    // your code
 
    printf("Is there another program you would like to open? Yes/No\n");
    scanf("%s", option);
} while ( strcmp(option,"Yes") == 0 );

---

Oh and don't start multiple threads with basically the same question.
https://cboard.cprogramming.com/c-pr...ml#post1289865