Getting a relative path from a dirent

Hey guys

I have a function that recursively searches a directory tree for files and grabs their size and name.

Code:

---

void printdir(char *rdir, char *dir, char *fullpath, int depth, int fd)
{
    DIR *dp;
    struct dirent *entry;
    struct stat statbuf;
    struct stat st;


    if((dp = opendir(dir)) == NULL) {
        fprintf(stderr,"cannot open directory: %s\n", dir);
        return;
    }
   
    chdir(dir);


    while((entry = readdir(dp)) != NULL) {
        lstat(entry->d_name,&statbuf);
        if(S_ISDIR(statbuf.st_mode)) {
            if(strcmp(".",entry->d_name) == 0 ||
                strcmp("..",entry->d_name) == 0)
                                                     
            printdir(rdir, entry->d_name, fullpath, depth+4, fd);
        }
        else if(S_ISREG(statbuf.st_mode))
        {                 
          char *name = entry->d_name                 
          stat(entry->d_name, &st);
          int size = st.st_size;
        }
    }


    chdir("..");
    closedir(dp);
}

---

It works fine but I'd like to get a file's name relative to the dir that it is searching, entry->d_name just returns the name of the file. I tried messing around with strcat() and strcpy() but I couldn't get desired results.

You've got an interestingly-named parameter named fullpath that you don't seem to be using -- is that where you want the full path to be stored? If so, then a straightforward approach might be:

1. Pass a blank character array the first time you call the function (ideally of size PATH_MAX).
2. If you come across a directory, strcat the directory name into your fullpath array, and put a slash on the end.
3. When you return from your recursive call, take out the slash at the end (i.e. overwrite it with a '\0' character), and use strrchr to find the previous slash at the end of the string so you can take out the new directory you just added. (Alternatively, and maybe easier, you can store in an int what position you should walk back to and write the '\0' character at. Technically that can require more memory to be added recursively, but it's just an int each time so you probably won't run out of memory unless you have a really complicated directory tree.)

Also are you sure about your comparisons with "." and ".."? Right now it looks like you're trying to change directories only when it is . or .., rather than all the other cases.

Forgot a continue statement when I posted my code.

But if I remove only the newest directory wouldn't that that still leave the higher level directories in fullpath?

Quote:

---

Originally Posted by pboy

But if I remove only the newest directory wouldn't that that still leave the higher level directories in fullpath?

---

It would, which is good, because you want them to still be there -- notice that (at the minimum) you still have to process all the files in the current directory so you don't want to take the path back to original blankness.