Print hexadecimal bin file

Hello.

I have a question. I need print my bin file in hexadecimal. I have function

Code:

---

void ReadFile(char *name){
    FILE *file;
    char *buffer;
    unsigned long fileLen;

    //open file
    file = fopen(name, "rb");
    if (!file)
    {
        fprintf(stderr, "Unable to open file %s", name);
        return;
    }

    //Size of file?
    fseek(file, 0, SEEK_END);
    fileLen=ftell(file);
    fseek(file, 0, SEEK_SET);

        //print size of my file
    fprintf(stderr, "\nSize of myfile.txt: %ld bytes.\n",fileLen);

    //Allocate memory
    buffer=(char *)malloc(fileLen+1);
    if (!buffer)
    {
        fprintf(stderr, "Memory error!");
        fclose(file);
        return;
    }

    //Read file contents into buffer
    fread(buffer, fileLen, 1, file);
    fclose(file);

    //Do what ever with buffer
    for(int i = 0; i < sizeof( buffer ); i++ )
    {
        if( i % 16 == 0 )
        {
            fprintf(stderr, "\n%08X: ", i );
        }
        fprintf(stderr, "%02X ", buffer[i] );
    }


    free(buffer);
}

---

And I need print complete my bin file. Now, my output is:

Code:

---

00000000: 00 00 02 20 05 1F 00 08

---

In file, you delete .zip
Attachment 15338

Use filelen rather than sizeof buffer in your loop.

Ok, I modifiy this function.

Code:

---

//Do what ever with buffer
    for(int i = 0; i < fileLen; i++ )
    {
        if( i % 16 == 0 )
        {
            fprintf(stderr, "\n%08X: ", i );
        }
        fprintf(stderr, "%02X ", buffer[i] );
    }

---

But my otput is:

Code:

---

00000000: 00 00 02 20 05 1F 00 08 FFFFFFE5 01 00 08 FFFFFFE9 01 00 08
00000010: FFFFFFED 01 00 08 FFFFFFF1 01 00 08 FFFFFFF5 01 00 08 00 00 00 00
00000020: 00 00 00 00 00 00 00 00 00 00 00 00 FFFFFFF9 01 00 08
00000030: FFFFFFFD 01 00 08 00 00 00 00 01 02 00 08 05 02 00 08
00000040: 55 1F 00 08 55 1F 00 08 55 1F 00 08 55 1F 00 08
00000050: 55 1F 00 08 55 1F 00 08 59 12 00 08 71 12 00 08
00000060: FFFFFF89 12 00 08 FFFFFFA1 12 00 08 FFFFFFB9 12 00 08 55 1F 00 08
00000070: 55 1F 00 08 55 1F 00 08 55 1F 00 08 55 1F 00 08
00000080: 55 1F 00 08 55 1F 00 08 55 1F 00 08 55 1F 00 08
00000090: 55 1F 00 08 55 1F 00 08 55 1F 00 08 FFFFFFD1 12 00 08

---

And now I have a problem. You can see output, but there are any problem sectors "FFFFFF"-

Problem was in print function.

Code:

---

for(int i = 0; i < fileLen; i++ )
    {
        if( i % 16 == 0 )
        {
            fprintf(stderr, "\n%08X: ", i );
        }
        fprintf(stderr, "%02X ", (int)(*(unsigned char*)(&buffer[i])) );
    }

---

And now is output:

Code:

---

00000000: 00 00 02 20 05 1F 00 08 E5 01 00 08 E9 01 00 08
00000010: ED 01 00 08 F1 01 00 08 F5 01 00 08 00 00 00 00
00000020: 00 00 00 00 00 00 00 00 00 00 00 00 F9 01 00 08
00000030: FD 01 00 08 00 00 00 00 01 02 00 08 05 02 00 08
00000040: 55 1F 00 08 55 1F 00 08 55 1F 00 08 55 1F 00 08
00000050: 55 1F 00 08 55 1F 00 08 59 12 00 08 71 12 00 08
00000060: 89 12 00 08 A1 12 00 08 B9 12 00 08 55 1F 00 08
.......
00001FB0: F8 B5 00 BF F8 BC 08 BC 9E 46 70 47 00 00 00 00
00001FC0: 00 00 00 00 01 02 03 04 06 07 08 09 00 00 00 00
00001FD0: 01 02 03 04 4D 4C 00 00 AD 01 00 08 89 01 00 08
00001FE0: 01 00 00 00 00 24 F4 00

---

All you had to do was make your buffer unsigned char* to begin with.
Then you can remove that cast mess.