Compile error? Logic error? Syntax Error? Please help

Can anyone please explain to me why this program won't correctly print the proper totals on screen? See my code and the included screenshot.

Code:

---


#include <stdio.h>

int main(void)
{
    int total, first, second;

    printf("Enter 2 numbers: \n\n");
    scanf_s("%d%d", &first, &second);
    total = first + second;
    printf("%d+%d=%d\n\n", first, second, total);
    total = first * second;
    printf("%d*%d=%d\n\n", &first, &second, &total);
    total = first - second;
    printf("%d-%d=%d\n\n", &first, &second, &total);
    total = first / second;
    printf("%d/%d=%d\n\n", &first, &second, &total);
    total = first % second;
    printf("%d%%d=%d\n\n", &first, &second, &total);
}

---

Attachment 13712Attachment 13711

There are ampersands in all of the printf() statements that are producing the wrong results.

Its because the result is too big for type 'int'. An 'int' is mostly 4 byte and can normaly have a value from –2147483648 to +2147483647.
Edit your code to use type 'long long'. This is normaly 8 byte and can hold the value from –9223372036854755808 to +9223372036854755807.
The type 'long long' has the format '%lld' in printf-function and familiar.

Hints:
The result of the division will look wrong, because a division with two integers give a integer as result. You loose the fraction.
The formatstring from your last printf-function is not correct. Make '%d%%d' to '%d\%%d'.

Edit:
Your main-function returns nothing. Insert 'return 0;' as last line.
I think the function 'scanf_s' is not standard (from Microsoft?). Use 'scanf' instead.

Quote:

---

Originally Posted by grumpy

There are ampersands in all of the printf() statements that are producing the wrong results.

---

Thanks grumpy. You nailed it!

Note that your compiler should have warned you about these issues. Make sure you always check compiler warnings, and that you have maximum warnings enabled.