Dynamic string problem !!

Hi,
I am trying this code and it should print out
ADAD
DADA
-------
DADA
ADAD

but it doesn't. Can someone please explain me whats wrong in this.

void main()
{
char *arr[30],*tem;
int i,j;

tem=(char *)calloc(5,sizeof(char));
// clrscr();

for(i=0;i<2;i++)
{
arr[i]=(char *)malloc(5*sizeof(char));
*tem=NULL;
for(j=0;j<4;j++)
{
if(fmod((j+i),2)==0){ strcat(tem,"A");}
else {strcat(tem,"D");}

}
arr[i]=tem;
puts(arr[i]);
}
puts("-----------");
puts(arr[1]);
puts(arr[0]);
getch();

}

> but it doesn't
What did it print then?

> void main()
Nope - use int main
See recent messages on the subject

> (fmod((j+i),
Why are you using this???
Try regular % for integer modulo

>arr [i] = tem;

That's why it goes wrong.

You want arr [0] to be ADAD and arr [1] to be DADA. First you put ADAD in tem and let arr [0] point to tem. So printing arr [0] results in ADAD. Then you put DADA in tem and let arr [1] point to tem. Printing arr [1] results in DADA. Since arr [0] also points to tem, printing arr [0] will now also result in DADA.

Further I don't understand the 30 in the string. You could declare arr as:

char arr [NR_OF_STRINGS][MAX_STRING_LEN];

And use the function strcpy to copy the string from tem to the array, since that is what you actually want. You want to create an array of strings, am I correct?

strcpy (arr [i], tem);

Further take the notes of Salem into account and do some error checking when allocating memory. The function malloc should not be casted, read Preludes note about it.

Quote:

---

It isn't required, though you can if you want to. But casting malloc can hide other errors such as forgetting to include stdlib.h. So it's considered good practice to not cast malloc, calloc, and realloc.

---