please help me correct this program

Code:

---

#include <servo.h>
 
const int servo1 = 3;      // first servo
const int servo2 = 10;      // second servo
const int joyH = 4;        // Joystick Horizontal Axis
const int joyV = 5;        // Joystick vertical Axis
 
int servoVal;          // variable to read the value from the analog pin
 
Servo myservo1;  // create servo object to control a servo
Servo myservo2;  // create servo object to control a servo
 
 
 
void setup() {
 
  // Servo
  myservo1.attach(servo1);  // attaches the servo
  myservo2.attach(servo2);  // attaches the servo
 
  // Inizialize Serial
  Serial.begin(9600);
}
 
 
void loop(){
 
    // Display Joystick values using the serial monitor
    outputJoystick();
 
    // Read the horizontal joystick value  (value between 0 and 1023)
    servoVal = analogRead(joyH);
    servoVal = map(servoVal, 0, 1023, 0, 180);    // scale it to use it with the servo (result  between 0 and 180)
 
    myservo2.write(servoVal);                              // sets the servo position according to the scaled value
 
    // Read the horizontal joystick value  (value between 0 and 1023)
    servoVal = analogRead(joyV);
    servoVal = map(servoVal, 0, 1023, 70, 180);    // scale it to use it with the servo (result between 70 and 180)
 
    myservo1.write(servoVal);                              // sets the servo position according to the scaled value
 
    delay(15);                                            // waits for the servo to get there
 
}
 
 
/**
* Display joystick values
*/
void outputJoystick(){
 
    Serial.print(analogRead(joyH));
    Serial.print ("---");
    Serial.print(analogRead(joyV));
    Serial.println ("----------------");
}

---

Correct how?

You don't say what is "wrong".
You don't say what would be considered "right".

You don't specify a main() to call it.
You don't specify what kind of device you're talking to - other than it seems to imply a servo and a joystick.

You don't document (or provide links to) what analogRead() and map() do.

sorry this program is for arduino uno its meant to control 2 servos via a thumbstick

Code:

---

#include <servo.h> 
const int servo1 = 3;      // first servo
const int servo2 = 10;      // second servo
const int joyH = 4;        // Joystick Horizontal Axis
const int joyV = 5;        // Joystick vertical Axis
 
int servoVal;          // variable to read the value from the analog pin
(its says servo does not name a type) 
Servo myservo1;  // create servo object to control a servo
Servo myservo2;  // create servo object to control a servo
 
 
 
void setup() {
 
  // Servo
  myservo1.attach(servo1);  // attaches the servo
  myservo2.attach(servo2);  // attaches the servo
 
  // Inizialize Serial
  Serial.begin(9600);
}
 
 
void loop(){
 
    // Display Joystick values using the serial monitor
    outputJoystick();
 
    // Read the horizontal joystick value  (value between 0 and 1023)
    servoVal = analogRead(joyH);
    servoVal = map(servoVal, 0, 1023, 0, 180);    // scale it to use it with the servo (result  between 0 and 180)
 
    myservo2.write(servoVal);                              // sets the servo position according to the scaled value
 
    // Read the horizontal joystick value  (value between 0 and 1023)
    servoVal = analogRead(joyV);
    servoVal = map(servoVal, 0, 1023, 70, 180);    // scale it to use it with the servo (result between 70 and 180)
 
    myservo1.write(servoVal);                              // sets the servo position according to the scaled value
 
    delay(15);                                            // waits for the servo to get there
 
}
 
 
/**
* Display joystick values
*/
void outputJoystick(){
 
    Serial.print(analogRead(joyH));
    Serial.print ("---");
    Serial.print(analogRead(joyV));
    Serial.println ("----------------");
}

---

Let me repeat what Salem said:

Quote:

---

Correct how?

You don't say what is "wrong".
You don't say what would be considered "right".

---

Arduino - Sweep

TBH, you would probably be better off asking on Index - Arduino Forum, where they're likely to know if there is any particular trick involved.
All we can do is read the manual (just like you), and maybe make a slightly better guess (but still a guess) as to what is wrong.

i'll try that any ways thanks a lot!