stop reading until newline in file pointer

Code:

---

#include <stdio.h>


int main()
{
        FILE *salesmanPtr;
        char buffer;


        salesmanPtr = fopen("salesman.txt","r");


        while(salesmanPtr != "\n")
        {
                fscanf(salesmanPtr,"%c", &buffer);
                printf("%c\n",buffer);
        }


}

---

I want the reading process stop when reaching newline but salesmanPtr is a pointer. How can I modify this code to make it works?

You are fairly close

A few things
-> main should be returning an integer at the end
-> You should test to see where salesmanPtr is not equal to NULL before using it
-> You should be using fclose (salesmanPtr) before the program ends

Also, for future development - You should check to see if the "end-of-file" is reached before the new line character

uh, salesmanPtr is the FILE descriptor. it doesn't point at a character, 'buffer' contains the character you read. I would check buffer != '\n', not salesmanPtr, which doesn't change.

You want to read the salesman.txt file. What do you want to do with the data you read in -- put it into a struct, put it into separate arrays, separate variables, or what?

There's an easy way to do this, I believe, but I can't tell you what it is, because I don't know what you want done with the data yet.

It's a good idea to compile with warnings:

Code:

---

gcc -Wall -Werror -o program program.c

---

Gives me this warning:

Quote:

---

program.c:10:23: error: comparison of distinct pointer types lacks a cast [-Werror]
program.c:10:23: error: comparison with string literal results in unspecified behavior [-Werror=address]

---

That will give you a big hint of where to look. Here is a fixed version:

Code:

---

#include <stdio.h>
 
int main()
{
    FILE *salesmanPtr;
    char buffer;
 
    salesmanPtr = fopen("salesman.txt","r");
 
    while(fscanf(salesmanPtr, "%c", &buffer) != EOF)
    {
        if (buffer == '\n')
            break;
        printf("%c\n",buffer);
    }
    return 0;
}

---