functions with arrays

Just learning functions and keep getting lost in the variables. So i took a step back and just tried to do a very basic adding function and its still not working. Where am i going wrong?

Code:

---

#include <stdio.h>


#define SIZE 50




int sum_array(int a[], int b);


int main( void )
{
    int n,i;
    int numbers[n];
 
        printf( "How many numbers would you like to add?: " );
        scanf( "%d", &n );


      for ( i = 0; i < n; i++ ) {
            printf( "Enter number %d: ", i + 1 );
            scanf( "%d", &numbers[i] );
        }






          printf( "The total of all the numbers is %d\n",sum_array(numbers,n));


    return 0;
}




int sum_array(int a[], int b)
{
    int i, sum =0;
    for ( i = 0; i < b; i++ ) {
        sum += a[i];}
        return sum;
     
 
}

---

Quote:

---

Code:

---

int sum_array(int a[], int b)
{
    int i, sum =0;
    for ( i = 0; i < b; i++ ) {
        sum += a[i];
        return sum;
    }
 
}

---

---

Your return is inside the loop. This way only the first time through the loop is executed and the loop terminates with the return.
In other words, the return is executed when i is 0 ... and i never gets to be 1, or 2, or whatever.

Ya, I just caught that one myself and edited it, however it's still not working. ?

Show the "fixed" code, and tell us how it's "still not working".

It executes and asks for the numbers, but doesnt add them. I just get a warning and compiler stops working with a "**process returned**" error.

Code:

---

#include <stdio.h>


#define SIZE 100




int sum_array(int a[], int b);


int main( void )
{
    int n,i;
    int numbers[n];
 
        printf( "How many numbers would you like to add?: " );
        scanf( "%d", &n );


      for ( i = 0; i < n; i++ ) {
            printf( "Enter number %d: ", i + 1 );
            scanf( "%d", &numbers[i] );
        }






          printf( "The total of all the numbers is %d\n",sum_array(numbers,n));


    return 0;
}




int sum_array(int a[], int b)
{
    int i, sum =0;
    for ( i = 0; i < b; i++ ) {
        sum += a[i];}
        return sum;
   
 
}

---

Quote:

---

Originally Posted by confusedd

Code:

---

    int n,i;
    int numbers[n];

---

---

n is uninitialized and has an undefined value. Therefore your numbers array has an undefined (unknown) size. It might be 0 or 1000000 or anything else. You also cannot resize the array later by changing the value of n.

Quote:

---

Originally Posted by confusedd

It executes and asks for the numbers, but doesnt add them. I just get a warning and compiler stops working with a "**process returned**" error.

---

Sorry. No!

Either it executes after the compiler produced an executable or the compiler failed to produce an executable.
You simply cannot have both (compier failing to produce an executable and the executable executing).

Ah! Thank you Christop!