Segmentation fault 11

I am trying merge sort an array of 5 numbers. g++ compiles the program without error but i am unable to execute due to segmentation fault 11. I have read the article on segmentation faults. I think writing off array endings might be responsible. How do I correct it?

Code:

---

:

---

Code:

---

#include <fstream>
#include <iostream>


using namespace std;


void sort(int A[], int size)
{
    if (size==1)
            return;
   
    int left[size/2], right[size/2+1], j=0, k=0;
   
    for(int i=1; i<=size; i++)
    {
        if(i<=size)
            left[++j] = A[i];
        else
            right[++k] = A[i];
    }
   
    sort(left, j);
    sort(right, k);
   
    int a=1, l=1, r=1;
    while(l+r <= j+k)
    {
        if((left[l]<right[r]) || (r==k))
            A[a++]=left[l++];
        else
            A[a++]=right[r++];
    }
}       


int main()
{
    int array[5]={4,5,1,0,10};
   
    sort(array, 5);
   
    for(int j=1; j<=5; j++)
        cout<<array[j]<<endl;
   
    return 1;
}

---

Quote:

---

Originally Posted by Chanakya

I am trying merge sort an array of 5 numbers. g++ compiles the program without error but i am unable to execute due to segmentation fault 11. I have read the article on segmentation faults. I think writing off array endings might be responsible. How do I correct it?

Code:

---

:

---

Code:

---

#include <fstream>
#include <iostream>


using namespace std;


void sort(int A[], int size)
{
    if (size==1)
            return;
   
    int left[size/2], right[size/2+1], j=0, k=0;
   
    for(int i=1; i<=size; i++)
    {
        if(i<=size)
            left[++j] = A[i];
        else
            right[++k] = A[i];
    }
   
    sort(left, j);
    sort(right, k);
   
    int a=1, l=1, r=1;
    while(l+r <= j+k)
    {
        if((left[l]<right[r]) || (r==k))
            A[a++]=left[l++];
        else
            A[a++]=right[r++];
    }
}       


int main()
{
    int array[5]={4,5,1,0,10};
   
    sort(array, 5);
   
    for(int j=1; j<=5; j++)
        cout<<array[j]<<endl;
   
    return 1;
}

---

---

you're doing

left[++j] = A[i];

while your i is from 1 to 5
your array indexes are 0 to 4

that should help you figure out the problems

Some notes:
C++ does not support variable length arrays, you're clearly using some non-standard compiler extension. I would advise against that.
You seem to be unaware that arrays start at zero in C++. An 'array[5]' has its items at positions: [0], [1], [2], [3], and [4]. 5 is not valid.
The function clearly fails when given zero items to sort. How about making that first if statement check for < 2 rather than == 1?
Rethink line 17. It makes no sense to be retesting the same expression as the for loop condition.

As has already been mentioned, in C-like languages it's very rare to see a loop like

Code:

---

for(int j=1; j<=5; j++)

---

Normally, because array indices begin at 0, you'd write code like this:

Code:

---

for(int j = 0; j < 5; j ++)

---

1-based array accesses are fairly common for pseudo-code but they don't really work in code. At least in languages like C++.

I have made the above changes but segmentation fault still persists.

Code:

---

#include <fstream>
#include <iostream>
 
 
using namespace std;
 
 
void sort(int A[], int size)
{
    if (size==1)
            return;
   
    int left[2], right[3], j=0, k=0;
   
    for(int i=0; i<size; i++)
    {
        if(i<=size/2)
            left[j++] = A[i];
        else
            right[k++] = A[i];
    }
   
    sort(left, j);
    sort(right, k);
   
    int a=0, l=0, r=0;
    while(l+r <= j+k)
    {
        if((left[l]<right[r]) || (r==k))
            A[a++]=left[l++];
        else
            A[a++]=right[r++];
    }
}       
 
 
int main()
{
    int array[5]={4,5,1,0,10};
   
    sort(array, 5);
   
    for(int j=0; j<5; j++)
        cout<<array[j]<<endl;
   
    return 1;
}

---

With size equal 5 what does size/2 equal?

NOTE: The location left[2] is passed the array bounds.

Tim S.

Code:

---

    int left[2], right[3], j=0, k=0;
     
    for(int i=0; i<size; i++)
    {
        if(i<=size/2)
            left[j++] = A[i];

---

Chanakya, I sincerely recommend you use std::array or std::vector instead of C arrays.
Then get familiar with the debugger. Don't wait on us to tell you what's wrong. This a good time to get some experience with debugging errors.

As much as we do suggest not using that C++ extension I had never seen used before and advised against, you should make sure that you write the function such that it will work for arbitrary sizes. Right now, it could only work when passed a size between 1 and 5. You need some form of dynamic memory allocation.

Being able to sort zero items is very important too. Ever had an empty folder sorted by name in explorer? Did it crash?
Or do you expect every single place that could ever call this function to do the check for zero iteself? That could be a lot of places!

Have more of a think about lines 27 and 29. On line 29, or-ed statements are evaluated left to right, with short-circuit-evaluation.