Need help fixing segmentation fault

Hi, I was just wondering if anyone could help me fix the segmentation fraud in the programme below:

Code:

---


#include <iostream>
#include <fstream>
#include <string>

using namespace std;
void Parse(string, string&, string&, string&, double&, int&);
void Display(string, string, string, double, int);

int main()
{
        fstream InFile("WindStation00.data", ios::in);
       
    string Line, ID, Date, Hour;
        double Speed;
        int Direction;

        while(!InFile.eof())  {
            InFile >> Line;
                cout << "LINE: " << Line << endl;
            Parse(Line, ID, Date, Hour, Speed, Direction);
                Display(ID, Date, Hour, Speed, Direction);

        }
    InFile.close();
        system("pause");
}
       
void Parse(string Line, string& ID, string& Date, string& Hour, double& Speed, int& Direction)
{       

                ID = strtok((char*)Line.c_str(), ":") ;
                Date =  strtok(0, ":");
                Hour = strtok(0, ":");
               
                Speed = atof(strtok(0, ":") ); //Converts a string of digits to a double...
        Direction = atoi( strtok(0, ":") ); //Converts a string of digits to an int...

               
}

void Display(string ID, string Date, string Hour, double Speed, int Direction)
{
            cout << "\tID = " << ID << endl;
                cout << "\tDate = " << Date << endl;
                cout << "\tHour = " << Hour << endl;
                cout << "\tSpeed = " << Speed << endl;
                cout << "\tDirection = " << Direction << endl;
}

---

I will greatly appreciate any suggestions. Thank You.

Code:

---

        ID = strtok((char*)Line.c_str(), ":") ;
        Date =  strtok(0, ":");
        Hour = strtok(0, ":");
       
        Speed = atof(strtok(0, ":") ); //Converts a string of digits to a double...
        Direction = atoi( strtok(0, ":") ); //Converts a string of digits to an int...

---

Yes, you go and lookup stringstream and find out how to break up a std::string using C++.

What you've done on line 1 is taken a very large axe, smashed down the door of data encapsulation and proceeded to trash all the internal data of a string object with your use of strtok()

> while(!InFile.eof())
And read the FAQ on why eof is a bad way of controlling a loop.

First off, it's a segmentation FAULT. ;) Secondly, do yourself a favor and run your program in a debugger. That way, you won't have to guess where the segmentation fault occurs ... your debugger will show you.

That said, I'm guessing the problem is somewhere in your Parse() function. Messing around with those old C-style functions is asking for trouble. Don't use strtok() on an std::string object. You're corrupting the object's internal state.