Making a file with a name passed as a parameter

Hi ,I have a method which makes a file by using the argument list as parameters.The only problem i have is that it does not work.

Code:

---

void openfile(struct file *p, const char * filename ){
   
    p->output=fopen(*filename,"w");
    if(p->output==NULL)
          fprintf(stderr,"out of memory\n");
   
}



int main(int argc, char** argv) {
    struct file*p=makeNewStruct();
    const char * f="hey";
    openfile(p,f);

---

p->output=fopen(*filename,"w");
should be:
p->output=fopen(filename,"w");

Quote:

---

Originally Posted by sand_man

p->output=fopen(*filename,"w");
should be:
p->output=fopen(filename,"w");

---

I did change it but it still has errors.It builds fine but fails when i run it

Please can anyone tell me what i am doing wrong

It does help if you post a small and complete sample of code that illustrates your problem. You have posted a fragment, and some code you haven't bothered to show may be contributing to the symptoms.

That said, things to check follow. Note that I am assuming, in several cases, that you are doing things in code that you have neglected to mention in your post.

1) Is makeNewStruct() returning a valid object? If p is a dangling pointer (i.e. it points to something that has ceased to exist), or a NULL, then the assignment of p->output gives undefined behaviour.

2) Have you #include'd <stdio.h>? A C compiler will assume fopen() returns int if you haven't. That causes your code to subtly exhibit undefined behaviour since there is a round-trip converstion from FILE * (inside fopen) to int, and back to FILE * (in the caller) - and that FILE * cannot be used safely (even comparing it with NULL can potentially be an invalid operation).

3) Does the current working directory, when your program is run, exist? And is it writable? If not, the operating system cannot create the file, and fopen() will return NULL.

4) Has other code in your program opened files, but neglected to close them? Most implementations have a distinct limit on the total number of files that a program may have open simultaneously. This can be an issue with some debuggers that keep files open when a program being debugged is terminated - the debugger itself gets confused.

I have found the problem