Simple password system

Code:

---

#include <iostream>

using namespace std;

string pw;                                              //The variable in which the password is stored.
int endprogram;                                        //A way to keep the program open.
int exitprog;

int main()
{
    cout<<"Enter password: \n";
    cin>> pw;                                          //Places the user input in the string variable pw.
    for(; ;) {                                          //An unconditional loop intended as a way to have multiple attempts.
              if(pw == "pw") {                        //If the password is "pw",
                    cout<< "Welcome.\n";              //print this.
                    cin>> exitprog;                    //Keeping the program open,
                    if (exitprog == 1) {              //and compares user input to 1
                              exit(0);                  //Exits program
                    }
              }
              else {                                  //Otherwise,
                    cout<< "Try again.\n";              //print this and begin the loop again so that the password may be entered.
                    cin>> endprogram;                  //^
              }
    }
}

---

It's obvious the program doesn't work but I'm not sure what to do to make it work. I want it to check whether pw is equal to "pw" and if it's not, print "Try again", and consequently "Enter password" again. Right now if you type in the wrong password it prints "Try again" and if you try to type in anything after that it loops that message infinitely.

Also I wonder if someone can tell me how to detect keypresses by the user, because if(exitprog == 1) is a quite awkward way to go about it. Instead I want a "Press any key to terminate" sort of thing.

Depending on exactly what you want it to do, you may just need to move the first cout and cin into the loop (at the top).

Quote:

---

Originally Posted by oogabooga

Depending on exactly what you want it to do, you may just need to move the first cout and cin into the loop (at the top).

---

Indeed. With a little tweaking (removing the cin from else) it works perfectly, at least it's what I wanted it to be. Though the welcome part is still very buggy. Anything but inputting 1 causes it to loop the messages "Enter password: " and "Welcome." infinitely. As I said I have no idea how to detect keypresses in C++, which is what I had in mind.

Detecting keypresses can't be done without some nonportable solution.
If you enter anything but an integer when reading into an integer, you must clear the input stream (google it).

Input is buffered in standard C/C++, which means you don't know anything until the user hits return. There are OS-specific solutions however...

Here is a Windows solution: http://cboard.cprogramming.com/cplus...tml#post481794

If you're not on Windows, here is how to implement "_getch()" on *nix: http://cboard.cprogramming.com/c-pro...tml#post991411

gg

However I still don't understand why it prints the messages "Enter password: " and "Welcome." precisely thrice when I input anything but 1. Here is a slightly updated version of the code:

Code:

---

#include <iostream>

using namespace std;

string pw;                                              //The variable in which the password is stored.
int endprogram;                                        //A way to keep the program open.
int exitprog;

int main()
{

    for(; ;) {                                          //An unconditional loop intended as a way to have multiple attempts.
        cout<<"Enter password: \n";
        cin>> pw;                                      //Places the user input in the string variable pw.
              if(pw == "pw") {                        //If the password is "pw",
                    cout<< "Welcome.\n";              //print this.
                    cin>> exitprog;                    //Keeping the program open,
                    if (exitprog == 1) {              //and compares user input to 1
                              exit(0);                  //Exits program
                    }
                    else {
                          getchar();
                    }
              }
              else {                                  //Otherwise,
                    cout<< "Try again.\n";              //print this and begin the loop again so that the password may be entered.
              }
    }
}

---

Compile it and run it and you'll see what I mean. Input "pw" as the password and then if you write anything other than 1 after that it does what I described above. Very peculiar.

FAQ > Why does my program enter an infinite loop if the user inputs invalid data? (C++) - Cprogramming.com

gg

Quote:

---

Originally Posted by Codeplug

FAQ > Why does my program enter an infinite loop if the user inputs invalid data? (C++) - Cprogramming.com

gg

---

Thanks. I get the idea, but it is a bit over my head. Namely "std::"; what exactly does it do (e.g. what is the difference between a non-std cout function and a std one?)? Otherwise it's simple enough, except for this part:

Code:

---

// Remove the unrecognized characters
    std::cin.ignore(std::numeric_limits<std::streamsize>::max(), '\n');

---

Why do you need to input any arguments anyway? And what does the maximum number of characters have to do with it? Isn't it just checking whether the input is an integer?

Besides, my program doesn't enter an infinite loop. As I said, it just prints the messages "Enter password: " and "Welcome.". It depends on the number or type of characters inputted how many times it prints those messages.