Files with strings and ints won't print to screen!

I have one file kristina.txt which holds data in the format below for one person with OCD, im supposed to open files from names the user enters for patients with OCD and then perform calculations on the number of times they do certain repetitions.

January 1 Monday brushed_teeth 9
January 1 Monday combed_hair 5
January 1 Monday stepped_up_bottom_step 20

From the first file comp.txt is used to display all possible compulsions for patients.
The code below prints all the text from comp.txt, but kristina.txt prints bogus numbers.
Also the section of code where the user enters the file name to open it i turned into a comment for now because it did not work, therefore i put the actual file name for now (kristina)

Code:

---

#include <stdio.h>
#include <stdlib.h>
int main()
{
   
    char compulsions[30];
  int patients=1;
  char month[10], day[10],comp[30];
  int date, reps;

printf("Welcome to Track Me");

FILE *ptr;

// open the file ".txt" for reading
ptr = fopen("comp.txt", "r");
if (ptr==NULL ){
    printf("File could not be opened");

}

fscanf(ptr,"%s",compulsions);
printf("List of ALL 15 Compulsions\n");
      while(!feof(ptr)){

printf("%s\n",compulsions);
fscanf(ptr,"%s",compulsions);

      }
      fclose(ptr);
//system("cls");
fflush;

//to search for patient file


//printf("Enter Patients Name to access file");
//scanf("%s",name);

FILE *search;


search = fopen("kristina.txt","r");
if (search==NULL ){
    printf("File could not be opened");

}

fscanf(search,"%s,%d, %s, %s,%d",month,&date,day,comp,&reps);


      while(!feof(search)){
char buffer[60];
fgets(buffer, 60, search);

printf("%s, %d, %s, %s, %d",buffer);         
fscanf(search,"%s, %d, %s, %s, %d", month, &date, &day, comp, &reps);

         


      }
      fclose(search);
}

---

You are accessing that file 3 times for every time you print data...

your first read at line 49 should work as you exepect if you get rid of the commas inside the quotes...

Quote:

---

fscanf(search," %s %d %s %s %d", month, &date, day, comp, &reps);

---

You need to lose lines 52 to 55 and 57... and fix your printf...
So your final print out should look like this...

Code:

---

while ( fscanf(search," %s %d %s %s %d", month, &date, day, comp, &reps) > 3)
  printf("%s %d %s %s %d\n",month, date, dat, comp, reps);

fclose(search);

---

Thank you :) it works, but for some reasons its skipping the first line and only printing the last 2 lines from the file and not the 3 lines

Quote:

---

Originally Posted by Kristyy_mariee

Thank you :) it works, but for some reasons its skipping the first line and only printing the last 2 lines from the file and not the 3 lines

---

You've still got line 49 in there don't you?
Lose it.

oh yeah i just took it out, works now. So, I just tried to read in name and then use that as the file name instead, but that doesnt work?

Post your current code...

Code:

---

#include <stdio.h>

int main()
{
   
    char compulsions[30];
    char name[20];
  int patients=1;
  char month[10], day[10],comp[30];
  int date, reps;

printf("Welcome to Track Me");


// open the text file "comp.txt" for writing
FILE *ptr;

// open the file ".txt" for reading
ptr = fopen("comp.txt", "r");
if (ptr==NULL ){
    printf("File could not be opened");

}

fscanf(ptr,"%s",compulsions);
printf("List of ALL 15 Compulsions\n");
      while(!feof(ptr)){

printf("%s\n",compulsions);
fscanf(ptr,"%s",compulsions);

      }
      fclose(ptr);


fflush;
//to search for patient file

//for (patients=1; patients <=15; patients++)
//{

//printf("Enter Patients Name to access file");
//scanf("%s",&name);

FILE *search;


search = fopen("kristina.txt","r");
if (search==NULL ){
    printf("File could not be opened");

}

//fscanf(search,"%s %d %s %s %d",month,&date,day,comp,&reps);

while ( fscanf(search,"%s %d %s %s %d", month, &date, day, comp, &reps) > 4)

  printf("%s %d %s %s %d\n",month, date, day, comp, reps);
 

fclose(search);
     



         


     
      }

---

You still have fopen hard coded...

That would cause what prob?

Your wanting to use name[20] as a file name correct? If so what is wrong here?

Code:

---


ptr = fopen("comp.txt", "r");

search = fopen("kristina.txt","r");

---

what the user enters would be stored as the string name, then i'd replace "kristina.txt" with name , but when i do that the file does not open.

Did you type .txt at the end?

Code:

---

FILE *ptr;
 
// open the file ".txt" for reading
ptr = fopen("comp.txt", "r");

---

Looking at your code, I don't see where you are asking the user to input a file name, and I don't see where that input is being stored int name[20]. Your file names are still hardcoded.

it should be something like

Code:

---

ptr=fopen(an_array_name, "r");

---

No i dont

The section of code that i commented out. I prompted the user to enter a file name
printf("Enter Patients Name to access file");

scanf("%s",&name);

If it WORKED i wouldve therefore put name when i go to open the file instead of having kristina.txt

You have to ask the person to enter the file name, using the printf and scanf statement...and when entering the file name you have to be sure to type "filename.txt" also making sure that the text file is in the correct folder.

Ah, my mistake. However, your scanf should be

Code:

---

scanf("%s", name);

---

The name of an array is pointing to an address, so you wouldn't need the address of operator (&).