Segmentation Fault?

Hello!

I just completed writing a program to ask a user for 2 words, pass them into a function, and use strcmp to let the user know which word is larger (or if they are equal). The program compiled and runs, but at the end it tells me 'Segmentation fault (core dumped)'. What does this mean? The only thing I could think of causing it is the 'char *msg = NULL' and printf using it, as this was something the professor told us to include, but never once in the class or the notes explains why? That's the only thing I can think of. Anyway, here is the code:

Code:

---


#include <stdio.h>
#include <string.h>

void word_order(char *string1, char *string2);  /* Create prototype of new function */

int main()
{

        char string1[30];
        char string2[30];
        /* create rest of code here */

        printf("\nPlease enter a word no more than 30 characters: ");
        scanf("%s", string1);
        printf("\nPlease enter another word no more than 30 characters: ");
        scanf("%s", string2);
        word_order(string1, string2);

        return 0;
}

void word_order(char *string1, char *string2)  /* New function here. */
{
        char *msg = NULL;

        /* create rest of code here */
        if (strcmp(string1, string2) > 0)
        { printf("First word is bigger than the second\n");}
        else if (strcmp(string1, string2) < 0)
        { printf("Second word is bigger than the first\n");}
        else
        {printf("Word one is equal to word two\n");}
        printf("%s\n", msg);
}

---

Any advice would be great! :) Thank you!

Code:

---

char *msg = NULL;
/* Other code that does nothing with msg */
printf("%s\n", msg);

---

So you're printing NULL, which is undefined behavior. In this case, your compiler's behavior (actually, maybe it's the C runtime's decision) is to segfault. Some compilers might print "(null)" when you do this. That's the problem with engaging in programming that invokes undefined behavior.

I believe a "segmentation fault" is when you try to assign a variable that tries to access memory that is unavailable to you.

From glancing through your code, it seems you are missing an & (ampersand) in lines 14 and 16 before your strings

Original:

Code:

---

        printf("\nPlease enter a word no more than 30 characters: ");
        scanf("%s", string1);
        printf("\nPlease enter another word no more than 30 characters: ");
        scanf("%s", string2);

---

Modified:

Code:

---

        printf("\nPlease enter a word no more than 30 characters: ");
        scanf("%s", &string1);
        printf("\nPlease enter another word no more than 30 characters: ");
        scanf("%s", &string2);

---

Kentric:

I didn't put an '&' because I was taught that you do not need one when you are working with arrays (both & and arrays point to a memory location).

rags_to_riches:

Thanks for your help! So.. I am still confused. Is that what I want to be happening based on what he wanted me to enter? Or is it something I failed to do? I have run the program just fine by removing it (the 'char *msg = NULL'), and I don't get the segmentation fault. Why did he want us to include it? This is something that was never covered, so I have no idea why he wanted us to include it in our code.

Thank you so much again! :)

Using & when you have a char array is unnecessary, but largely harmless (though gcc will complain sometimes with sufficient warnings enabled).

Using & when you have a char pointer is flat out wrong.

Saying scanf("%s", string); is just the same as scanf("%s", &string[0]);

Yes, string1 is equivalent to &string1[0]. Array names are converted to 'pointer to type' when used in an expression, except for the sizeof and unary & operators.

As for NULL, it is a void pointer guaranteed to not point to a real memory address. I'm not sure what your instructor is expecting you to use it for in this context. I suspect he/she wants some code that conditionally assigns msg to something other than NULL. If you are to use value of msg to output something, you would have to use it with an IF,

Code:

---

if( NULL == msg ) {...}

---

Clearly, as you know now, you can't use it to actually reference something if it's still pointing to NULL.