finding max in array using RECURSION

Code:

---

#include <stdio.h>


int getMax(int [], int, int, int);
int main(void)
{
        int arr[10]={0}, i;
        printf("Enter the 10 elements: ");
        for(i=0; i<10; i++)
        {
                scanf("%d", &arr[i]);
        }
       
        printf(" Maximum number is %d \n", getMax(arr, 10, 0, 0));
       
        return 0;
}


int getMax(int arr[], int size, int max, int i)
{
        if(i<size)
        {
                if(max<arr[i])
                        max= arr[i];


                getMax(arr, size, max , i++);
        }
       
        return max;
}

---

Hi, this is my code to find max number in the array using recursion. It cant run. cmd keep stopping! i tried to debug alot of time but just dont get it! Please help! Thanks!

Don't you want to use the return value? And you shouldn't be incrementing i, you just want to pass the next index to the function.

Code:

---

int getMax(int arr[], int size, int max, int i)
{
    if(i<size)
    {
        int rv;

        if(max<arr[i])
            max= arr[i];
 
 
        rv = getMax(arr, size, max , i + 1);
        if(max<rv)
            max = rv;
    }
   
    return max;
}

---

Quote:

---

Originally Posted by itsme86

Don't you want to use the return value?

Code:

---

int getMax(int arr[], int size, int max, int i)
{
    if(i<size)
    {
        int rv;

        if(max<arr[i])
            max= arr[i];
 
 
        rv = getMax(arr, size, max , i++);
        if(max<rv)
        max = rv;
    }
   
    return max;
}

---

---

i tried but it doesnt work still.

I added more changes, look at my previous post again.

Quote:

---

Originally Posted by itsme86

I added more changes, look at my previous post again.

---

Code:

---

int getMax(int arr[], int size, int max, int i){
        if(i<size)
        {
                if(max<arr[i])
                        max= arr[i];
                getMax(arr, size, max , i+1);
        }
       
        return max;
}

---

This works as well! Thanks! I just change i++ to i+1. I thought they both mean the same thing, why i++ will cause error?

Let's assume i is 10. i++ evaluates to 10, but assigns 11 to i. i + 1, on the other hand, evaluates to 11 and leaves i at 10.