Tic Tac Toe

Okay. Here are my instructions. I am not allowed to use Arrays.

Instructions:
You are to create a simulation of a tic-tac-toe game. Each position will be generated randomly based on a seed that is input by the user. The program will print the board, determine if it is a valid board (4 pieces of one and 5 of another, at most one winning pattern), and determine if there is a winner.
1) Prompt for and read in nonnegative user seed (function) Possible invalid entry: Ran out of data. Non-int data. Not nonnegative. When the user enters an invalid seed, the program should not process the rest of the program. Do NOT use exit() or abort() builtin functions. Use a Boolean function for getting the seed. 2) Generate board (function) 3) Print board (function) 4) Determine if valid (function) Possible errors: too many Xs or Os too many winning patterns If it is invalid, the program should not process the rest of the program. Use a Boolean function to determine if valid. 5) Determine if winner, and if so, whom, and if so, where. (function) 6) Print whether there is a winner, and if so, whom, and if so, where. (function)And here is the code that I have so far:

Code:

---

#include <stdio.h>#include <stdbool.h>


bool getInput(int* pInput);
int genBoard(int input);
void printBoard(int input, int topRow, int midRow, int bottomRow, int lCol,
                int midCol, int rCol, int lDiag, int rDiag);
int ifValid(int input, int topRow, int midRow, int bottomRow, int lCol,
            int midCol, int rCol, int lDiag, int rDiag);
int winner(int input, int topRow, int midRow, int bottomRow, int lCol,
          int midCol, int rCol, int lDiag, int rDiag);
void display(int input, int topRow, int midRow, int bottomRow, int lCol,
            int midCol, int rCol, int lDiag, int rDiag);




int main(void)
{
  int input;
  int topRow, midRow, bottomRow;
  int lCol, midCol, rCol;
  int lDiag, rDiag;

bool getInput(int* pInput)
{
  bool success = false;
  int scanRes;


  printf("\nName: Danielle Evans");
  printf("\nPlease enter a nonnegative integer seed: ");
  scanRes = scanf("%d", input);


  if (scanRes == 1)
  {
      int input = *pInput;


      if (input < 0)
      {
          printf("Not nonnegative. ");
      }
      else
        printf("\nRan out of data. ");
  }
  else if (scanRes == 0)
      printf("\nNon-int data. ");


  if(!success)
      printf("\n\n");


  return success;
}


int genBoard(int input)
{
 
}

void printBoard(int input, int topRow, int midRow, int bottomRow, int lCol,
                int midCol, int rCol, int lDiag, int rDiag)
{
}


int ifValid(int input, int topRow, int midRow, int bottomRow, int lCol,
            int midCol, int rCol, int lDiag, int rDiag)
{


}


int winner(int input, int topRow, int midRow, int bottomRow, int lCol,
          int midCol, int rCol, int lDiag, int rDiag)
{


}


void display(int input, int topRow, int midRow, int bottomRow, int lCol,
            int midCol, int rCol, int lDiag, int rDiag)
{


}


return 0;
}

---

My question is how do I do the genBoard() function and the printBoard() function? Also, is the code that I have so far correct?
Thanks

Instead of this:

Code:

---


int topRow, midRow, bottomRow;   
int lCol, midCol, rCol;   
int lDiag, rDiag;

---

do this

Code:

---

int game_board[3][3];

---

Then use two for loops to fill each spot. Take a look here also Arrays in C and C++ - Cprogramming.com

Random TicTacToe?! That's new...

Since it's talking about randomness, you must use the stdlib's functions "srand()" for the seed and "rand()" for the random numbers.
Say you have nine variables representing each square of the board, you can set it to "rand() % 2". Zero will be the one symbol, and one will be the other. About the printing and checking part, I guess you can figure them out.

I am not allowed to use an array.

Also, I am only supposed to use the #include stdio.h and #include stdbool.h

You can't nest your functions inside main(). Move them out.

She made us do a structure chart and she said that all 6 functions are inside of main

Then you are going to have to print each spot in the correct order, it's not that bad. Since you can't use an array you are going to need a variable for each spot (9 total). I would probably use char's instead of int's and use GReaper's suggestion to fill the spots.

Quote:

---

Originally Posted by Dannibe7

Also, I am only supposed to use the #include stdio.h and #include stdbool.h

---

Great... Don't worry, it's a good opportunity to make a Pseudo Random Number's Generator. :redface:

EDIT: I forgot, in C you don't have to have a prior declaration. Just call srand and rand and cross your fingers...

isnt the int game_board[3][3] an array?

Quote:

---

Originally Posted by Dannibe7

She made us do a structure chart and she said that all 6 functions are inside of main

---

Did your teacher actually tell you to create nested functions... or dis she by chance say they were "called from main"...

There is a difference.

C does not support nested functions... you cannot create a function inside a function...

Now just on the off chance your teacher did tell you to do that...
You seriously need to get a teacher who knows what he or she is talking about... 'cause yours doesn't.

Well I am assuming that it would be called from main then. but my structure chart has all of the functions coming off of main. So I should take all of these out of main?

Quote:

---

Originally Posted by Dannibe7

Well I am assuming that it would be called from main then. but my structure chart has all of the functions coming off of main. So I should take all of these out of main?

---

Exactly.

You do not make a tic-tac-toe game without using arrays; anyone who suggests to do otherwise is either a moron, or just trying to torture you.
That does not teach you how to program, it teaches you how not to program.

You don't jump into the sea with large juicy steaks tied to yourself in order to keep sharks away do you?! Don't do the opposite of what makes sense and expect to get something of practical value out of it.

Quote:

---

Originally Posted by GReaper

EDIT: I forgot, in C you don't have to have a prior declaration. Just call srand and rand and cross your fingers...

---

That's a dirty, nasty hack, which I'm sure the teacher wouldn't go for, and just a very bad idea in general. It can actually cause serious problems.

The declaration makes sure types are correct, but in the absence of a declaration, many compilers assume the function returns an int. This means the compiler can't properly check or convert return types for you. It will generate code assuming an int was returned, but that might not jive with what the called function puts on the stack or in a register for returning. Here's an example:

main.c

Code:

---

#include <stdio.h>

double foo(void)
{
    return 123.45;
}

int main(void)
{
    int x;

    x = foo();
    printf("After calling foo, for which the compiler knows the return type, x = %d\n", x);
    x = bar();
    printf("After calling bar, for which the compiler does NOT know the return type, x = %d\n", x);

    return 0;
}

---

func.c

Code:

---

double bar(void)
{
    return 123.45;
}

---

Compiling (ignoring the warning) and running gives:

Code:

---

$ gcc -Wall main.c func.c
main.c: In function ‘main’:
main.c:14: warning: implicit declaration of function ‘bar’
$ ./a.out
After calling foo, for which the compiler knows the return type, x = 123
After calling bar, for which the compiler does NOT know the return type, x = 73

---

If the compiler knew that bar returned double, it would correctly truncate the decimal portion and x would be 123 after calling bar too. This can be verified by putting the prototype for bar at the top of main.c.

Well our next project is to take this project and to turn it into arrays. But I am completely stuck on this project. I have no clue how to even begin to generate the board, and now that I moved all of the functions outside of main, I keep getting compile errors that I can't get rid of.

How would I start the genBoard function. I know how to do it if there were two players, but I dont know how to go about it with no players. I'm so lost.

Quote:

---

Originally Posted by anduril462

That's a dirty, nasty hack, which I'm sure the teacher wouldn't go for, and just a very bad idea in general. It can actually cause serious problems.

---

It is and it does, I agree. I just mentioned it for completeness... :D

You have nothing inside most of those functions, so get rid of everything you don't need yet. Just pick one function to work on at a time, and don't start anything else until that one is done and working. Write a little code, test it, fix any issues. Write a little more code, test it, fix any issues, etc.

Think about the game board. Draw one. How would you describe the position of each square to somebody...top-left, top-center, middle, center-right. Those should make good variable names for each square you're representing.

Start with the same function your program must start with, getting input. Then, write your printBoard function. Just hard code some data for starters, all O's or all X's (note, you may just want to use 0 and 1, see below), and make sure it displays properly. Then write your genBoard function.

To generate a full board, you need to generate 9 random numbers. If you had arrays, a loop would be great, but you don't, so you just have to do something like top_left = my_random_function() % 2. That will give you either a 0 or a 1 for each square. You can pick 0 to represent O and 1 for X, for example.

That should keep you busy for a while.

could I do that for all nine spots? such as,

int topLeft = rand() % 2;

could I use that same format for all 9?

Quote:

---

Originally Posted by Dannibe7

could I do that for all nine spots? such as,

int topLeft = rand() % 2;

could I use that same format for all 9?

---

Yes. You always want to generate one of two values, either an X (represented by a 1) or an O (represented by a zero). That % 2 guarantees that you get either a 0 or a 1.

Quote:

---

Originally Posted by Dannibe7

could I do that for all nine spots? such as,

int topLeft = rand() % 2;

could I use that same format for all 9?

---

Test it and find out.

Quote:

---

Originally Posted by Dannibe7

could I do that for all nine spots? such as,

int topLeft = rand() % 2;

could I use that same format for all 9?

---

Well, yes, that's the idea.

Quote:

---

Originally Posted by iMalc

You do not make a tic-tac-toe game without using arrays; anyone who suggests to do otherwise is either a moron, or just trying to torture you.
That does not teach you how to program, it teaches you how not to program.

You don't jump into the sea with large juicy steaks tied to yourself in order to keep sharks away do you?! Don't do the opposite of what makes sense and expect to get something of practical value out of it.

---

You could easily store the board in a 16-bit variable. Maybe they're supposed to learn about bit maps...

Quote:

---

Originally Posted by itsme86

You could easily store the board in a 16-bit variable. Maybe they're supposed to learn about bit maps...

---

Nice thinking, but unlikely since they're still struggling with variables and arrays. I think bitwise operators are teached later because they're a little more complex to understand.

okay so here is my code now. so now have to do the ifValid. There are Possible errors:
too many Xs or Os too many winning patterns If it is invalid, the program should not process the rest of the program. Use a Boolean function to determine if valid.I have changed the ifValid to a bool. can i do something like:

Code:

---

if(x>0 || y>0)return something;

---

?

Code:

---

#include <stdio.h>#include <stdbool.h>


bool getInput(int* pInput);
int genBoard(int input);
void printBoard(int input, int topL, int topC, int topR, int cenL,
                int cenC, int cenR, int botL, int botC, int botR);
int ifValid(int input, int topRow, int midRow, int bottomRow, int lCol,
            int midCol, int rCol, int lDiag, int rDiag);
int winner(int input, int topRow, int midRow, int bottomRow, int lCol,
          int midCol, int rCol, int lDiag, int rDiag);
void display(int input, int topRow, int midRow, int bottomRow, int lCol,
            int midCol, int rCol, int lDiag, int rDiag);


int main(void)
{
  int input;
  int topRow, midRow, bottomRow;
  int lCol, midCol, rCol;
  int lDiag, rDiag;
       
  return 0;
}


bool getInput(int* pInput)
{ 
  bool success = false;
  int scanRes;


  printf("\nName: Danielle Evans");
  printf("\nPlease enter a nonnegative integer seed: ");
  scanRes = scanf("%d", pInput);
   
  if (scanRes == 1)
  {
      int input = *pInput;


      if (input < 0)
      {
          printf("Not nonnegative. ");
      }
      else
        printf("\nRan out of data. ");
  }
  else if (scanRes == 0)
      printf("\nNon-int data. ");


  if(!success)
      printf("\n\n");


  return success;
}


int genBoard(int input)
{
  int topL = rand() % 2;
  int topC = rand() % 2;
  int topR = rand() % 2;
  int cenL = rand() % 2;
  int cenC = rand() % 2;
  int cenR = rand() % 2;
  int botL = rand() % 2;
  int botC = rand() % 2;
  int botR = rand() % 2;


  int x, y;
  x = 0;
  y = 0;


}


void printBoard(int input, int topL, int topC, int topR, int cenL,
                int cenC, int cenR, int botL, int botC, int botR)
{
  printf(" %c | %c | %c ", topL, topC ,topR);
  printf(" %c | %c | %c ", cenL, cenC, cenR);
  printf(" %c | %c | %c ", botL, botC ,botR);
}


int ifValid(int input, int topRow, int midRow, int bottomRow, int lCol,
            int midCol, int rCol, int lDiag, int rDiag)
{


}


int winner(int input, int topRow, int midRow, int bottomRow, int lCol,
          int midCol, int rCol, int lDiag, int rDiag)
{


}


void display(int input, int topRow, int midRow, int bottomRow, int lCol,
            int midCol, int rCol, int lDiag, int rDiag)
{


}

---

Okay, you're still doing too much at once without testing. Your input function does not work. No matter what I enter (even if it's a positive integer), it prints an error message and returns false. As for your genBoard function, you need to declare your board variables in main and pass them in, to be changed by genBoard. You don't need that x or y business. Your print function wont work, since 0 and 1 do not correspond to the ASCII symbols 'O' and 'X'.

For the first check, you know that each player has to occupy either a total of 4 or 5 squares. Since each variable is either a 0 or a 1, you can just check the sum of all the variables:

Code:

---

int total = topR + topC + topL + cenR ... etc.
if(total != 4 && total != 5)
  // return false

---

I dont know how to test it. I am using secure shell and when I do ./a.out it does not let me test it yet.

Quote:

---

Originally Posted by Dannibe7

I dont know how to test it. I am using secure shell and when I do ./a.out it does not let me test it yet.

---

One horrifying fact after another... What kind of bizarre class it this?! :mad:

Quote:

---

Originally Posted by Dannibe7

I dont know how to test it. I am using secure shell and when I do ./a.out it does not let me test it yet.

---

Well, you're not calling any of your functions from main() yet so you're probably just seeing your program exit right away. main() doesn't have a lot to do in your current code listing:

Code:

---

int main(void)
{
  int input;
  int topRow, midRow, bottomRow;
  int lCol, midCol, rCol;
  int lDiag, rDiag;
         
  // Where is this stuff?! You're not doing anything!

  return 0;
}

---

It wont magically test itself. You have to write your program to use your functions, then you test and see if they behave according to the assignment. You don't call any of your functions from main, so when you do ./a.out, your program doesn't actually do anything. You need to add code to main to call your functions so you can test if they work. Add a call to your getInput function, then compile and run your program. Does it do the right thing or produce the right error message when you enter "foo" or -123 or 42?

So far this seems better.

Code:

---

#include <stdio.h>#include <stdbool.h>


bool getInput(int* pInput);
int genBoard(int input);
void printBoard(int topL, int topC, int topR, int cenL,
                int cenC, int cenR, int botL, int botC, int botR);
bool ifValid(int topL, int topC, int topR, int cenL, int cenC,
            int cenR, int botL, int botC, int botR);
int winner(int topL, int topC, int topR, int cenL, int cenC,
            int cenR, int botL, int botC, int botR);
void display(int topL, int topC, int topR, int cenL, int cenC,
            int cenR, int botL, int botC, int botR);


int main(void)
{
  int input;
  int topL, topC, topR;
  int cenL,cenC, cenR;
  int botL, botC, botR;


  if (getInput(&input))
      display(topL, topC, topR, cenL, cenC, cenR, botL, botC, botR);


  return 0;
}


bool getInput(int* pInput)
{
  bool success = false;
  int scanRes;


  printf("\nName: Danielle Evans");
  printf("\nPlease enter a nonnegative integer seed: ");
  scanRes = scanf("%d", pInput);


  if (scanRes == 1)
  {
      int input = *pInput;


      if (input < 0)
      {
          printf("Not nonnegative. ");
      }
      else
      {
        if(scanRes == 0)
            printf("\nRan out of data. ");
      }
    }
  else if (scanRes == 0)
      printf("\nNon-int data. ");


  if(!success)
      printf("\n\n");


  return success;
}




int genBoard(int input)
{
  int topL = rand() % 2;
  int topC = rand() % 2;
  int topR = rand() % 2;
  int cenL = rand() % 2;
  int cenC = rand() % 2;
  int cenR = rand() % 2;
  int botL = rand() % 2;
  int botC = rand() % 2;
  int botR = rand() % 2;


  int x, o;
  x = 0;
  o = 1;


}


void printBoard(int topL, int topC, int topR, int cenL,
                int cenC, int cenR, int botL, int botC, int botR)
{
  printf(" %c | %c | %c ", topL, topC ,topR);
  printf(" %c | %c | %c ", cenL, cenC, cenR);
  printf(" %c | %c | %c ", botL, botC ,botR);
}


bool ifValid(int topL, int topC, int topR, int cenL,
            int cenC, int cenR, int botL, int botC, int botR)
{
  int total= topL + topC + topR + cenL + cenC+ cenR + botL + botC + botR;
  if(total !=4 && total !=5)
      return false;
}


int winner(int topL, int topC, int topR, int cenL, int cenC,
            int cenR, int botL, int botC, int botR)


{


}


void display(int input, int topRow, int midRow, int bottomRow, int lCol,
            int midCol, int rCol, int lDiag, int rDiag)
{


}

---

I'm not sure how the user is supposed to get the "Ran out of Data" reply though.

Quote:

---

Originally Posted by Dannibe7

I'm not sure how the user is supposed to get the "Ran out of Data" reply though.

---

Me neither. You'll have to check with your teacher or TA.

Code:

---

      if (input < 0)
      {
          printf("Not nonnegative. ");
      }
      else
      {
        if(scanRes == 0)
            printf("\nRan out of data. ");
      }

---

That can never be true. The only way to get to that if statement is if scanRes is 1. Actually, as a temporary solution to get you moving, just do the following:

Code:

---

if (input < 0)
{
    printf("Not nonnegative.");
}
else
{
    success = true;  // they entered a number and it's nonnegative, sounds like a winner to me
}

---

Regarding your genBoard function, you need to ditch the x and o bit entirely. Also, each "square" on your board needs to be passed in as a pointer to genBoard, so that the changes can be "passed back" to your main function. Here's what the function signature should look like:

Code:

---

int genBoard(int *topL, int *topC, ..., int *botR)

---

When you call it from main, you need to pass the address of the topR, etc variables so that genBoard can change them and have the changes be available in main.

printBoard has it's own problems. Each square will have a value of 0 or 1. Those numbers correspond to the ASCII characters null and start of header. Those characters don't actually show up on the screen. You need to check each square. If it's a 0, print an 'O', if it's a 1, print an 'X'. You also need to print a new line between each row of your game board.

Quote:

---

Originally Posted by Dannibe7

Well our next project is to take this project and to turn it into arrays.

---

Well okay it seems that your instructor really wants to drill into you why we have arrays. I can somewhat understand that, but I still don't like it.
Sure we learn by making mistakes, doing things the wrong way. But making you do it the wrong way in order to learn from that does not seem like the best approach. Especially for anyone in the class already understands right away why not using arrays would be silly.

Good luck! I'll be happy to help you turn in into arrays when you're ready to start doing that project.

So would my printboard be something like this?

Code:

---

if ( *pTopL == 0)
      {
        printf("\nX");
      }
      else printf("\nO");

---

and then repeated for all 9 spaces?

Thanks

Quote:

---

Originally Posted by Dannibe7

So would my printboard be something like this?

Code:

---

if ( *pTopL == 0)
      {
        printf("\nX");
      }
      else printf("\nO");

---

and then repeated for all 9 spaces?

Thanks

---

Almost, but you don't want that \n before each character. Only between each row. I would write another function that returns an 'X' or an 'O' based on whether a square is 0 or 1, and call that from my main print function:

Code:

---

char outputChar(int square)
{
    if (square)
        return 'X';
    else
        return 'O';
}

void printBoard(int topL, int topC, int topR, ..., int botR)  // no need for pointers here
{
    printf(" %c | %c | %c \n", outputChar(topL), outputChar(topC), ...);
    // same for middle and bottom rows
}

---

our program can only be the seven functions that I already have set up. is there a way to do all that all inside the print function?

What a ridiculous set of constraints. You can tell your professor I think he/she is a complete moron.

You could use the conditional operator ( ?: ), but that's probably outlawed too.

Code:

---

printf(" %c | %c | %c \n", topL ? 'X' : 'O', topC ? 'X' : 'O', ...);

---

Otherwise, you have to do something similar to what you suggested with an if/else for each square.

Okay so this is what I have now, I don't know where to go from here and I am sure that there are mistakes. I just don't know where. This is so confusing.

Code:

---

#include <stdio.h>
#include <stdbool.h>


bool getInput(int* pInput);
int genBoard(int* pTopL, int* pTopC, int* pTopR, int* pCenL,
            int* pCenC, int* pCenR, int* pBotL, int* pBotC, int* pBotR);
void printBoard(int* pTopL, int* pTopC, int* pTopR, int* pCenL,
                int* pCenC, int* pCenR, int* pBotL, int* pBotC, int* pBotR);
bool ifValid(int topL, int topC, int topR, int cenL, int cenC,
            int cenR, int botL, int botC, int botR);
int winner(int topL, int topC, int topR, int cenL, int cenC,
          int cenR, int botL, int botC, int botR);
void display(int topL, int topC, int topR, int cenL, int cenC,
            int cenR, int botL, int botC, int botR);


int main(void)
{
  int input;
  int topL, topC, topR;
  int cenL,cenC, cenR;
  int botL, botC, botR;


  if (getInput(&input))
      display(topL, topC, topR, cenL, cenC, cenR, botL, botC, botR);
  return 0;
}

bool getInput(int* pInput)
{
  bool success = false;
  int scanRes;


  printf("\nName: Danielle Evans");
  printf("\nPlease enter a nonnegative integer seed: ");
  scanRes = scanf("%d", pInput);


  if (scanRes == 1)
  {
      int input = *pInput;


      if (input < 0)
      {
          printf("Not nonnegative. ");
      }
      else
      {
        success = true;
      }
    }
  else if (scanRes == 0)
      printf("\nNon-int data. ");


  if(!success)
      printf("\n\n");


  return success;
}

int genBoard(int* pTopL, int* pTopC, int* pTopR, int* pCenL,
            int* pCenC, int* pCenR, int* pBotL, int* pBotC, int* pBotR)
{
  *pTopL = rand() % 2;
  *pTopC = rand() % 2;
  *pTopR = rand() % 2;
  *pCenL = rand() % 2;
  *pCenC = rand() % 2;
  *pCenR = rand() % 2;
  *pBotL = rand() % 2;
  *pBotC = rand() % 2;
  *pBotR = rand() % 2;
}

void printBoard(int* pTopL, int* pTopC, int* pTopR, int* pCenL,
                int* pCenC, int* pCenR, int* pBotL, int* pBotC, int* pBotR)
{
  if ( *pTopL == 0)
      {
        printf("X");
      }
      else printf("O");


  if ( *pTopC == 0)
      {
        printf("X");
      }
      else printf("O");


  if ( *pTopR == 0)
      {
        printf("X");
      }
      else printf("O");


  if ( *pCenL == 0)
      {
        printf("X");
      }
      else printf("O");


  if ( *pCenC == 0)
      {
        printf("X");
      }
      else printf("O");
if ( *pCenR == 0)
      {
        printf("X");
      }
      else printf("O");


  if ( *pBotL == 0)
      {
        printf("X");
      }
      else printf("O");


  if ( *pBotC == 0)
      {
        printf("X");
      }
      else printf("O");


  if ( *pBotR == 0)
      {
        printf("X");
      }
      else printf("O");


  printf(" %c | %c | %c \n", *pTopL, *pTopC, *pTopR);
  printf(" %c | %c | %c \n", *pCenL, *pCenC, *pCenR);
  printf(" %c | %c | %c \n", *pBotL, *pBotC, *pBotR);
}


bool ifValid(int topL, int topC, int topR, int cenL,
            int cenC, int cenR, int botL, int botC, int botR)
{
  int total= topL + topC + topR + cenL + cenC+ cenR + botL + botC + botR;


  if(total !=4 && total !=5)
      return false;
}
int winner(int topL, int topC, int topR, int cenL, int cenC,
          int cenR, int botL, int botC, int botR)


{


}


void display(int input, int topRow, int midRow, int bottomRow, int lCol,
            int midCol, int rCol, int lDiag, int rDiag)
{


}

---

Teacher = Moron ... yep.

One compromise would be to make the square variables chars and actually put X or O in them when randomizing.

Code:

---

square1 = (rand() % 2) ? 'X' : 'O';
// etc.

---

Then all you have to do is print them as character variables like this...

Code:

---

printf(" %c | %c | %c ", square1, square2, square3
// etc.

---

After this screwball assinment the OP will just love loops and arrays...

So to determine a winner would I just have to do a lot of if statements?

Quote:

---

Originally Posted by Dannibe7

So to determine a winner would I just have to do a lot of if statements?

---

A LOT of if() statements.

Okay so how can I set the topL topC and topR to the topRow?
That would be the winning pattern of topRow. I guess this would be going into the int winner() function

Interesting.

So, you can's use arrays, loops and addional functions, but can you use macros? This can be compressed:

Code:

---

void printBoard(int* pTopL, int* pTopC, int* pTopR, int* pCenL,
                int* pCenC, int* pCenR, int* pBotL, int* pBotC, int* pBotR)
{
  if ( *pTopL == 0)
      {
        printf("X");
      }
      else printf("O");
 
 
  if ( *pTopC == 0)
      {
        printf("X");
      }
      else printf("O");
 
 
  if ( *pTopR == 0)
      {
        printf("X");
      }
      else printf("O");
 
 
  if ( *pCenL == 0)
      {
        printf("X");
      }
      else printf("O");
 
 
  if ( *pCenC == 0)
      {
        printf("X");
      }
      else printf("O");
if ( *pCenR == 0)
      {
        printf("X");
      }
      else printf("O");
 
 
  if ( *pBotL == 0)
      {
        printf("X");
      }
      else printf("O");
 
 
  if ( *pBotC == 0)
      {
        printf("X");
      }
      else printf("O");
 
 
  if ( *pBotR == 0)
      {
        printf("X");
      }
      else printf("O");
 
 
  printf(" %c | %c | %c \n", *pTopL, *pTopC, *pTopR);
  printf(" %c | %c | %c \n", *pCenL, *pCenC, *pCenR);
  printf(" %c | %c | %c \n", *pBotL, *pBotC, *pBotR);
}

---

Into this:

Code:

---

#define PRINT_BOARD_HELPER(var)  if ( *var== 0)\
      {\
        printf("X");\
      }\
      else printf("O");
void printBoard(int* pTopL, int* pTopC, int* pTopR, int* pCenL,
                int* pCenC, int* pCenR, int* pBotL, int* pBotC, int* pBotR)
{
 
  PRINT_BOARD_HELPER(pTopL)
  PRINT_BOARD_HELPER(pTopC)
  PRINT_BOARD_HELPER(pTopR)
  PRINT_BOARD_HELPER(pCenL)
  PRINT_BOARD_HELPER(pCenC)
  PRINT_BOARD_HELPER(pCenR)
  PRINT_BOARD_HELPER(pBotL)
  PRINT_BOARD_HELPER(pBotC)
  PRINT_BOARD_HELPER(pBotR)

  printf(" %c | %c | %c \n", *pTopL, *pTopC, *pTopR);
  printf(" %c | %c | %c \n", *pCenL, *pCenC, *pCenR);
  printf(" %c | %c | %c \n", *pBotL, *pBotC, *pBotR);
}

---

Better yes?


From a broader perspective, you should avoid repeat code. The first remedy is a loop. If that's not applicable, try a function. As a last resort consider a macro.

Quote:

---

Originally Posted by Dannibe7

So to determine a winner would I just have to do a lot of if statements?

---

Quote:

---

Originally Posted by CommonTater

A LOT of if() statements.

---

Well there are only 8 ways to win.

Why are you using pointers on functions that never change their arguments? Also, what about empty squares? You are assuming that these boards have a full nine moves plotted?


Quzah.

Quote:

---

Originally Posted by quzah

Why are you using pointers on functions that never change their arguments? Also, what about empty squares? You are assuming that these boards have a full nine moves plotted?


Quzah.

---

Yeah, it says so in his first post:
1) Generate the board randomly
2) Evaluate if it's valid
3) Find the winner

Although, I don't understand why would someone want to do such a thing...

no players or moves

Well that explains one problem. But since you have randomly generated boards, how do you know who won first?

Code:

---

xox
oox
xox

---

Also, you still don't need to be using pointers for a function that isn't trying to change any values.


Quzah.

well if there are two sets of winning x's or o's I have to make make it say "too many winning patterns." Also if there are too many x's or o's (over5) then i have to make it say "too many x's or o's."

Well be sure you account for this:

Code:

---

*xx
xoo
xoo

---

x's final valid move is * which gives him 2 wins.


Quzah.

So the only pointer I need would be in the get input function? I should remove all the other pointers?

I think I am giving up.

So for the winning function. I have been trying to say that if topL, topC, and topR are all X, then print Congratulations, X! You are the winner. The winning pattern is top row. But I can't figure out how to do that.

Any suggestions?

You've just explained how.

Code:

---

if topL == X and topC == X and topR == X
    print yay you win X across the top row

---

Quzah.

that is what I have been trying. I just get error messages
is this what I should be tyring?

Code:

---

if(topL == X && topC ==X && topR ==X)
  printf("this stuff")

---

why is my print board function not printing? Can anyone tell?

I have got my code to this point. I cant get it to print the board. Can anyone help?
Thanks

Code:

---

int genBoard(int input)
{
  int topL = (rand() % 2);
  int topC = (rand() % 2);
  int topR = (rand() % 2);
  int cenL = (rand() % 2);
  int cenC = (rand() % 2);
  int cenR = (rand() % 2);
  int botL = (rand() % 2);
  int botC = (rand() % 2);
  int botR = (rand() % 2);


  if(topL == 1)
      printf("X");
  if(topL == 0)
      printf("O");


  if(topC == 1)
      printf("X");
  if(topC == 0)
      printf("O");


  if(topR == 1)
      printf("X");
  if(topR == 0)
      printf("O");


  if(cenL == 1)
      printf("X");
  if(cenL == 0)
      printf("O");


  if(cenC == 1)
      printf("X");
  if(cenC == 0)
      printf("O");
 if(cenR == 1)
      printf("X");
  if(cenR == 0)
      printf("O");


  if(botL == 1)
      printf("X");
  if(botL == 0)
      printf("O");


  if(botC == 1)
      printf("X");
  if(botC == 0)
      printf("O");


  if(botR == 1)
      printf("X");
  if(botR == 0)
      printf("O");


}


void printBoard(int topL, int topC, int topR, int cenL, int cenC,
          int cenR, int botL, int botC, int botR)
{
  printf(" %c | %c | %c \n", topL, topC, topR);
  printf(" %c | %c | %c \n", cenL, cenC, cenR);
  printf(" %c | %c | %c \n", botL, botC, botR);
}
bool ifValid(int topL, int topC, int topR, int cenL,
            int cenC, int cenR, int botL, int botC, int botR)
{
  int total = topL + topC + topR + cenL + cenC+ cenR + botL + botC + botR;


  if(total !=4 && total !=5)
      return false;
}


int winner(int topL, int topC, int topR, int cenL, int cenC,
          int cenR, int botL, int botC, int botR)
{
  int win;
  int topRow, midRow, botRow;
  int lCol, midCol, rCol;
  int rDiag, lDiag;




  if(topL == topC == topR)
      {
        win == topRow;
      }
        printf("\nThe winning pattern is the top row.");
  if(cenL == cenC == cenR)
      {
        win == midRow;
      }
  if(botL == botC == botR)
      {
        win == botRow;
      }
  if(topL == cenL == botL)
      {
        win == lCol;
      }
  if(topC == cenC == botC)
      {
        win == midCol;
 }
  if(topL == cenC == botR)
      {
        win == rDiag;
      }
  if(botL == cenC == topR)
      {
        win == lDiag;
      }
  return 1;
}


void display(int input, int topRow, int midRow, int bottomRow, int lCol,
            int midCol, int rCol, int lDiag, int rDiag)
{
  if(topRow == 'X')
      printf("Congratulations, X! You are the winner.");
  if(topRow == 'O')
      printf("Congratulations, O! You are the winner.");
}

---

Your genboard function should come before your printboard function in main.

it does

@Dannibe7
Firstly, where's main?

Second:
Values are passed either by reference, using a pointer, or by value. When passing around small things like integers, given the option, prefer passing by value.

Passing by value, means in the function the parameter is passed to uses a copy of the variable passed. Any changes to that copy do not change the original. Passing by reference mean that changes in the function are reflected in the original.

In your case, you want to make changes to variables that are declared in your genboard function. A good way to do this is to pass those variables by reference.

Third, there is another way to change variables using a function: assign the function result to it. This requires that your functions return the thing that you want to store. This is a good solution for functions like your current implementation of winner.

it didn't work when I had pointers either. I'm having a really difficult time with this.

The main thing that is bothering me is that I can't get the printBoard function to print to screen. I'm not sure if there is supposed to be a loop or something. I am not allowed to use arrays and I can't seem to do it this way.

You need pointers for genboard. You need to learn pointers, and use them.

As for printboard, your data is currently 0s and 1s. That's distinct from the characters '0' and '1', and certainly distinct from 'X' and 'O'. So you can't just say print your square variables as a character, like you're doing now.

Your if else solution was correct. It used pointers, which it shouldn't have, but it worked. It didn't display your board correctly because genboard wasn't working.

Logic wise there's no way around doing "if the value is 0 then print O, else print X". Fortunately, there is a shorthand for this. The conditional operator, also known as the ternary operator, acts like an if statement. The syntax is: condition? truebehavior: falsebehavior. The operator will check the condition, if it's true, then truebehavior is done and returned as the result of the operation. If it's false, falsebehavior is done and returned as the result. Note that truebehavior and falsebehavior must result in compatible types.

Code:

---

int genBoard(int* topL, int* topC, int* topR, int* cenL, int* cenC,
          int* cenR, int* botL, int* botC, int* botR)
{
  *topL = (rand() % 2);
  *topC = (rand() % 2);
  *topR = (rand() % 2);
  *cenL = (rand() % 2);
  *cenC = (rand() % 2);
  *cenR = (rand() % 2);
  *botL = (rand() % 2);
  *botC = (rand() % 2);
  *botR = (rand() % 2);

---

would that work?

Looks right.

Still can't get this thing to print the board.

Code:

---

//generate board
int genBoard(int* pTopL, int* pTopC, int *pTopR, int* pCenL, int *pCenC,
            int *pCenR, int* pBotL, int *pBotC, int *pBotR)
{
  int topL = *pTopL;
  int topC = *pTopC;
  int topR = *pTopR;
  int cenL = *pCenL;
  int cenC = *pCenC;
  int cenR = *pCenR;
  int botL = *pBotL;
  int botC = *pBotC;
  int botR = *pBotR;


  *pTopL = (rand() % 2) ? 'X' : 'O';
  *pTopC = (rand() % 2) ? 'X' : 'O';
  *pTopR = (rand() % 2) ? 'X' : 'O';
  *pCenL = (rand() % 2) ? 'X' : 'O';
  *pCenC = (rand() % 2) ? 'X' : 'O';
  *pCenR = (rand() % 2) ? 'X' : 'O';
  *pBotL = (rand() % 2) ? 'X' : 'O';
  *pBotC = (rand() % 2) ? 'X' : 'O';
  *pBotR = (rand() % 2) ? 'X' : 'O';
}


//print board
void printBoard(int topL, int topC, int topR, int cenL, int cenC,
          int cenR, int botL, int botC, int botR)
{
         
  printf(" %c | %c | %c \n", topL, topC, cenR);
  printf(" %c | %c | %c \n", cenL, cenC, cenR);
  printf(" %c | %c | %c \n", botL, botC, botR);
}

---

Do I need to make the print board with pointers too?

No, certainly not! Start with the top row, can you print it OK?

Then move to the middle row, etc. That way, it's not nearly as difficult.

You can line up your print statements, on the editor:

//print the board:

Code:

---


printf("  _______________
printf(" |  %d | %d | %d |\n", topL, topM, topR);
printf(" |---------------|");
printf(" |  %d | %d | %d |\n", midL, midM, midR);
printf(" |---------------|");
printf(" |  %d | %d | %d |\n", botL, botM, botR);
printf(" |---------------| ");

---

That's the basic idea. There are much nicer box drawing chars just for this, in the ascii char chars above the 126 level. If you don't have a basic and extended ascii char chart value, you should get one from one of the many places that has them, on line, and keep it handy.

I'll make this TTT diagram look better with an edit, time allowing.

none of it will print. I have no clue what I am doing wrong

If you want smooth edges all around, it gets complicated, but I believe your problem is actually a programming one, rather than a drawing one.

I'll check it tomorrow. You might want to look at this, for now:

Code:

---


#include <stdio.h>

#define TL 218
#define V  179
//#define THZ
#define TR 191
#define BL 192
#define BR 217
#define HZ 196
#define DT 194
#define UT 193
#define LT 195
#define MT 197
#define RT 180

int main(void) {


  char topL='X', topM='0', topR='X', midL='0', midM='X', midR='0', botL='0', botM='X', botR='0';

  printf("\n\n");
  printf("  %c%c%c%c%c%c%c%c%c%c%c%c%c\n", TL,HZ,HZ,HZ,DT,HZ,HZ,HZ,DT,HZ,HZ,HZ,TR); //top line
  printf("  %c  %c  %c  %c      \n", V,V,V,V);                                  //space line 
  printf("  %c %c %c %c %c %c %c      \n", V,topL,V,topM,V,topR,V);                //content line
  printf("  %c  %c  %c  %c      \n", V,V,V,V);                                  //space line
  printf("  %c%c%c%c%c%c%c%c%c%c%c%c%c\n", LT, HZ,HZ,HZ,MT,HZ,HZ,HZ,MT,HZ,HZ,HZ,RT);//divider
  printf("  %c  %c  %c  %c      \n", V,V,V,V);                                  //space 
  printf("  %c %c %c %c %c %c %c      \n", V,midL,V,midM,V,midR,V);                //content
  printf("  %c  %c  %c  %c      \n", V,V,V,V);                                  //space
  printf("  %c%c%c%c%c%c%c%c%c%c%c%c%c\n", LT, HZ,HZ,HZ,MT,HZ,HZ,HZ,MT,HZ,HZ,HZ,RT);//divider
  printf("  %c  %c  %c  %c      \n", V,V,V,V);
  printf("  %c %c %c %c %c %c %c      \n", V,botL,V,botM,V,botR,V);
  printf("  %c  %c  %c  %c      \n", V,V,V,V);
  printf("  %c%c%c%c%c%c%c%c%c%c%c%c%c\n", BL,HZ,HZ,HZ,UT,HZ,HZ,HZ,UT,HZ,HZ,HZ,BR);


  printf("\n\n");
  return 0;
}

/*

#define TL 218  Top Left Corner
#define V  179  Vertical |
#define TR 191  Top Right Corner
#define BL 192  Bottom Left Corner
#define BR 217  Bottom Right Corner
#define HZ 196  Horizontal bar
#define DT 194  Down facing 'T'
#define UT 193  Upward facing 'T'
#define LT 195  Left side 'T'
#define MT 197  Mid 'T'
#define RT 180  Right 'T'
*/

---

well it is due in an hour and a half. but thanks for helping.

OK, really quick:

1) Your generate board function is not returning an int, but says it will. Either return an int, or make it a void function.

2) Your board needs a dividing horizontal bar row, between each of the rows of char's:

Code:

---

Top line
space line
  X
space line
dividing line
space line
  O
space line
dividing line
etc.

---

Your board needs a top line, the dividing lines, and a bottom line, at least.

Your board values should be changed on the right hand side, from center to right.

Code:

---


  printf(" %c | %c | %c \n", topL, topC, cenR); <<== topR

---

Post your code so I can see your program!

I've got to leave very soon, post your code NOW if you can.

I had to start over,iIs this anywhere near right for my genBoard function?

Code:

---

int genBoard(int* pTopL, int* pTopC, int *pTopR, int* pCenL, int *pCenC,
            int *pCenR, int* pBotL, int *pBotC, int *pBotR)
{


  int topL = *pTopL;
  int topC = *pTopC;
  int topR = *pTopR;
  int cenL = *pCenL;
  int cenC = *pCenC;
  int cenR = *pCenR;
  int botL = *pBotL;
  int botC = *pBotC;
  int botR = *pBotR;




  topL = (rand() % 2) ? 'X' : 'O';
  topC = (rand() % 2) ? 'X' : 'O';
  topR = (rand() % 2) ? 'X' : 'O';
  cenL = (rand() % 2) ? 'X' : 'O';
  cenC = (rand() % 2) ? 'X' : 'O';
  cenR = (rand() % 2) ? 'X' : 'O';
  botL = (rand() % 2) ? 'X' : 'O';
  botC = (rand() % 2) ? 'X' : 'O';
  botR = (rand() % 2) ? 'X' : 'O';


  return 0;
}

---

This is wrong, just assign the values using the pointers directly like "*pTopL = (rand() % 2) ? 'X' : 'O';"

okay well so far I have this:

Code:

---

#include <stdio.h>
#include <stdbool.h>
#include <stdlib.h>

bool getInput(int* pInput);
int genBoard(int* pTopL, int* pTopC, int* pTopR, int* pCenL,
            int* pCenC, int* pCenR, int* pBotL, int* pBotC, int* pBotR);
void printBoard(int* pTopL, int* pTopC, int* pTopR, int* pCenL,
                int* pCenC, int* pCenR, int* pBotL, int* pBotC, int* pBotR);
bool ifValid(int topL, int topC, int topR, int cenL, int cenC,
            int cenR, int botL, int botC, int botR);
int winner(int topL, int topC, int topR, int cenL, int cenC,
          int cenR, int botL, int botC, int botR);
void display(int topL, int topC, int topR, int cenL, int cenC,
            int cenR, int botL, int botC, int botR);


int main(void)
{
  int input;
  int topL, topC, topR;
  int cenL,cenC, cenR;
  int botL, botC, botR;


  if (getInput(&input))
      genBoard(&topL, &topC, &topR, &cenL, &cenC, &cenR, &botL, &botC, &botR);         
      prtBoard(&topL, &topC, &topR, &cenL, &cenC, &cenR, &botL, &botC, &botR);
      display(topL, topC, topR, cenL, cenC, cenR, botL, botC, botR);
  return 0;
}




bool getInput(int* pInput)
{
  bool success = false;
  int scanRes;


  printf("\nName: Danielle Evans");
  printf("\nPlease enter a nonnegative integer seed: ");
  scanRes = scanf("%d", pInput);


  if (scanRes == 1)
  {
      int input = *pInput;


      if (input < 0)
      {
          printf("%d is not nonnegative. ", input);
      }
      else
      {
        success = true;
      }
    }
  else if (scanRes == 0)
      printf("\nNon-int data. ");


  if(!success)
      printf("\n\n");


  return success;
}










int genBoard(int* pTopL, int* pTopC, int* pTopR, int* pCenL,
            int* pCenC, int* pCenR, int* pBotL, int* pBotC, int* pBotR)
{
  *pTopL = (rand() % 2) ? 'X' : 'O';
  *pTopC = (rand() % 2) ? 'X' : 'O';
  *pTopR = (rand() % 2) ? 'X' : 'O';
  *pCenL = (rand() % 2) ? 'X' : 'O';
  *pCenC = (rand() % 2) ? 'X' : 'O';
  *pCenR = (rand() % 2) ? 'X' : 'O';
  *pBotL = (rand() % 2) ? 'X' : 'O';
  *pBotC = (rand() % 2) ? 'X' : 'O';
  *pBotR = (rand() % 2) ? 'X' : 'O';


void printBoard(int topL, int topC, int topR, int cenL,
                int cenC, int cenR, int botL, int botC, int botR)
{
  printf(" %c | %c | %c ", topL, topC ,topR);
  printf(" %c | %c | %c ", cenL, cenC, cenR);
  printf(" %c | %c | %c ", botL, botC ,botR);
}

---

and my output is:
Please enter a nonnegative integer seed: 1




| |
| A |
| | 3

IS something wrong with my getInput function?

You don't call "genBoard()" anywhere! What you're printing is garbage right now.

is this right?\

Code:

---

int main(void)
{
  int input;
  int topL, topC, topR;
  int cenL, cenC, cenR;
  int botL, botC, botR;


  if (getInput(&input))
      genBoard(&topL, &topC, &topR, &cenL, &cenC, &cenR, &botL, &botC, &botR);
      prtBoard(&topL, &topC, &topR, &cenL, &cenC, &cenR, &botL, &botC, &botR);
      display(&topL, &topC, &topR, &cenL, &cenC, &cenR, &botL, &botC, &botR);




    return 0;
}

---